From owner-svn-src-all@freebsd.org Thu Jan 14 21:26:46 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9EE1DA82DA8 for ; Thu, 14 Jan 2016 21:26:46 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3EEFB12F6 for ; Thu, 14 Jan 2016 21:26:46 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-wm0-x229.google.com with SMTP id f206so452917753wmf.0 for ; Thu, 14 Jan 2016 13:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=from:subject:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=qWYKJQUBZSIA3OKpDbMSDJCTeTqB1MYthVx83ZUMF4c=; b=CVGRl6gapPC2OizB19kDtiFLU33mdxiiR7DttnWe9KjKCM1Vgu+sIqnhYrcVgghiD6 veWOMlm16KAhB6g72qaRi5hGfUkf2bpra+qf7xfWoZP9eGLf5wAJkqyO9dIFosdoneC0 Vu7T3mUGRwj8fvGSShTNEJY6mwdJBy2EULUEnXCSG/vrCOUo3eoT5HQcBPwZpbGfccFx i3CSnrA5nWX/GZuz8nPpWIJR97dQOpGGk0tTpis/ztaFrkfY13Je2PM1t78m3Mk0io2z 2c+P2VSZsgFfcNyleagA5qbRUUBCyuF2tXuJRGn8MXEQJrG/eQctYnKM9SSrc2WNK9k2 LpUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=qWYKJQUBZSIA3OKpDbMSDJCTeTqB1MYthVx83ZUMF4c=; b=LwBBwmyUn2D8J6D4QaqKDTd5OTlMUcDlcjKpOJCEnzYA4gxuf3yGzMyQBE4qIdpgRv FqrhQOTEMEdyL/RM+SSjyf7FL9hM3iFNmGMRikgNUEzhFyA+x9viVWNnhD8MeHyVvX7k k3DyiOR6afSrgc9vDS/tYexaLEPfeAnVpM8yv83L31icdmNsFYqhpD2OQ+RI64GScAKl 98oYKpak8NEIm7uxsU2lRxyD64aEG2IWuNirOlbM1teNLgHUMw9sCiQSpCV1dcZDa4QO L8o8zychhm/wJLK+GxcIbNm1QHuL0Nl1HNKXn8WZw6pO2bRzwRQq8L0RgdR5z/7Yfstn yzHA== X-Gm-Message-State: ALoCoQmhS7NyjlIo1PTDjo4f5pB9MRTg77rRDZMmuIiq7+PLR7te8aRQ0kpsioAVLR3henu2oke71f3bKHet8iMHCWW2uMx8sw== X-Received: by 10.194.202.135 with SMTP id ki7mr7244720wjc.81.1452806804708; Thu, 14 Jan 2016 13:26:44 -0800 (PST) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id k130sm8994918wmg.6.2016.01.14.13.26.43 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Jan 2016 13:26:43 -0800 (PST) From: Steven Hartland X-Google-Original-From: Steven Hartland Subject: Re: svn commit: r294029 - in head/sys/boot/efi: . boot1 loader To: Nathan Whitehorn , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201601141853.u0EIrshB007863@repo.freebsd.org> <56980BAE.6070304@freebsd.org> Message-ID: <569812A6.9020101@freebsd.org> Date: Thu, 14 Jan 2016 21:27:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56980BAE.6070304@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 21:26:46 -0000 On 14/01/2016 20:57, Nathan Whitehorn wrote: > > > On 01/14/16 10:53, Steven Hartland wrote: >> Author: smh >> Date: Thu Jan 14 18:53:54 2016 >> New Revision: 294029 >> URL: https://svnweb.freebsd.org/changeset/base/294029 >> >> Log: >> Only build EFI components on supported compilers >> As the in-tree GCC does not support __attribute__((ms_abi)) EFI >> can only >> be built with Clang. >> The EFI loader and boot1 validated this, but unused libefi was >> still built >> causing issues under GCC after warnings where enabled by r293724. >> Disable building all of EFI when the selected compiler is GCC. > > How about with newer-than-4.2 versions of GCC? Surely this *is* > supported in newer compilers. Do we need some build infrastructure to > how about the compiler version as well as type? > -Nathan If it is then even without this change you wouldn't have have got the EFI loader or boot1, just an unused libefi. This change ensures that builds with in-tree Clang and GCC build on all platforms, even if GCC doesn't build the EFI components. If someone that uses none in-tree GCC has some time to dedicate to make this work that would be great :) Regards Steve Regards Steve