From owner-freebsd-current@freebsd.org  Sun Aug  9 18:26:01 2015
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 11A0699DCC7
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Sun,  9 Aug 2015 18:26:01 +0000 (UTC)
 (envelope-from kp@vega.codepro.be)
Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits))
 (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id CC098159D;
 Sun,  9 Aug 2015 18:26:00 +0000 (UTC)
 (envelope-from kp@vega.codepro.be)
Received: from vega.codepro.be (unknown [172.16.1.3])
 by venus.codepro.be (Postfix) with ESMTP id EEDAE9438;
 Sun,  9 Aug 2015 20:25:56 +0200 (CEST)
Received: by vega.codepro.be (Postfix, from userid 1001)
 id E8D347B451; Sun,  9 Aug 2015 20:25:56 +0200 (CEST)
Date: Sun, 9 Aug 2015 20:25:56 +0200
From: Kristof Provost <kp@FreeBSD.org>
To: Gleb Smirnoff <glebius@FreeBSD.org>
Cc: Patrick Kelsey <pkelsey@freebsd.org>, freebsd-current@freebsd.org
Subject: Re: sysctl -a panic on VIMAGE kernels
Message-ID: <20150809182556.GC48727@vega.codepro.be>
References: <B09833EB-ABE0-44BF-A53A-554207B92637@FreeBSD.org>
 <20150809103635.GA889@glebius.int.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20150809103635.GA889@glebius.int.ru>
X-Checked-By-NSA: Probably
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Aug 2015 18:26:01 -0000

On 2015-08-09 13:36:35 (+0300), Gleb Smirnoff <glebius@FreeBSD.org> wrote:
> On Sun, Aug 09, 2015 at 12:28:22PM +0200, Kristof Provost wrote:
> K> The following fixes it for me:
> K> 
> K> diff --git a/sys/netinet/tcp_reass.c b/sys/netinet/tcp_reass.c
> K> index 77d8940..3913ef3 100644
> K> --- a/sys/netinet/tcp_reass.c
> K> +++ b/sys/netinet/tcp_reass.c
> K> @@ -84,7 +84,7 @@ SYSCTL_INT(_net_inet_tcp_reass, OID_AUTO, maxsegments, CTLFLAG_RDTUN,
> K>      "Global maximum number of TCP Segments in Reassembly Queue");
> K> 
> K>  static uma_zone_t tcp_reass_zone;
> K> -SYSCTL_UMA_CUR(_net_inet_tcp_reass, OID_AUTO, cursegments, CTLFLAG_VNET,
> K> +SYSCTL_UMA_CUR(_net_inet_tcp_reass, OID_AUTO, cursegments, 0,
> K>      &tcp_reass_zone,
> K>      "Global number of TCP Segments currently in Reassembly Queue”);
> 
> Right, if a variable isn't virtualized, the CTLFLAG_VNET must be removed.
> 
> Patrick, how is your progress wuth improved reassembly?
> 
Any opposition to me committing the above patch? It'll at least make us
stop panic()ing and I don't think it'll make Patrick's life any harder.

Regards,
Kristof