From owner-svn-src-head@FreeBSD.ORG  Mon Jun  3 13:25:11 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 5A1D66FE;
 Mon,  3 Jun 2013 13:25:11 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com [87.251.56.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 1DF3D1CF4;
 Mon,  3 Jun 2013 13:25:10 +0000 (UTC)
Received: from spaceball.andric.com (spaceball.andric.com
 [IPv6:2001:7b8:3a7:0:204:4bff:fe01:de8a])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id CCAAC5C44;
 Mon,  3 Jun 2013 15:25:09 +0200 (CEST)
Message-ID: <51AC9933.7050201@FreeBSD.org>
Date: Mon, 03 Jun 2013 15:25:07 +0200
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:22.0) Gecko/20100101 Thunderbird/22.0
MIME-Version: 1.0
To: Marcel Moolenaar <marcel@FreeBSD.org>, src-committers@freebsd.org, 
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r250991 - in head: contrib/jemalloc/include/jemalloc
 include lib/libc/stdlib/jemalloc
References: <201305251859.r4PIxChc053341@svn.freebsd.org>
In-Reply-To: <201305251859.r4PIxChc053341@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Jun 2013 13:25:11 -0000

On 2013-05-25 20:59, Marcel Moolenaar wrote:
> Author: marcel
> Date: Sat May 25 18:59:11 2013
> New Revision: 250991
> URL: http://svnweb.freebsd.org/changeset/base/250991
>
> Log:
>    Make the malloc(3) family of functions weak and make their non-weak
>    implementations visible for use by applications. The functions $F that
>    are now weak symbols are:
>    	allocm, calloc, dallocm, free, malloc, malloc_usable_size,
>    	nallocm, posix_memalign, rallocm, realloc, sallocm
>
>    The non-weak implementations of $F are exported as __$F.

Hi Marcel,

This commit seems to lead to various problems in ports, and possibly
other software.  For example, with Firefox I now always get a few
messages like:

   firefox in free(): warning: malloc() has never been called

Another example is the devel/talloc port, which now dies with:

   [...]
   Checking linker accepts ['-undefined', 'dynamic_lookup']                                        : yes
   'configure' finished successfully (2m33.364s)
   <jemalloc>: /share/dim/src/freebsd/head/lib/libc/../../contrib/jemalloc/include/jemalloc/internal/arena.h:1002: Failed assertion: "((uintptr_t)ptr & PAGE_MASK) == 0"
   Abort trap (core dumped)
   ===>  Script "buildtools/bin/waf configure" failed unexpectedly.

See also the post here:
<http://lists.freebsd.org/pipermail/freebsd-current/2013-June/042220.html>

Can we please revert this commit for now, if a fix for these problems is
not readily available?

-Dimitry