From owner-svn-src-head@freebsd.org Mon Mar 2 20:30:03 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 43075259CC0 for ; Mon, 2 Mar 2020 20:30:03 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic315-55.consmr.mail.gq1.yahoo.com (sonic315-55.consmr.mail.gq1.yahoo.com [98.137.65.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48WWwT4sgyz3H9m for ; Mon, 2 Mar 2020 20:30:01 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: HOrKqRAVM1l8YuysRIm3EPvkj13Nh272BGjZJa8oxA_LGb4TI3zHU0WQ7H0OQNA 7K5F5LiaDY8k06P.x768qPNgEOA6eJBNIZv8Jtk8TSZ8mHW06kgUBKl3rPRbUV7qTie_lGghJELq 7C2EfQNX49xzx9iPlSAiaFYb_Z5rXXk9anngQeErG3QqXvYyMN3YwzV6YhQPwTCmP_p976md9KtI p1PpuV3MQaSaIBDDhDGgaImXslQZKIWLZRzDmIzwvfp4PPO0DKvIqXTWXPN5h1vNwpVajF7BmSGr tnofy5rHt1ZwGoIzjQzHfxKZPyWTdA8lQxYgvLdIOJfMqcgWelFeLCroBlbt88Aqx_LAfZW8Jft2 lY2FAQnwkpGbdwSZ0BqSD0fjlYqTW5oIgowbMPPXWy4F40._1ITgME5ccGVHtHUfvHzFUGjChIik pxAuzv4Psie3hZE3Bm7VAi2JX_ceIZKbgZuixtv1bkbn8IiNY4AXAl0BnbWEKb.2Pg.1ebkkoCFg AptXBqvyC6HEmm_h8f0vkIbAd_fyI97rruJb96oNw8qgmZvXN0IE9q8yCcxH33ZrRUIOeQhnSWJ2 KMyn_kjyiSWuXCnbi00Wxk27h7h92BQYVsCNYDOB0yLnzrFlzfzK0INmnZ_nw3M7I4kVzIn4T8qe .3jXryKeSi.mH62AZfd3YhVav6Mskfqcur0kuoLZrL12SX7ti2GCVQnk0E3dSKU5RO6wwQaXDnuS xuZyAQVhDR8tvdTQDWlMyu8HcQZvRwS53axBHzIaBHrsBnghvyqfw6RocZ2SgD1.sp1ZuDS3FzTF LZEEVkGRDs6D8p1TGsWP6in4WSKMg4n4kwv.xRO0uASRj0y_ol5QdWyK1aWc0LtSjjuAyo7D_kCH DDcx5Oo2VPO3Oi4rNxalHqYDGdCxr12t1YmvvIbafMgodBeWzS2Goxhf3nRc81zAGILSEtphAiUl y5_jt_53cDfgoqXjAK2i7bl7gGGAm75w3hE8aGSaYOcnwwMlnh8NDZWf8wPnRBsM5gQhdPnzF6jK x4JJatrj_AisQckBuKn8atb3XSYTNI1JWNb20idhCl.C.7Pz8PVFPe9XRSI2GUsw6FW8O5JKPYYc bwcKpiwwe9e5X7aS2k8z251HIt05fmeGKqRudO99jbAajQ1wocfLqCjYnbHEsYnWYVKz0ztSKRnQ JWIcFwE.OWNpu_ANEaw3k82tys5rI7zW_Irv2FPTMbJXwyU.lxZKw5GxwomMyGwb6lqlAm3Y_HJh NYjq1jfbRwk6bT_Jh.mzzRptnWXoqHoo9KKUKzhqvyJxqGQ5m0XwgWcXHEh9jT56UCyPZt1TZZ1x Ud4rEeSigBVGDq9oQ_38DQGzxbT3IDBWTG.TUviG2YPXGbLyUE0WiqwcYGKt5q5teL9xwgmFRgNw Ar6WIHKL5_vbXTBp465ck3U4H5mgDEbmwC1I90PexOFwRpTFhxJhHFbk- Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Mon, 2 Mar 2020 20:29:58 +0000 Received: by smtp421.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 5e90a35535faa41e09bfc226db67a470; Mon, 02 Mar 2020 20:29:57 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: svn commit: r358439 - head/sys/amd64/include Message-Id: <4ED174D6-EBC4-4F0D-B9C5-639E10016C4D@yahoo.com> Date: Mon, 2 Mar 2020 12:29:55 -0800 To: Konstantin Belousov , svn-src-head@freebsd.org X-Mailer: Apple Mail (2.3608.60.0.2.5) References: <4ED174D6-EBC4-4F0D-B9C5-639E10016C4D.ref@yahoo.com> X-Rspamd-Queue-Id: 48WWwT4sgyz3H9m X-Spamd-Bar: / X-Spamd-Result: default: False [-0.76 / 15.00]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; MIME_GOOD(-0.10)[text/plain]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-0.92)[-0.915,0]; RCVD_COUNT_TWO(0.00)[2]; NEURAL_SPAM_MEDIUM(0.65)[0.655,0]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[31.65.137.98.list.dnswl.org : 127.0.5.0]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.00)[ip: (3.72), ipnet: 98.137.64.0/21(0.83), asn: 36647(0.67), country: US(-0.05)]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Mar 2020 20:30:03 -0000 Konstantin Belousov kostikbel at gmail.com wrote on Mon Mar 2 18:27:05 UTC 2020 ": > On Mon, Mar 02, 2020 at 09:13:53AM -0800, Ryan Libby wrote: > > On Mon, Mar 2, 2020 at 12:45 AM Alexander V. Chernikov wrote: > > > > > > 28.02.2020, 18:32, "Ryan Libby" : > > > > Author: rlibby > > > > Date: Fri Feb 28 18:32:36 2020 > > > > New Revision: 358439 > > > > URL: https://svnweb.freebsd.org/changeset/base/358439 > > > > > > > > Log: > > > > amd64 atomic.h: minor codegen optimization in flag access > > > > > > > > Previously the pattern to extract status flags from inline = assembly > > > > blocks was to use setcc in the block to write the flag to a = register. > > > > This was suboptimal in a few ways: > > > > - It would lead to code like: sete %cl; test %cl; jne, i.e. a = flag > > > > would just be loaded into a register and then reloaded to a = flag. > > > > - The setcc would force the block to use an additional = register. > > > > - If the client code didn't care for the flag value then the = setcc > > > > would be entirely pointless but could not be eliminated by = the > > > > optimizer. > > > > > > > > A more modern inline asm construct (since gcc 6 and clang 9) = allows for > > > This effectively restricts kernel builds by all older compilers. > > > Is there any chance of making it conditional depending on the = compiler version/features? > What is the older compiler you need to use for base system ? > And why ? [A copy of something I sent to svn-src-head and rlibby a on Feb 29 that showed the example of 2 ports failing to build on FreeBSD build servers, where the server sent out the notice of the failure.] head -r358439 breaks unmodified ports that use, for example, clang70 and clang++70: = https://lists.freebsd.org/pipermail/freebsd-emulation/2020-February/017672= .html = https://lists.freebsd.org/pipermail/freebsd-emulation/2020-February/017675= .html show things like . . . kBuild: Compiling HGSMIGuestR0Lib - = /wrkdirs/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.34/s= rc/VBox/GuestHost/HGSMI/HGSMICommon.cpp clang-7: warning: argument unused during compilation: '--param = inline-unit-growth=3D100' [-Wunused-command-line-argument] clang-7: warning: argument unused during compilation: '--param = large-function-growth=3D1000' [-Wunused-command-line-argument] In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.34/s= rc/VBox/GuestHost/HGSMI/HGSMICommon.cpp:38: In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.34/i= nclude/VBox/Graphics/VBoxVideoIPRT.h:32: In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.34/i= nclude/iprt/string.h:45: In file included from /usr/src/sys/sys/libkern.h:41: In file included from /usr/src/sys/sys/systm.h:44: /usr/include/machine/atomic.h:230:1: error: invalid output constraint = '=3D@cce' in asm ATOMIC_CMPSET(char); ^ /usr/include/machine/atomic.h:205:4: note: expanded from macro = 'ATOMIC_CMPSET' : "=3D@cce" (res), /* 0 */ \ ^ /usr/include/machine/atomic.h:230:1: error: invalid output constraint = '=3D@cce' in asm /usr/include/machine/atomic.h:222:4: note: expanded from macro = 'ATOMIC_CMPSET' : "=3D@cce" (res), /* 0 */ \ ^ /usr/include/machine/atomic.h:231:1: error: invalid output constraint = '=3D@cce' in asm ATOMIC_CMPSET(short); ^ /usr/include/machine/atomic.h:205:4: note: expanded from macro = 'ATOMIC_CMPSET' : "=3D@cce" (res), /* 0 */ \ ^ /usr/include/machine/atomic.h:231:1: error: invalid output constraint = '=3D@cce' in asm /usr/include/machine/atomic.h:222:4: note: expanded from macro = 'ATOMIC_CMPSET' : "=3D@cce" (res), /* 0 */ \ ^ /usr/include/machine/atomic.h:232:1: error: invalid output constraint = '=3D@cce' in asm ATOMIC_CMPSET(int); ^ /usr/include/machine/atomic.h:205:4: note: expanded from macro = 'ATOMIC_CMPSET' : "=3D@cce" (res), /* 0 */ \ ^ /usr/include/machine/atomic.h:232:1: error: invalid output constraint = '=3D@cce' in asm /usr/include/machine/atomic.h:222:4: note: expanded from macro = 'ATOMIC_CMPSET' : "=3D@cce" (res), /* 0 */ \ ^ /usr/include/machine/atomic.h:233:1: error: invalid output constraint = '=3D@cce' in asm ATOMIC_CMPSET(long); ^ /usr/include/machine/atomic.h:205:4: note: expanded from macro = 'ATOMIC_CMPSET' : "=3D@cce" (res), /* 0 */ \ ^ /usr/include/machine/atomic.h:233:1: error: invalid output constraint = '=3D@cce' in asm /usr/include/machine/atomic.h:222:4: note: expanded from macro = 'ATOMIC_CMPSET' : "=3D@cce" (res), /* 0 */ \ ^ /usr/include/machine/atomic.h:280:4: error: invalid output constraint = '=3D@ccc' in asm : "=3D@ccc" (res), /* 0 */ ^ /usr/include/machine/atomic.h:296:4: error: invalid output constraint = '=3D@ccc' in asm : "=3D@ccc" (res), /* 0 */ ^ /usr/include/machine/atomic.h:312:4: error: invalid output constraint = '=3D@ccc' in asm : "=3D@ccc" (res), /* 0 */ ^ /usr/include/machine/atomic.h:328:4: error: invalid output constraint = '=3D@ccc' in asm : "=3D@ccc" (res), /* 0 */ ^ =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)