From owner-freebsd-ports@FreeBSD.ORG Wed Jul 25 05:43:01 2007 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5231116A420 for ; Wed, 25 Jul 2007 05:43:01 +0000 (UTC) (envelope-from stephen@math.missouri.edu) Received: from cauchy.math.missouri.edu (cauchy.math.missouri.edu [128.206.184.213]) by mx1.freebsd.org (Postfix) with ESMTP id 2D8C313C48D for ; Wed, 25 Jul 2007 05:43:00 +0000 (UTC) (envelope-from stephen@math.missouri.edu) Received: from laptop2.gateway.2wire.net (cauchy.math.missouri.edu [128.206.184.213]) by cauchy.math.missouri.edu (8.14.1/8.13.4) with ESMTP id l6P5gx4Z052028; Wed, 25 Jul 2007 00:43:00 -0500 (CDT) (envelope-from stephen@math.missouri.edu) Message-ID: <46A6E2E3.7020305@math.missouri.edu> Date: Wed, 25 Jul 2007 00:42:59 -0500 From: Stephen Montgomery-Smith User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8.1.5) Gecko/20070721 SeaMonkey/1.1.3 MIME-Version: 1.0 To: Paul Schmehl , FreeBSD Ports References: <20070724195845.GA37472@droso.net> In-Reply-To: <20070724195845.GA37472@droso.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: How do you remove unneeded patch files? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2007 05:43:01 -0000 Erwin Lansing wrote: > On Tue, Jul 24, 2007 at 02:41:04PM -0500, Paul Schmehl wrote: >> I'm working on a port upgrade. The existing port has a number of patch >> files in FILESDIR that are no longer needed. (The changes they made have >> been incorporated into the distro.) What's the appropriate way to submit >> those changes? Normally, a send-pr submission will contain the patches for >> existing port files. There is no patch for these. They need to be removed. >> >> I could do this: diff -Naur files/original_patch_file files/empty_file, but >> I don't know if that removes the file or simply replaces it with an empty >> one. >> > The result of using that patch would be an empty file. This is also > alright to submit it that way, but as a courtesy to the committer (and > also to make sure he doesn't forget) it would be good to mention in the > PR that file/xyz and files/abc should be removed completely. You really should be unambiguous and clear in explaining that the files are to be deleted. I have had a couple of experiences where ports I maintain did not have the files deleted, and I had to remind the committer. Stephen