From owner-freebsd-current@FreeBSD.ORG  Wed May  4 06:35:42 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 15629106564A;
	Wed,  4 May 2011 06:35:42 +0000 (UTC)
	(envelope-from mckusick@mckusick.com)
Received: from chez.mckusick.com (chez.mckusick.com [64.81.247.49])
	by mx1.freebsd.org (Postfix) with ESMTP id CD9EE8FC13;
	Wed,  4 May 2011 06:35:41 +0000 (UTC)
Received: from chez.mckusick.com (localhost [127.0.0.1])
	by chez.mckusick.com (8.14.3/8.14.3) with ESMTP id p445xEJ5024585;
	Tue, 3 May 2011 22:59:14 -0700 (PDT)
	(envelope-from mckusick@chez.mckusick.com)
Message-Id: <201105040559.p445xEJ5024585@chez.mckusick.com>
To: Garrett Cooper <yanegomi@gmail.com>
In-reply-to: <BANLkTik4=O_1PWB2GzGzY=m51dG-Kbhe+Q@mail.gmail.com> 
Date: Tue, 03 May 2011 22:59:14 -0700
From: Kirk McKusick <mckusick@mckusick.com>
X-Spam-Status: No, score=0.4 required=5.0 tests=MISSING_MID, SUBJECT_FUZZY_TION,
	UNPARSEABLE_RELAY autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on chez.mckusick.com
X-Mailman-Approved-At: Wed, 04 May 2011 11:15:30 +0000
Cc: FreeBSD Current <freebsd-current@freebsd.org>
Subject: Re: Nasty non-recursive lockmgr panic on softdep only enabled UFS
	partition when filesystem full 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 May 2011 06:35:42 -0000

> Date: Tue, 3 May 2011 22:40:26 -0700
> Subject: Nasty non-recursive lockmgr panic on softdep only enabled UFS
>  partition when filesystem full
> From: Garrett Cooper <yanegomi@gmail.com>
> To: Jeff Roberson <jeff@freebsd.org>,
>         Marshall Kirk McKusick <mckusick@mckusick.com>
> Cc: FreeBSD Current <freebsd-current@freebsd.org>
> 
> Hi Jeff and Dr. McKusick,
>     Ran into this panic when /usr ran out of space doing a make
> universe on amd64/r221219 (it took ~15 minutes for the panic to occur
> after the filesystem ran out of space -- wasn't quite sure what it was
> doing at the time):
> 
> ...
> 
>     Let me know what other commands you would like for me to run in kgdb.
> Thanks,
> -Garrett

You did not indicate whether you are running an 8.X system or a 9-current
system. It would be helpful to know that.

Jeff thinks that there may be a potential race in the locking code for
softdep_request_cleanup. If so, this patch for 9-current should fix it:

Index: ffs_softdep.c
===================================================================
--- ffs_softdep.c	(revision 221385)
+++ ffs_softdep.c	(working copy)
@@ -11380,7 +11380,8 @@
 				continue;
 			}
 			MNT_IUNLOCK(mp);
-			if (vget(lvp, LK_EXCLUSIVE | LK_INTERLOCK, curthread)) {
+			if (vget(lvp, LK_EXCLUSIVE | LK_NOWAIT | LK_INTERLOCK,
+			    curthread)) {
 				MNT_ILOCK(mp);
 				continue;
 			}

If you are running an 8.X system, hopefully you will be able to apply it.

	Kirk McKusick