From owner-freebsd-ports@FreeBSD.ORG Wed Dec 19 11:34:18 2007 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B8E0616A418; Wed, 19 Dec 2007 11:34:18 +0000 (UTC) (envelope-from jdc@parodius.com) Received: from mx01.sc1.parodius.com (mx01.sc1.parodius.com [72.20.106.3]) by mx1.freebsd.org (Postfix) with ESMTP id A24F613C47E; Wed, 19 Dec 2007 11:34:18 +0000 (UTC) (envelope-from jdc@parodius.com) Received: by mx01.sc1.parodius.com (Postfix, from userid 1000) id 7BD341CC038; Wed, 19 Dec 2007 03:34:18 -0800 (PST) Date: Wed, 19 Dec 2007 03:34:18 -0800 From: Jeremy Chadwick To: Barry Byrne Message-ID: <20071219113418.GA11378@eos.sc1.parodius.com> References: <000f01c8422b$3515d7b0$c5010c0a@SUNYA> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000f01c8422b$3515d7b0$c5010c0a@SUNYA> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: ports@FreeBSD.org, hiromi@tac.tsukuba.ac.jp, beech@FreeBSD.org, perky@freebsd.org Subject: Re: FreeBSD Port: horde-base-3.1.5_1 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2007 11:34:18 -0000 On Wed, Dec 19, 2007 at 10:37:52AM -0000, Barry Byrne wrote: > Just portupgraded from horde-base-3.1.5 to 3.1.5_1 and ended up with an > parse error in NSL.php. > > Checked the patched file (NLS.php) and I had something like this; > > \xa0 \xa0 \xa0 \xa0/* avoid FreeBSD issapce(3) bug */ > \xa0 \xa0 \xa0 \xa0if(NLS::getCharset() == "UTF-8"){ > \xa0 \xa0 \xa0 \xa0 \xa0 \xa0setlocale(LC_CTYPE,"C"); > \xa0 \xa0 \xa0 \xa0} > > When I replaced the \xa0 with tabs, all was fine again. The parse error is probably because PHP does not have Unicode or multibyte character support enabled. The patch file in question contains actual Unicode characters. You might try rebuilding PHP with Zend support for multibyte characters (it's an option in "make config") and see if that improves things. IMHO, the files/patch-lib_Horde_NLS.php patch should be using ASCII characters for the actual source to ensure 100% compatibility. There's nothing in that patch that requires the source itself to contain non- breaking spaces (UTF-8 which I assume is what 0xa0 is). > Perhaps it's something with my system (6.2Release p-9), but I've not had an > issue like this before. There's a PR for this commit. I've CC'd people on the PR, as this probably needs some additional focus. http://www.freebsd.org/cgi/query-pr.cgi?pr=116363 -- | Jeremy Chadwick jdc at parodius.com | | Parodius Networking http://www.parodius.com/ | | UNIX Systems Administrator Mountain View, CA, USA | | Making life hard for others since 1977. PGP: 4BD6C0CB |