From nobody Mon Jun 24 21:16:12 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W7LNv3TbKz5PgV6; Mon, 24 Jun 2024 21:16:15 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W7LNv2cKqz46V9; Mon, 24 Jun 2024 21:16:15 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1719263775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9SHoNvz6qe7Xk4GZNJx4Ur/qrWVKCjW9DeNzGIoSkHQ=; b=lZ2g+11y2Vt3AK66HOanFR7Xrl+tNvxT7kEpvYe/Vf+Hw01wYOaY8Ns2YNNv4b5tOkPqSN dJBvyIqinanATCTo2d3VX9BtMSgP3H8dZi5+6dIWPA4STFsoCTuNDT4cf6HjxOj7N+cjkU zmK+NYfg95vjiDgQRe9VQrMSnlQElHQ0zluiQ+QCnJOAVWIMq3t9YB/CXO/UPmmniS+Nlb 80Jby4mrYtZP+FMdMqDSi9r2Q8dTw4eylAgpCslaiFLc8uIaBK31AUT5JqqF3zpI3SRkcg e6eEtX64Lqdvp74Oppn/UB1Qydah1IRDr7i4xW1wbvOWg0J7Cqze4eCKm4zMdw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1719263775; a=rsa-sha256; cv=none; b=YjAKWr7slIQ+D48mbMl9bJOY+1uJz2gheWofbCWjfJ5fKUgnUPAFqiVGf52/+73csyVCIb qiSnIWaHXtlOyGmkxGsfGIijF//VDHVEUZk4tjAh6k7lYY8iV/OpQgC8fBLVpypb4rau+M WbZuR+dwVymb7vFMP0tDcDsuq31wkCp7ln4r0TO3Ge++78sJFXn1R/bN7BNgzBkPVvXENb kW+fllCXTG0Vj96lKBC8O3pPa2n3+a5T1AG3ZfXrZHkn0PHDp4rgmeQAYbdUcv6Rm/5hi7 7/uZmFlg80anTe5KzECZEJErcj/w9LWhKJIGwngKk/1XNPi0iK5KGfpMuaJNhg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1719263775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9SHoNvz6qe7Xk4GZNJx4Ur/qrWVKCjW9DeNzGIoSkHQ=; b=cvQiiz+G2+PjuCik0pSJHDcSaAvlcS0aTHfdsrRHJvowFiAnVz4xlvYVSeTKTTyg4gXxt1 0Ks/gFhR2mDgYvds/t6lQpCHEzdog+Xz5n1cv+ylRc/Wm5bTjWFDRRSu/2rA8Y6A080gV7 JlmauQzn8HmWkbxFC9pj6YhnfPbeJbgyGWFniu9Gyomc1y6E03hHGcaiUGCbkHWUqSd5+j 3nrusdUyjkz798Q1skGQXmvRYV/R2q2kyFHXnJ9UNz073h9fYzmIFxvv2kz51Pbr9oZLxw xSltuTNVsJtz5jHVpbTiwnHwplrNaZgEeSlPDCLzcFylBB9RdlpM6/iFUjlFVA== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4W7LNt53h2z1GNF; Mon, 24 Jun 2024 21:16:14 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Mon, 24 Jun 2024 14:16:12 -0700 From: Gleb Smirnoff To: Justin Hibbits Cc: imp@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c2e9c5bbf022 - main - tpm: Refactor TIS and add a SPI attachment Message-ID: References: <202405032032.443KWhf0045034@gitrepo.freebsd.org> <20240624161128.33c0f518@ralga.knownspace> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240624161128.33c0f518@ralga.knownspace> On Mon, Jun 24, 2024 at 04:11:28PM -0400, Justin Hibbits wrote: J> > sorry for late notice, but we just discovered that after this commit J> > tpm(4) on ACPI no longer attaches. From what I see ther probe method J> > isn't even called. J> J> Hi Gleb, J> J> That's very odd. The probe method hasn't changed, nor has the tpm_acpi J> attachment (still acpi), so I'm really confused why it wouldn't be J> called now. Is there any debugging you can do to further narrow it J> down? I haven't seen any issues reported internally at Juniper on x86 J> hardware. I just verified everything should get built properly. I started adding printfs to the probe method and as said - it is not even called. So I puzzled on where to start the debugging. I can test patches/ideas if you have any. Warner is also looking into this problem. -- Gleb Smirnoff