From owner-freebsd-current@FreeBSD.ORG  Fri Jun 30 09:09:17 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6530516A40F
	for <freebsd-current@freebsd.org>; Fri, 30 Jun 2006 09:09:17 +0000 (UTC)
	(envelope-from mb@imp.ch)
Received: from smtp.imp.ch (mx2.imp.ch [157.161.9.17])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C0BCD4482E
	for <freebsd-current@freebsd.org>; Fri, 30 Jun 2006 09:09:15 +0000 (GMT)
	(envelope-from mb@imp.ch)
Received: from godot.imp.ch (godot.imp.ch [157.161.4.8])
	by smtp.imp.ch (8.13.7/8.13.7/Submit) with ESMTP id k5U99Am6083596
	for <freebsd-current@freebsd.org>;
	Fri, 30 Jun 2006 11:09:14 +0200 (CEST) (envelope-from mb@imp.ch)
Date: Fri, 30 Jun 2006 11:09:09 +0200 (CEST)
From: Martin Blapp <mb@imp.ch>
To: freebsd-current@freebsd.org
Message-ID: <20060630101132.S14714@godot.imp.ch>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Scanned-By: MIMEDefang 2.57 on 157.161.9.65
Subject: Please help reviewing ! Got another crash because of the ttymodem()
 / ttyclose() race
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Jun 2006 09:09:17 -0000


Hi all,

This time its FreeBSD 5.5 RELEASE. Same code is in 6.X (which crashed on a 
different server 5 days ago) and CURRENT.

#25 0xc064f4bd in ttymodem ()
#26 0xc06532bd in ptcclose ()
#27 0xc05e4e14 in spec_close ()
#28 0xc05e3edf in spec_vnoperate ()
#29 0xc06815e0 in vn_close ()
#30 0xc06825f2 in vn_closefile ()
#31 0xc0601ba4 in fdrop_locked ()
#32 0xc0601af1 in fdrop ()
#33 0xc060015b in closef ()
#34 0xc05fd5e5 in close ()
#35 0xc07c5e97 in syscall ()

Can PLEASE PLEASE someone help me fix this problem
and review the patch ?

The patch is based on Max Laiers tty.t_pgrp patch.

http://mx.imp.ch/patch-tty.t_pgrp.diff

Especially the part in ttyinfo() needs to be reviewed
carefully.

Martin

Martin Blapp, <mb@imp.ch> <mbr@FreeBSD.org>
------------------------------------------------------------------
ImproWare AG, UNIXSP & ISP, Zurlindenstrasse 29, 4133 Pratteln, CH
Phone: +41 61 826 93 00 Fax: +41 61 826 93 01
PGP: <finger -l mbr@freebsd.org>
PGP Fingerprint: B434 53FC C87C FE7B 0A18 B84C 8686 EF22 D300 551E
------------------------------------------------------------------