From owner-svn-src-head@freebsd.org Mon Oct 16 22:53:36 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DF860E47CF5; Mon, 16 Oct 2017 22:53:36 +0000 (UTC) (envelope-from andriyvos@gmail.com) Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com [209.85.215.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 706137116E; Mon, 16 Oct 2017 22:53:36 +0000 (UTC) (envelope-from andriyvos@gmail.com) Received: by mail-lf0-f54.google.com with SMTP id b190so18728084lfg.9; Mon, 16 Oct 2017 15:53:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:subject:references:date:cc:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=wXcDISDg2Zryl11xPnqo6LjIVghYKKsHQq9G0YgkfeA=; b=SKjDQvJNbc0qKdyOiG8a8deY6UMyH92FmWTPAAyypDMRak1snVO7JAD9tNJMsbul1a AzaFrp5hJrbY+qOBHrGhvutm0nP8hav2qO8E+mLkAIoksvOwTLGR+OVFiEKKGCSAA7EO CZALNaNykLiAIL9iVNCCxmm0FBrhgHT77aEjrQVEdxTHbMOHqThNosQn36t2ghGxnB3A m6TFJYWIMg+PE1OppFuGtbJxpmTIqZe6iyH5hJBTqK0GayzSOplUYcXhgTI92rUtVqKB gNzWQrFZ6VLhTYUlzvdKvuL0U+KDUPb13+39o96RIcudd16ecv7gd3SWhVhukI7pOT+G ONyg== X-Gm-Message-State: AMCzsaUY+8BdG30l0eJFlqwevxvNWxyMROcOfQjEzdXcL2u6zuAuBxDj PtNApWyLN76RWgEsYRSTY5ZHQA== X-Google-Smtp-Source: ABhQp+TA2naevyrOOs/Q5qLoRb4CuvjN0m8HSOPgy9PG4UhxDgJnzMS4lLFmoK6Jqv3dEIuSuFwNRg== X-Received: by 10.25.78.141 with SMTP id u13mr3107166lfk.156.1508194413864; Mon, 16 Oct 2017 15:53:33 -0700 (PDT) Received: from localhost (46-133-216-195.dialup.umc.net.ua. [46.133.216.195]) by smtp.gmail.com with ESMTPSA id d204sm1701937lfe.73.2017.10.16.15.53.31 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 16 Oct 2017 15:53:33 -0700 (PDT) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Bryan Drewery" Subject: Re: svn commit: r324673 - head/sys/kern References: <201710162146.v9GLkB6t036842@repo.freebsd.org> <5305175e-e8d2-453d-9ba6-0281af1582a9@FreeBSD.org> Date: Tue, 17 Oct 2017 01:50:54 +0300 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Andriy Voskoboinyk" Message-ID: In-Reply-To: <5305175e-e8d2-453d-9ba6-0281af1582a9@FreeBSD.org> User-Agent: Opera Mail/12.15 (FreeBSD) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 22:53:37 -0000 Tue, 17 Oct 2017 00:53:28 +0300 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Bryan Drewery = : > On 10/16/2017 2:46 PM, Andriy Voskoboinyk wrote: >> Author: avos >> Date: Mon Oct 16 21:46:11 2017 >> New Revision: 324673 >> URL: https://svnweb.freebsd.org/changeset/base/324673 >> >> Log: >> mbuf(9): unbreak m_fragment() > > How was it broken Due to m_cat() usage reason (as described below); this part was not changed since function creation in r119644. > and since when? No idea here - probably, it was partially working until m_cat() improvement in r242256. P.S. Just checked with m_fragment(m, M_NOWAIT, -2) placed right before ieee80211_mbuf_defrag() (from D4077) and various m_len printf's before and after - it defragments frames before this change and works as intended after it. > >> >> - Fix it by replacing m_cat() with m_prev->m_next =3D m_new >> (m_cat() will try to append data - as a result, there will be no >> fragmentation). >> - Move some constants out of the loop. >> >> Was previously tested with D4077. >> >> Differential Revision: https://reviews.freebsd.org/D4090 >