From owner-cvs-all@FreeBSD.ORG Tue Apr 27 21:52:46 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F61C16A4CE; Tue, 27 Apr 2004 21:52:46 -0700 (PDT) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 621BF43D5A; Tue, 27 Apr 2004 21:52:45 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86])i3S4qh4u031246; Wed, 28 Apr 2004 14:52:43 +1000 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i3S4qeI2011814; Wed, 28 Apr 2004 14:52:42 +1000 Date: Wed, 28 Apr 2004 14:52:39 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Ruslan Ermilov In-Reply-To: <20040427192403.GC75827@ip.net.ua> Message-ID: <20040428144757.T4950@gamplex.bde.org> References: <200404271907.i3RJ7ZkI028848@repoman.freebsd.org> <20040427192403.GC75827@ip.net.ua> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Poul-Henning Kamp cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/boot/i386/boot0 Makefile boot0.sboot0_512.s boot0sio.s X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2004 04:52:46 -0000 On Tue, 27 Apr 2004, Ruslan Ermilov wrote: > On Tue, Apr 27, 2004 at 12:07:35PM -0700, Poul-Henning Kamp wrote: > > phk 2004/04/27 12:07:35 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/boot/i386/boot0 Makefile > > Added files: > > sys/boot/i386/boot0 boot0_512.s > > Removed files: > > sys/boot/i386/boot0 boot0.s boot0sio.s > > Log: > > Change from '#' to "//" comment character to allow CPP preprocessing. > > > This is backwards, please fix. Also, the preprocessed files So "# foo" is a valid comment and not a preprocessor directive in *.S provided "foo" is not a standard preprocessor directive? This could be used to back out the mess made by translating the comments in /sys/i386/i386/*.s to C comments. The assembler files in /sys/i386 were also the main ones with the wrong file extension until the boot code regressed. Bruce