From owner-freebsd-stable@FreeBSD.ORG Fri Sep 30 00:56:28 2005 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 352CE16A41F for ; Fri, 30 Sep 2005 00:56:28 +0000 (GMT) (envelope-from smartweb@leadhill.net) Received: from natco3.natcotech.com (natco3.natcotech.com [205.167.142.103]) by mx1.FreeBSD.org (Postfix) with ESMTP id B779843D48 for ; Fri, 30 Sep 2005 00:56:23 +0000 (GMT) (envelope-from smartweb@leadhill.net) Received: from ibm.nlcc.us (ldhl-ras1-dial-12-28-24-103.natcotech.com [12.28.24.103]) by natco3.natcotech.com (Postfix) with ESMTP id 1C04162A2C for ; Thu, 29 Sep 2005 19:56:21 -0500 (CDT) Received: (qmail 45482 invoked by uid 89); 30 Sep 2005 00:56:21 -0000 Received: from unknown (HELO ?192.168.0.2?) (192.168.0.2) by ibm.nlcc.us with SMTP; 30 Sep 2005 00:56:21 -0000 Message-ID: <433C8D34.2090806@leadhill.net> Date: Thu, 29 Sep 2005 19:56:20 -0500 From: Billy Newsom User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Tim Howe , freebsd-stable@freebsd.org References: <87y85nuqhy.fsf@beaker.data-secure.net> <4335D1D2.9060501@leadhill.net> <87ll1jzqoa.fsf@beaker.data-secure.net> <87vf0noxgk.fsf_-_@beaker.data-secure.net> In-Reply-To: <87vf0noxgk.fsf_-_@beaker.data-secure.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: [PATCH] option to re-enable aggressive ATA probing X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2005 00:56:28 -0000 Tim Howe wrote: > Tim Howe writes: > > >>ata0-master: stat=0xd0 err=0xd0 lsb=0xd0 msb=0xd0 > > > This turned out to be the key. > > Version 1.51 of ata-lowlevel.c added a check for stat0/1, err, lsb, and > msb being identical. If they are, it aborts the probe. The attached > patch creates an option ATA_AGGRESSIVE_PROBE which disables this for the > old aggressive behavior (which may wait up to the full 31 seconds). > > I also took the liberty of reworking the still-busy check from 3 > equality tests to 2 bitmask tests. It seems simpler to my eye with > identical results, but if I missed something or the other style was > preferred please let me know. > > The patch is against 5-STABLE because that's what I have. Looks good except for one issue I talk about below. By the way, I don't think this will ever appear back into the RELENG_5 tree unless it gets a PR or at least someone who can check it in. Is there anyone willing to ask the right people? You might look at the initials for whoever changed the code recently and see if you can figure out who that was. Meanwhile, I will try and test it within the week. See below for my question about the patch. Billy --- sys/conf/options.stock Tue Sep 27 00:28:50 2005 +++ sys/conf/options Tue Sep 27 00:55:53 2005 @@ -301,6 +301,7 @@ # Options used in the 'ata' ATA/ATAPI driver ATA_STATIC_ID opt_ata.h ATA_NOPCI opt_ata.h +ATA_AGGRESSIVE_PROBE opt_ata.h DEV_ATADISK opt_ata.h DEV_ATAPICD opt_ata.h DEV_ATAPIST opt_ata.h --- sys/conf/NOTES.stock Tue Sep 27 00:30:28 2005 +++ sys/conf/NOTES Tue Sep 27 00:56:39 2005 @@ -1501,8 +1501,11 @@ # # ATA_STATIC_ID: controller numbering is static ie depends on location # else the device numbers are dynamically allocated. +# ATA_AGGRESSIVE_PROBE: Does not give up on probing when all err, lsb, and + msb are identical. Shouldn't there be a comment for the above line? Like this: +# msb are identical.