From owner-svn-src-head@freebsd.org Tue Sep 24 19:49:29 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EE20012F520; Tue, 24 Sep 2019 19:49:29 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yw1-f66.google.com (mail-yw1-f66.google.com [209.85.161.66]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46dBbX75fxz3Q6B; Tue, 24 Sep 2019 19:49:28 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yw1-f66.google.com with SMTP id n11so1085783ywn.6; Tue, 24 Sep 2019 12:49:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gg7hQjTDHOc3OpoKLf0QPysfe7XkSu4T4fs8+m7dPVI=; b=B2R5NwPKKggYKWglD/Bg06WdfK9ILUFuvZafk3gP1zVO3DPtgjw0qs0KY59jigeS/V XP0VDnCaSnEUoBLRm+DPllwwMyhQ3IoeJ9oKTS5+QmFVHAm905VTjoK+7zcoBVt8abQ7 so4ewJ/wKIF+FIfBbDfumH61NZ+na0hnsII04gCF+EOXf83fnTtQuf2oI0B5FZUcAY7m 3AQCBoWLjvzbIe4l2W3JXhhx1KWvklBvDnAr5XsqnyZ71y9tGb2Pbl7A2gEWKOQ1RXxF l01k94kFAiKhhn2AvYjcXWtz0Upra0zsCjEjN9Mxoqc8R59eCBzHYlwAmSKN42x4/nnQ HiUw== X-Gm-Message-State: APjAAAVf38noUFGeilsD+iJcw25oHEOdR4yv1YA/6kauFKJL8Db65FfK 0PRElFp3DasvRoT0Tcb3Y1Lnh+h2dLh7Ab3ilZsu+0hXhZI= X-Google-Smtp-Source: APXvYqx5pCJoLGfQINYhSKsEYKANXg3214ytWrab8MtpIr4OF4IigMyipavQ4UWj8vQRjCg2ZtqT3j0NsQr6qIrjatk= X-Received: by 2002:a81:5cd4:: with SMTP id q203mr3204782ywb.17.1569354567564; Tue, 24 Sep 2019 12:49:27 -0700 (PDT) MIME-Version: 1.0 References: <201909241818.x8OIIBNr039667@repo.freebsd.org> <20190924212918.01e52920@thor.intern.walstatt.dynvpn.de> In-Reply-To: <20190924212918.01e52920@thor.intern.walstatt.dynvpn.de> From: Li-Wen Hsu Date: Tue, 24 Sep 2019 21:49:15 +0200 Message-ID: Subject: Re: svn commit: r352657 - in head/sys: conf kern modules/tcp modules/tcp/bbr netinet netinet/tcp_stacks sys To: "O. Hartmann" Cc: Randall Stewart , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46dBbX75fxz3Q6B X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of lwhsufreebsd@gmail.com designates 209.85.161.66 as permitted sender) smtp.mailfrom=lwhsufreebsd@gmail.com X-Spamd-Result: default: False [-3.22 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[66.161.85.209.rep.mailspike.net : 127.0.0.18]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[66.161.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.22)[ip: (-0.54), ipnet: 209.85.128.0/17(-3.30), asn: 15169(-2.19), country: US(-0.05)]; FORGED_SENDER(0.30)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Sep 2019 19:49:30 -0000 On Tue, Sep 24, 2019 at 9:29 PM O. Hartmann wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Am Tue, 24 Sep 2019 18:18:11 +0000 (UTC) > Randall Stewart schrieb: > > > Author: rrs > > Date: Tue Sep 24 18:18:11 2019 > > New Revision: 352657 > > URL: https://svnweb.freebsd.org/changeset/base/352657 ... > This break kernel builds: > > [...] > /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:5613:9: error: implicit > declaration of function 'tcp_chg_pacing_rate' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] nrte = tcp_chg_pacing_rate(bbr->r_ctl.crte, ^ > /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:5613:9: error: this function > declaration is not a prototype [-Werror,-Wstrict-prototypes] > /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:5613:7: error: incompatible > integer to pointer conversion assigning to 'const struct tcp_hwrate_limit_table *' from 'int' > [-Werror,-Wint-conversion] nrte = tcp_chg_pacing_rate(bbr->r_ctl.crte, ^ > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- all_subdir_toecore --- Building > /usr/obj/usr/src/amd64.amd64/sys/THOR/modules/usr/src/sys/modules/toecore/toecore.ko --- > all_subdir_tcp --- /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:10443:4: > error: implicit declaration of function 'tcp_rel_pacing_rate' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] tcp_rel_pacing_rate(bbr->r_ctl.crte, bbr->rc_tp); ^ > - --- all_subdir_tpm --- > ===> tpm (all) > - --- all_subdir_tcp --- > /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:10443:4: error: this function > declaration is not a prototype [-Werror,-Wstrict-prototypes] --- all_subdir_trm --- > ===> trm (all) > - --- all_subdir_tcp --- > /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:14307:21: error: implicit > declaration of function 'tcp_set_pacing_rate' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] bbr->r_ctl.crte = tcp_set_pacing_rate(bbr->rc_tp, CI completed a clean build on 12.0-R: https://ci.freebsd.org/job/FreeBSD-head-amd64-build/14672/ What's your build environment and platform? Best, Li-Wen