From owner-freebsd-rc@FreeBSD.ORG  Wed Oct 31 20:08:10 2012
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 578256DE;
 Wed, 31 Oct 2012 20:08:10 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104])
 by mx1.freebsd.org (Postfix) with ESMTP id 20E768FC08;
 Wed, 31 Oct 2012 20:08:08 +0000 (UTC)
Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131])
 by mx1.stack.nl (Postfix) with ESMTP id 52B603592FB;
 Wed, 31 Oct 2012 21:08:07 +0100 (CET)
Received: by snail.stack.nl (Postfix, from userid 1677)
 id 339822848C; Wed, 31 Oct 2012 21:08:07 +0100 (CET)
Date: Wed, 31 Oct 2012 21:08:07 +0100
From: Jilles Tjoelker <jilles@stack.nl>
To: crees@FreeBSD.org
Subject: Re: conf/105145: [ppp] [patch] [request] add redial function to
 rc.d/ppp
Message-ID: <20121031200806.GC24377@stack.nl>
References: <201210311903.q9VJ3wsQ055143@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201210311903.q9VJ3wsQ055143@freefall.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-rc@FreeBSD.org, uspoerlein@gmail.com
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
 <freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Oct 2012 20:08:10 -0000

On Wed, Oct 31, 2012 at 07:03:58PM +0000, crees@FreeBSD.org wrote:
> Synopsis: [ppp] [patch] [request] add redial function to rc.d/ppp

> State-Changed-From-To: open->feedback
> State-Changed-By: crees
> State-Changed-When: Wed Oct 31 19:03:58 UTC 2012
> State-Changed-Why: 
> Hi Ulrich, I think you should commit this in a couple of weeks if no-one
> has objected; I've cleaned it up a bit and made it fit with the rest of
> the file, so please test it first!
> http://www.bayofrum.net/~crees/patches/105145.diff

Not tested here either, modems are many years ago for me.

Style tweaks:

+			_pidmsg=${pidfile:+ (check $pidfile).}

Please make sure the parentheses are quoted, even though our sh does not
require it. For example, _pidmsg="${pidfile:+ (check $pidfile).}"

+		kill -SIGINT $rc_pid

Leave off the SIG prefix. It is more common to omit it and POSIX does
not require implementations to support the prefix.

The patch looks OK otherwise.

-- 
Jilles Tjoelker