Date: Wed, 31 Oct 2012 21:08:07 +0100 From: Jilles Tjoelker <jilles@stack.nl> To: crees@FreeBSD.org Cc: freebsd-rc@FreeBSD.org, uspoerlein@gmail.com Subject: Re: conf/105145: [ppp] [patch] [request] add redial function to rc.d/ppp Message-ID: <20121031200806.GC24377@stack.nl> In-Reply-To: <201210311903.q9VJ3wsQ055143@freefall.freebsd.org> References: <201210311903.q9VJ3wsQ055143@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 31, 2012 at 07:03:58PM +0000, crees@FreeBSD.org wrote: > Synopsis: [ppp] [patch] [request] add redial function to rc.d/ppp > State-Changed-From-To: open->feedback > State-Changed-By: crees > State-Changed-When: Wed Oct 31 19:03:58 UTC 2012 > State-Changed-Why: > Hi Ulrich, I think you should commit this in a couple of weeks if no-one > has objected; I've cleaned it up a bit and made it fit with the rest of > the file, so please test it first! > http://www.bayofrum.net/~crees/patches/105145.diff Not tested here either, modems are many years ago for me. Style tweaks: + _pidmsg=${pidfile:+ (check $pidfile).} Please make sure the parentheses are quoted, even though our sh does not require it. For example, _pidmsg="${pidfile:+ (check $pidfile).}" + kill -SIGINT $rc_pid Leave off the SIG prefix. It is more common to omit it and POSIX does not require implementations to support the prefix. The patch looks OK otherwise. -- Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121031200806.GC24377>