From owner-freebsd-ports  Mon Nov 11 12:48:11 2002
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A96EA37B407
	for <freebsd-ports@FreeBSD.ORG>; Mon, 11 Nov 2002 12:48:10 -0800 (PST)
Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 569AE43E3B
	for <freebsd-ports@FreeBSD.ORG>; Mon, 11 Nov 2002 12:48:10 -0800 (PST)
	(envelope-from davep.freebsd@meduseld.net)
Received: from baloo.meduseld.net ([66.30.120.153]) by rwcrmhc51.attbi.com
          (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP
          id <20021111204809.KNIV24365.rwcrmhc51.attbi.com@baloo.meduseld.net>
          for <freebsd-ports@FreeBSD.ORG>; Mon, 11 Nov 2002 20:48:09 +0000
Received: from localhost (localhost [127.0.0.1])
	by baloo.meduseld.net (8.12.6/8.12.6) with ESMTP id gA7LXpXn057388
	for <freebsd-ports@freebsd.org>; Thu, 7 Nov 2002 16:33:51 -0500 (EST)
	(envelope-from davep.freebsd@meduseld.net)
Date: Thu, 07 Nov 2002 16:33:51 -0500 (EST)
Message-Id: <20021107.163351.846981250.davep@meduseld.net>
To: freebsd-ports@FreeBSD.ORG
Subject: bsd.port.mk, PORTCOMMENT and devel/bison
From: "David A. Panariti" <davep.freebsd@meduseld.net>
X-Attribution: davep
X-Mailer: Mew version 2.2 on XEmacs 21.4.10 (Military Intelligence)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org

While installing the port for devel/bison, I kept getting errors.
It turns out that bison has a PORTCOMMENT value with parens in it
which confuses the shell.
Putting quotes around the ${PORTCOMMENT} being echoed into the
+COMMENT file fixed things.
There may be other cases where vars should be quoted, too.  Sorry, but
I don't have the time to search for them.
I'm not subscribed to this list, so I appreciate being CC'd on any
followup.

davep

here is the patch:

--- bsd.port.mk.ORIG	Thu Nov  7 16:18:39 2002
+++ bsd.port.mk	Thu Nov  7 16:18:48 2002
@@ -3566,7 +3566,7 @@
 		if [ -f ${COMMENT} ]; then \
 			${CP} ${COMMENT} ${PKG_DBDIR}/${PKGNAME}/+COMMENT; \
 		else \
-			${ECHO_CMD} ${PORTCOMMENT} > ${PKG_DBDIR}/${PKGNAME}/+COMMENT; \
+			${ECHO_CMD} "${PORTCOMMENT}" > ${PKG_DBDIR}/${PKGNAME}/+COMMENT; \
 		fi; \
 		if [ -f ${PKGINSTALL} ]; then \
 			${CP} ${PKGINSTALL} ${PKG_DBDIR}/${PKGNAME}/+INSTALL; \

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message