Date: Thu, 30 Apr 1998 19:20:05 -0700 (PDT) From: Jacques Vidrine <n@nectar.com> To: ports Subject: Re: ports/6430: trafshow 2.0 (port) can't be compiled Message-ID: <199805010220.TAA05793@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/6430; it has been noted by GNATS. From: Jacques Vidrine <n@nectar.com> To: ac199@hwcn.org Cc: bug-followup@FreeBSd.ORG Subject: Re: ports/6430: trafshow 2.0 (port) can't be compiled Date: Thu, 30 Apr 1998 21:14:39 -0500 -----BEGIN PGP SIGNED MESSAGE----- Hmm, OK. I'm off to find the style guide for next time. Meanwhile, I see a fix has been committed for the problem, though I think the wrong fix. lib/interfaces.c wouldn't compile because it included <net/if_slvar.h>, which references struct slcompress. The distribution shouldn't have included <net/if_slvar.h>, at least not on BSD4.4lite. That header is only needed for struct sl_softc, which trafshow does not reference. Anyway, the name seems to indicate that it should only be included in kernel sources. The fix that was committed just imported all the stuff struct slcompress needed (<net/if_var.h>, <netinet/mbuf.h>, <net/slcompress.h>), which doesn't seem like the right thing. Thanks, Jacques Vidrine <n@nectar.com> On 30 April 1998 at 21:22, Tim Vanderhoek <ac199@hwcn.org> wrote: > On Thu, 30 Apr 1998, Jacques Vidrine wrote: > > > Fix, to be applied after all other patches included in the port: > > No, there is already one patch to lib/interfaces.c. Any further > patches should be combined with that one (style guide says "two > patches no patch one file"). > > > -- > Only two other people have a .sig like this one. > -----BEGIN PGP SIGNATURE----- Version: 2.6.2 iQCVAwUBNUkwDjeRhT8JRySpAQFdjAQAiHQCJvHIkgzd+FvwvBq9ljqRcB1fQbSX DYi++9weYebT9KdibFoM42auBnAjyURsanoH0Cicfc9yCmGn3WVp/KjPylT8okee ytL5c5Qvms8Z/PsfAPyOUwZohRgoL/rqspfkeqMtdVnEJqwPIg1rUJAoyFSuDett DyosdRZGIJw= =3fnG -----END PGP SIGNATURE----- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199805010220.TAA05793>