From nobody Sun Feb 9 13:47:11 2025 X-Original-To: dev-ci@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YrTXh2VYPz5mRLC for ; Sun, 09 Feb 2025 13:47:16 +0000 (UTC) (envelope-from rea@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.233.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4YrTXf4Th3z3lxF; Sun, 09 Feb 2025 13:47:14 +0000 (UTC) (envelope-from rea@codelabs.ru) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=codelabs.ru header.s=three header.b=wZpZ0sLL; spf=none (mx1.freebsd.org: domain of rea@codelabs.ru has no SPF policy when checking 144.206.233.71) smtp.mailfrom=rea@codelabs.ru; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru ; s=three; h=Sender:In-Reply-To:Content-Type:MIME-Version:Message-ID:Subject: Cc:To:From:Date:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RAZeAzZrmwn0BLgbOxpDWLTghnGIrU7BqctmJfO8a9s=; b=wZpZ0sLLChgPDfFy72Q/CeYBPX BfOTQTSuVkAuPWK18YrJLwh1t3pBD3IotuTw2i3JYhfqtC5tNYDprsy5ZA2BGM+1dG7ILAcvjIHoR zdZMPwmmLZnTbS1yFjNmjAgmokW3wbWg6RokVzAxFDWay1pBPgRT0vhch66KEAOIimAly91m0atXc M54JzdK3Fkmea43HnyD9kN8jznwVUh/yIQu3ErnushM9H+sXm7qho2Z+peSGb6o/jbbkvRIsoIy56 76SIRmEhamBm5aMh4Q2OHSmpqW30rgkQEuEJnZGVt26owhgedIHnGMV585+Gd/a2Gffi2AGUweFag E8IrGD/8x7JLVAuYnBQRJ8lTITZ2AvR+Io/F8+ETkEonP3Dk4ltZez8GlEGRI58QYQ9WuNCK/bUDZ jIXi38VN0NRdnSOC8qDwJvGlBsgxDjebMThSLZfuSi4ttzoHQCHe9DPKeKmHbQHPr+e3aioyOLL7h sE/QCs2KI/lGHz2PqBmfuGK9kQYokBjzq/fMIKZw6sG4ZnCtTTpnYDRURF4z6c+Z3wSuGGiPN8Uki 8b3J9KRPVRTfr5h6np/TUo8vhOGU0DlgwA+LKYLwsxBWEhza1Xyxl3nBiN89PNb18IHoqz5syovYi V2V1ChK3scPay/hOkbKvSq0IwEtdoGqUMdNOgmyZU=; Received: from 109-252-101-185.nat.spd-mgts.ru ([109.252.101.185]:1093 helo=localhost) by mail.codelabs.ru with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (envelope-from ) id 1th7eR-00000000Fem-2tns; Sun, 09 Feb 2025 16:47:11 +0300 Date: Sun, 9 Feb 2025 16:47:11 +0300 From: Eygene Ryabinkin To: jsm@freebsd.org, adrian@freebsd.org Cc: dev-ci@freebsd.org Subject: Re: FreeBSD-main-amd64-gcc13_build - Build #2837 - Still Failing Message-ID: List-Id: Continuous Integration Build and Test Results List-Archive: https://lists.freebsd.org/archives/dev-ci List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-ci@freebsd.org Sender: owner-dev-ci@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="B6JE0n6TpR2fO4cx" Content-Disposition: inline In-Reply-To: <1655522310.793.1739106980888@jenkins.ci.freebsd.org> <761769956.791.1739106205086@jenkins.ci.freebsd.org> C: jenkins-admin@FreeBSD.org Sender: rea@codelabs.ru X-Spamd-Result: default: False [-2.70 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[rea@freebsd.org,rea@codelabs.ru]; ONCE_RECEIVED(0.20)[]; R_DKIM_ALLOW(-0.20)[codelabs.ru:s=three]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-diff]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : No valid SPF, DKIM not aligned (relaxed),none]; FREEFALL_USER(0.00)[rea]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; ASN(0.00)[asn:59624, ipnet:144.206.224.0/19, country:RU]; RCVD_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+,1:+,2:+]; MISSING_XM_UA(0.00)[]; HAS_ATTACHMENT(0.00)[]; R_SPF_NA(0.00)[no SPF record]; FROM_NEQ_ENVFROM(0.00)[rea@freebsd.org,rea@codelabs.ru]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; MLMMJ_DEST(0.00)[dev-ci@freebsd.org]; DKIM_TRACE(0.00)[codelabs.ru:+] X-Spamd-Bar: -- X-Rspamd-Queue-Id: 4YrTXf4Th3z3lxF --B6JE0n6TpR2fO4cx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Gentlemen, good day. Jenkins passed me the following build errors, since I had receintly committed to the HEAD (ports-committers.dot). My commit was unrelated to those build failures, but attached is the patch that fixes the code of mtw_mcu_radio(): it passes wrond 3-rd argument to the mtw_mcu_cmd(). Also checked that other invocations of mtw_mcu_cmd() are fine. jenkins-admin@FreeBSD.org wrote at around Sun, Feb 09, 2025 at 01:03:21PM +0000: > FreeBSD-main-amd64-gcc13_build - Build #2837 (c945a7832f94c6a46375596f298f6140640722cd) - Still Failing > > Build information: https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/ > Full change log: https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/changes > Full build log: https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/console > > Change summaries: > (Those commits are likely but not certainly responsible) > > c945a7832f94c6a46375596f298f6140640722cd by rea: > Ports committers: add myself > > > > The end of the build log: > > [...truncated 126.38 MiB...] [...] > --- all_subdir_usb/mtw --- > In file included from /workspace/src/sys/dev/usb/wlan/if_mtw.c:27: > In function 'mtw_mcu_cmd', > inlined from 'mtw_mcu_radio' at /workspace/src/sys/dev/usb/wlan/if_mtw.c:4387:10, > inlined from 'mtw_init_locked' at /workspace/src/sys/dev/usb/wlan/if_mtw.c:4513:2, > inlined from 'mtw_parent' at /workspace/src/sys/dev/usb/wlan/if_mtw.c:3490:3: > /workspace/src/sys/sys/systm.h:283:33: warning: '__builtin_memcpy' forming offset [4, 15] is out of the bounds [0, 4] of object 'val' with type 'uint32_t' {aka 'unsigned int'} [-Warray-bounds=] > 283 | #define memcpy(to, from, len) __builtin_memcpy((to), (from), (len)) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /workspace/src/sys/dev/usb/wlan/if_mtw.c:1407:9: note: in expansion of macro 'memcpy' > 1407 | memcpy(&sc->txd_fw[sc->sc_idx]->fw, buf, len); > | ^~~~~~ > /workspace/src/sys/dev/usb/wlan/if_mtw.c: In function 'mtw_parent': > /workspace/src/sys/dev/usb/wlan/if_mtw.c:4390:1: note: 'val' declared here > 4390 | mtw_init_locked(struct mtw_softc *sc) > | ^~~~~~~~~~~~~~~ jenkins-admin@FreeBSD.org wrote at around Sun, Feb 09, 2025 at 01:16:17PM +0000: > FreeBSD-main-amd64-gcc12_build - Build #4957 (c945a7832f94c6a46375596f298f6140640722cd) - Still Failing > > Build information: https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/ > Full change log: https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/changes > Full build log: https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/console > > Change summaries: > (Those commits are likely but not certainly responsible) > > c945a7832f94c6a46375596f298f6140640722cd by rea: > Ports committers: add myself > > > > The end of the build log: > > [...truncated 125.71 MiB...] [...] > --- all_subdir_usb/mtw --- > In file included from /workspace/src/sys/dev/usb/wlan/if_mtw.c:27: > In function 'mtw_mcu_cmd', > inlined from 'mtw_mcu_radio' at /workspace/src/sys/dev/usb/wlan/if_mtw.c:4387:10, > inlined from 'mtw_init_locked' at /workspace/src/sys/dev/usb/wlan/if_mtw.c:4513:2, > inlined from 'mtw_parent' at /workspace/src/sys/dev/usb/wlan/if_mtw.c:3490:3: > /workspace/src/sys/sys/systm.h:283:33: warning: '__builtin_memcpy' forming offset [4, 15] is out of the bounds [0, 4] of object 'val' with type 'uint32_t' {aka 'unsigned int'} [-Warray-bounds] > 283 | #define memcpy(to, from, len) __builtin_memcpy((to), (from), (len)) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /workspace/src/sys/dev/usb/wlan/if_mtw.c:1407:9: note: in expansion of macro 'memcpy' > 1407 | memcpy(&sc->txd_fw[sc->sc_idx]->fw, buf, len); > | ^~~~~~ > /workspace/src/sys/dev/usb/wlan/if_mtw.c: In function 'mtw_parent': Please, review and, possibly, commit. Thank you. -- rea --B6JE0n6TpR2fO4cx Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-if_mtw-fix-build.patch" Content-Transfer-Encoding: quoted-printable =46rom 0593d4180ef04f4d720605b25730431ea33d5825 Mon Sep 17 00:00:00 2001 =46rom: Eygene Ryabinkin Date: Sun, 9 Feb 2025 16:40:32 +0300 Subject: [PATCH] if_mtw: fix build mtw_mcu_radio() should use 'cmd', not 'val' for mtw_mcu_cmd(). Signed-off-by: Eygene Ryabinkin --- sys/dev/usb/wlan/if_mtw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/usb/wlan/if_mtw.c b/sys/dev/usb/wlan/if_mtw.c index ecd4693e2361..d7970af5d876 100644 --- a/sys/dev/usb/wlan/if_mtw.c +++ b/sys/dev/usb/wlan/if_mtw.c @@ -4384,7 +4384,7 @@ mtw_mcu_radio(struct mtw_softc *sc, int func, uint32_= t val) cmd.r2 =3D htole32(val); cmd.r3 =3D 0; cmd.r4 =3D 0; - return (mtw_mcu_cmd(sc, 8, &val, sizeof(struct mtw_mcu_cmd_16))); + return (mtw_mcu_cmd(sc, 8, &cmd, sizeof(struct mtw_mcu_cmd_16))); } static void mtw_init_locked(struct mtw_softc *sc) --=20 2.44.0 --B6JE0n6TpR2fO4cx--