From owner-svn-src-all@freebsd.org Mon Jan 14 20:31:30 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 451D61486F23; Mon, 14 Jan 2019 20:31:30 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D394475015; Mon, 14 Jan 2019 20:31:29 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x0EKVQSB036915; Mon, 14 Jan 2019 12:31:27 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x0EKVQSb036914; Mon, 14 Jan 2019 12:31:26 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201901142031.x0EKVQSb036914@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r343011 - in head/kerberos5: lib/libasn1 lib/libgssapi_krb5 lib/libhdb lib/libheimntlm lib/libhx509 lib/libkadm5clnt lib/libkadm5srv lib/libkdc lib/libkrb5 lib/libwind libexec/digest-se... In-Reply-To: <201901142013.x0EKDdsA004741@slippy.cwsent.com> To: Cy Schubert Date: Mon, 14 Jan 2019 12:31:26 -0800 (PST) CC: rgrimes@freebsd.org, Takahashi Yoshihiro , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: D394475015 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.970,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 20:31:30 -0000 > In message <201901141617.x0EGHwqQ035748@pdx.rh.CN85.dnsmgr.net>, > "Rodney W. Gri > mes" writes: > > > Author: nyan > > > Date: Mon Jan 14 06:34:54 2019 > > > New Revision: 343011 > > > URL: https://svnweb.freebsd.org/changeset/base/343011 > > > > > > Log: > > > Use ${SRCTOP}/contrib/com_err/com_err.h instead of the installed com_err. > > h. > > > This fixes build when com_err.h is not installed. > > > > Isn't this the general state of affairs for almost all > > of the source tree? I would rather see this solved > > in a general way, rather than sprinkly all this > > -I${SRCTOP} all over in the tree. > > Agreed however in practice this is fixed when discovered while working > on other issues/problems/projects. This adds another special case that should not exist. > > > > It use to be (and maybe still is) required that you run > > cd $DRCTOP && make includes > > if you expected new source code to compile. I expect > > this has changed, but the just of it should work in > > some aspect. > > This fixes the potential bug of requiring a header file to be > installed. I suspect this to be an oversight at the time. > > Good that it's fixed now. Something is wrong, as infact com_err.h *IS* installed as /usr/include/com_err.h diff /usr/include/com_err.h /usr/src/contrib/com_err/com_err.h -- Rod Grimes rgrimes@freebsd.org