From owner-cvs-all  Tue May  8 14: 1:53 2001
Delivered-To: cvs-all@freebsd.org
Received: from casimir.physics.purdue.edu (casimir.physics.purdue.edu [128.210.146.111])
	by hub.freebsd.org (Postfix) with ESMTP
	id A1BBC37B422; Tue,  8 May 2001 14:01:43 -0700 (PDT)
	(envelope-from will@physics.purdue.edu)
Received: by casimir.physics.purdue.edu (Postfix, from userid 1000)
	id 7727C18726; Tue,  8 May 2001 15:56:38 -0500 (EST)
Date: Tue, 8 May 2001 15:56:38 -0500
From: Will Andrews <will@physics.purdue.edu>
To: Mikhail Teterin <mi@misha.privatelabs.com>
Cc: ports@FreeBSD.org, portmgr@FreeBSD.org
Subject: Re: port policies
Message-ID: <20010508155638.C8870@casimir.physics.purdue.edu>
Reply-To: Will Andrews <will@physics.purdue.edu>
Mail-Followup-To: Will Andrews <will@physics.purdue.edu>,
	Mikhail Teterin <mi@misha.privatelabs.com>, ports@FreeBSD.org,
	portmgr@FreeBSD.org
References: <20010508122714.B48723@FreeBSD.org> <200105082029.f48KTtC38076@misha.privatelabs.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="cWoXeonUoKmBZSoM"
Content-Disposition: inline
User-Agent: Mutt/1.3.15i
In-Reply-To: <200105082029.f48KTtC38076@misha.privatelabs.com>; from mi@misha.privatelabs.com on Tue, May 08, 2001 at 04:29:54PM -0400
X-Operating-System: Linux 2.2.18 sparc64
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


--cWoXeonUoKmBZSoM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

[  moved to ports@  ]

On Tue, May 08, 2001 at 04:29:54PM -0400, Mikhail Teterin wrote:
> The  user did  not ask  for ``-O  -pipe'' in  the CFLAGS  either. -pipe,
> consumes  more  memory, while  -O  makes  compiling longer.  Should  the
> default CFLAGS be empty too? By your logic, they should...

-O -pipe is known to work in many many more cases than -jN, because the
latter is much more dependent on how well people architect their code.

Anyway, there's no chance in hell I'm going to let the default add -jN.
Please stop trying.  Be happy that you can set them in make.conf.

I think the attached patch will do.  portmgr@, any objections to testing
it on bento (seems to work fine here)?

-- 
wca

--cWoXeonUoKmBZSoM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="bsd.port.mk.jobs.diff"

--- bsd.port.mk	Tue Apr 24 13:34:25 2001
+++ bsd.port.mk.new	Tue May  8 15:42:37 2001
@@ -404,6 +404,9 @@
 #				  and install stages (default: see below).
 # MAKE_ARGS		- Any extra arguments to sub-make in build and install
 #				  stages (default: none).
+# MAKE_JOBS		- Specify the -jN option to be added to MAKE_ARGS when
+#				  PARALLEL_SAFE is defined (default: none).
+# PARALLEL_SAFE	- Says that the port is safe to build with ${MAKE} -jN.
 #
 # For install:
 #
@@ -742,6 +745,12 @@
 PLIST_SUB+=	        PORTDOCS="@comment "
 .else
 PLIST_SUB+=	        PORTDOCS=""
+.endif
+
+MAKE_JOBS?=		1
+
+.if defined(PARALLEL_SAFE) && ${MAKE_JOBS} > 1
+MAKE_ARGS+=		-j${MAKE_JOBS}
 .endif
 
 CONFIGURE_ENV+=	PORTOBJFORMAT=${PORTOBJFORMAT}

--cWoXeonUoKmBZSoM--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message