From owner-dev-commits-ports-main@freebsd.org Sat Jul 17 08:28:26 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E1E6565008D; Sat, 17 Jul 2021 08:28:26 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GRh8B67lTz4mrv; Sat, 17 Jul 2021 08:28:26 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from marvin.madpilot.net (host-87-19-3-78.retail.telecomitalia.it [87.19.3.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 31D1B7054; Sat, 17 Jul 2021 08:28:26 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Subject: Re: git: dc9bf7d64926 - main - net/asterisk*: Add aarch64 support To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202107141033.16EAX60T044972@gitrepo.freebsd.org> <81bc6b76-7b74-9990-d7dc-54ca14b0ee4f@FreeBSD.org> From: Guido Falsi Message-ID: Date: Sat, 17 Jul 2021 10:28:24 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jul 2021 08:28:27 -0000 On 15/07/21 18:59, Alexey Dokuchaev wrote: > On Thu, Jul 15, 2021 at 04:38:53PM +0200, Guido Falsi wrote: >> On 15/07/21 04:06, Alexey Dokuchaev wrote: >>> ... >>> I think ONLY_FOR_ARCHS here clearly outlived its purpose and can just >>> be removed. It arguably misses MIPS, but we aren't promising much for >>> that tier anyways, and this harness just gets in the way of those who >>> know that they're doing. After all, there shouldn't be anything >>> inherently architecture-specific about the telephony toolkit, but even >>> if there is, individual BROKEN_$arch would be more appropriate. >> >> The fact that mips is not included is exactly the reason I did not >> remove ONLY_FOR_ARCHS. >> >> If what you say is the general consensus I'll be quite happy to get rid >> of it. > > You'd likely not get general consensus as most people don't care. :-) Maybe I did not choose my words wisely. More than consensus I was looking for a "no objection" consensus. > >> I guess this compiler mix situation is not an issue anymore. > > Right. I think it's generally bad idea to prematurely restrict software > to certain arches unless it's clearly arch-specific (e.g. comes only in > binary precompiled form or uses asm code). New arches appear frequently > (e.g. powerpc64le, riscv64) and some go away as well (ia64, sparc64), it > just does not look feasible to maintain those ONLY_FOR_ARCHS lists so > they'd always reflect the reality. > > Even if one's port does break on MIPS, one should get a notice from the > build cluster and either fix it, or mark is as BROKEN_$arch, rather than > keep ONLY_FOR_ARCHS which would only get amended, causing needless repo > churn, upon every next time someone discovers that it builds and works > on their architecture of interest. > I fundamentally agree with what you say so I've followed your suggestion and removed the restriction. -- Guido Falsi