Date: Mon, 29 Oct 2012 02:39:47 +0100 From: Kai Wang <kaiwang27@gmail.com> To: Chris Rees <crees@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, Guido Falsi <madpilot@FreeBSD.org>, ports-committers@FreeBSD.org Subject: Re: svn commit: r306286 - in head/sysutils/uhidd: . files Message-ID: <20121029013947.GA38831@viskning> In-Reply-To: <CADLo838WrY0Tz-r1xf_PE0p5dYiyZGO0kZnJM_tqWPWGwpABVQ@mail.gmail.com> References: <201210222013.q9MKDbWx096398@svn.freebsd.org> <CADLo838WrY0Tz-r1xf_PE0p5dYiyZGO0kZnJM_tqWPWGwpABVQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 28, 2012 at 12:17:22PM +0000, Chris Rees wrote: > On 22 October 2012 21:13, Guido Falsi <madpilot@freebsd.org> wrote: > > XXX Ports RC script present > > XXX Ports RC script present > > Author: madpilot > > Date: Mon Oct 22 20:13:36 2012 > > New Revision: 306286 > > URL: http://svn.freebsd.org/changeset/ports/306286 > > > > Log: > > - Update to 0.2.1 > > <snip> > > > Modified: head/sysutils/uhidd/files/uhidd.in > > ============================================================================== > > --- head/sysutils/uhidd/files/uhidd.in Mon Oct 22 20:06:34 2012 (r306285) > > +++ head/sysutils/uhidd/files/uhidd.in Mon Oct 22 20:13:36 2012 (r306286) > > @@ -19,7 +19,7 @@ name="uhidd" > > rcvar=uhidd_enable > > command="%%PREFIX%%/sbin/${name}" > > start_cmd="uhidd_start" > > -required_modules="uvhid vkbd" > > +required_modules="vkbd" > > pidprefix="/var/run/uhidd" > > > > load_rc_config $name > > > > I remember when I fixed the ${name}_enable default missing case here, > and looking again I had missed out a colon :) > > This patch fixes that, and contains other style fixes, but most > importantly it replaces a use of [ with a much faster variable > substitution. > > http://www.bayofrum.net/~crees/patches/uhidd-rc.diff > > Kai Wang, is it OK? Patch looks good to me. Please commit. Thanks, Kai
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121029013947.GA38831>