From owner-svn-ports-all@FreeBSD.ORG Mon Oct 29 01:39:52 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4ABFB5CE; Mon, 29 Oct 2012 01:39:52 +0000 (UTC) (envelope-from kaiwang27@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id E01F88FC16; Mon, 29 Oct 2012 01:39:50 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id b5so3477821lbd.13 for ; Sun, 28 Oct 2012 18:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-authentication-warning:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=tQKcs1HjyXHLBEcnG4lrHq3vShb2reGu1RbyuK6Xqjc=; b=ZoPi1zYiCzQjK20YomEEdVxHJiHKiXIB21scLPecMyWGVomDav6LRX8S55l85qBBza XN6NKz4KqjYeJko+b/aNGsG8G0LdK+ZGOGutSj/HlFTwrc5yDy+92jTbUJv+y6ZiC72X v2Wqhy0Qm2dboW1zJn5pyI7W40BWIfC1/PaSCsYx1IOG9wyEp/KrKIjfhPsoW482Is4h 8qiT9GnLcyhXFNzNuuF6VJCRA5pD3RZLkApUauKzvEzdDgomTphiZYTmOzOHbTMlX0gu 0PZx/bwbT3E7ZXrXVEZkcKz3HIUqZdCvnIqqJXrXF0G9s6KL3CjTwXR9/G8Suq/Xneja LHTw== Received: by 10.112.39.233 with SMTP id s9mr11329809lbk.71.1351474789460; Sun, 28 Oct 2012 18:39:49 -0700 (PDT) Received: from localhost (s83-179-26-84.cust.tele2.se. [83.179.26.84]) by mx.google.com with ESMTPS id jk8sm2556446lab.7.2012.10.28.18.39.48 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 28 Oct 2012 18:39:48 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=localhost.my.domain) by localhost with esmtp (Exim 4.80 (FreeBSD)) (envelope-from ) id 1TSeKR-000F9l-KU; Mon, 29 Oct 2012 02:39:47 +0100 Received: (from kaiw@localhost) by localhost.my.domain (8.14.5/8.14.5/Submit) id q9T1dlBi058264; Mon, 29 Oct 2012 02:39:47 +0100 (CET) (envelope-from kaiwang27@gmail.com) X-Authentication-Warning: localhost.my.domain: kaiw set sender to kaiwang27@gmail.com using -f Date: Mon, 29 Oct 2012 02:39:47 +0100 From: Kai Wang To: Chris Rees Subject: Re: svn commit: r306286 - in head/sysutils/uhidd: . files Message-ID: <20121029013947.GA38831@viskning> References: <201210222013.q9MKDbWx096398@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, Guido Falsi , ports-committers@FreeBSD.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2012 01:39:52 -0000 On Sun, Oct 28, 2012 at 12:17:22PM +0000, Chris Rees wrote: > On 22 October 2012 21:13, Guido Falsi wrote: > > XXX Ports RC script present > > XXX Ports RC script present > > Author: madpilot > > Date: Mon Oct 22 20:13:36 2012 > > New Revision: 306286 > > URL: http://svn.freebsd.org/changeset/ports/306286 > > > > Log: > > - Update to 0.2.1 > > > > > Modified: head/sysutils/uhidd/files/uhidd.in > > ============================================================================== > > --- head/sysutils/uhidd/files/uhidd.in Mon Oct 22 20:06:34 2012 (r306285) > > +++ head/sysutils/uhidd/files/uhidd.in Mon Oct 22 20:13:36 2012 (r306286) > > @@ -19,7 +19,7 @@ name="uhidd" > > rcvar=uhidd_enable > > command="%%PREFIX%%/sbin/${name}" > > start_cmd="uhidd_start" > > -required_modules="uvhid vkbd" > > +required_modules="vkbd" > > pidprefix="/var/run/uhidd" > > > > load_rc_config $name > > > > I remember when I fixed the ${name}_enable default missing case here, > and looking again I had missed out a colon :) > > This patch fixes that, and contains other style fixes, but most > importantly it replaces a use of [ with a much faster variable > substitution. > > http://www.bayofrum.net/~crees/patches/uhidd-rc.diff > > Kai Wang, is it OK? Patch looks good to me. Please commit. Thanks, Kai