Date: Sat, 15 Apr 2017 18:36:15 -0600 From: Ian Lepore <ian@freebsd.org> To: "Sergey A. Osokin" <osa@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r438592 - in head/www/nginx-devel: . files Message-ID: <1492302975.62945.25.camel@freebsd.org> In-Reply-To: <20170416001854.GN85682@FreeBSD.org> References: <201704151739.v3FHdat1041522@repo.freebsd.org> <626f1beb-0006-f9a8-82c2-5d8d03fb4b53@FreeBSD.org> <1492285633.62945.15.camel@freebsd.org> <20170415214049.GM85682@FreeBSD.org> <1492295503.62945.22.camel@freebsd.org> <20170416001854.GN85682@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2017-04-16 at 00:18 +0000, Sergey A. Osokin wrote: > On Sat, Apr 15, 2017 at 04:31:43PM -0600, Ian Lepore wrote: > > > > On Sat, 2017-04-15 at 21:40 +0000, Sergey A. Osokin wrote: > > > > > > On Sat, Apr 15, 2017 at 01:47:13PM -0600, Ian Lepore wrote: > > > > > > > > > > > > On Sat, 2017-04-15 at 21:32 +0200, Mathieu Arnold wrote: > > > > > > > > > > > > > > > Le 15/04/2017 ? 19:39, Sergey A. Osokin a ?crit : > > > > > > > > > > > > > > > > > > > > > > > > Author: osa > > > > > > Date: Sat Apr 15 17:39:35 2017 > > > > > > New Revision: 438592 > > > > > > URL: https://svnweb.freebsd.org/changeset/ports/438592 > > > > > > > > > > > > Log: > > > > > > Remove IPV6 knob, IPv6 now compiled-in automatically if > > > > > > support > > > > > > is found. > > > > > > > > > > > Does this mean that if I build the package on a host without > > > > > IPv6, it > > > > > gets disabled and I don't get IPv6 support where I install > > > > > the > > > > > package ? > > > > Even worse, if I build the package on a system with IPV6 > > > > enabled I > > > > will > > > > be unable to build the package with it disabled, > > > Not true, It's possible to build an nginx package without IPv6 on > > > a > > > system > > > with IPv6 enabled, please see http://hg.nginx.org/nginx/rev/a6d11 > > > 6645 > > > c51 > > > for details. > > But you removed the IPV6 knob rather than adapting it to the new > > way > > upstream provides for en/disabling it. How does that enable me to > > build without ipv6 support? > No problem: > > .if ${.CURDIR:M*/www/nginx-devel} > CONFIGURE_ARGS+="--with-cc-opt=\"-DNGX_HAVE_INET6=0\"" > .endif > > Not tested yet. > 151 ports currently define "IPV6" as the option for controlling ipv6 support. There is, of course, no simple way to count how many control it using some other mechanism, but I guess whatever that number was, it's now +1. -- Ian > > > > I should note for the record that my concern here is theoretical... > > at > > $work we ship products without ipv6 support enabled and (cross- > > )build > > the packages on a machine that does have it enabled, but nginx is > > not > > one of the packages, so this isn't impacting me directly. But if I > > have such a need to create packages that don't match the build > > machine's setup, it's reasonable to assume I'm not the only one.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1492302975.62945.25.camel>