From owner-freebsd-office@FreeBSD.ORG Wed Aug 1 02:53:59 2012 Return-Path: Delivered-To: freebsd-office@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 09CAF106564A; Wed, 1 Aug 2012 02:53:59 +0000 (UTC) (envelope-from maho.nakata@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id C65B98FC0C; Wed, 1 Aug 2012 02:53:58 +0000 (UTC) Received: by pbbro2 with SMTP id ro2so317304pbb.13 for ; Tue, 31 Jul 2012 19:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:message-id:to:cc:subject:from:in-reply-to:references :x-mailer:mime-version:content-type:content-transfer-encoding; bh=Nv49KdRHtAGHtfHVOwGxKABPu/sdsv21hIhdQMeVCKE=; b=FCuoPvVCS985qrTT9s/J/EXNFdpXiQmQqAHzajBpK+bVLAsRBEUg8HNH87Io9i3sg+ 7pKI1V/Y9nwSq1JuTl9YHZ6Xa9NGNRk+f6QEKLiReWLcVSebVuSAdqTMvR4OEdNwz6m4 I9ZEo/xBKdp1KMVwBXua/7W0ap0ZSQTisvV7L52spM4AGuL/dJ0n0qjkQT7uI+EAM409 fzFgI1AR4qE9klSEY49Rk43Nza8sQzwH0+o97822JVIBjAEbgCZXG13M+GVmP8KKDUIn y8PbBWsaD20aXMmaRr2SRdZLgg4t3H6ar/bvQnYlP+/8AsJDNYdw5lpX++waC6K+OkU3 +lHg== Received: by 10.66.81.106 with SMTP id z10mr36546117pax.26.1343789638359; Tue, 31 Jul 2012 19:53:58 -0700 (PDT) Received: from localhost (rikad42.riken.jp. [134.160.214.42]) by mx.google.com with ESMTPS id ro13sm1526086pbb.54.2012.07.31.19.53.56 (version=SSLv3 cipher=OTHER); Tue, 31 Jul 2012 19:53:57 -0700 (PDT) Sender: Maho NAKATA Date: Wed, 01 Aug 2012 11:53:55 +0900 (JST) Message-Id: <20120801.115355.1650049304883897073.chat95@mac.com> To: me@janh.de From: Maho NAKATA In-Reply-To: <5013248A.2050003@janh.de> References: <20120727.115721.1764309951853442978.chat95@mac.com> <20120727230043.GB48384@ithaqua.etoilebsd.net> <5013248A.2050003@janh.de> X-Mailer: Mew version 6.3 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: bapt@FreeBSD.org, freebsd-office@FreeBSD.org Subject: Re: editors/openoffice-3 build failure (lingucomponent) and fix X-BeenThere: freebsd-office@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Office applications on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2012 02:53:59 -0000 Hi Jan, Following patch is working at least in my tinderbox with minor modification. I'll test more complex cases... > .if exists(${LOCALBASE}/include/libexttextcat/textcat.h) > .if exists(${LOCALBASE}/include/textcat.h) > LIB_DEPENDS+= exttextcat-1.0.0:${PORTSDIR}/textproc/libexttextcat > EXTRA_PATCHES+= ${FILESDIR}/extra-patch-libexttextcat-lingucomponent > .else > IGNORE= textproc/libexttextcat needs COMPAT_TEXTCAT enabled > .fi > .else > LIB_DEPENDS+= textcat.0:${PORTSDIR}/textproc/libtextcat > .fi > From: Jan Henrik Sylvester Subject: Re: editors/openoffice-3 build failure (lingucomponent) and fix Date: Sat, 28 Jul 2012 01:30:18 +0200 > On 07/28/2012 01:00, Baptiste Daroussin wrote: >> On Fri, Jul 27, 2012 at 11:57:21AM +0900, Maho NAKATA wrote: >>> Sorry to say, but I cannot reproduce your error. >>> My testbuild was finished succesfully (in my tinder box) >>> on 9.0-RELEASE/amd64. >> >> I do think he should be using libexttextcat with libtextcat >> compatibility >> option. >> >> This change is one of the changes that happended in libexttextcat > > Yes, I do. > > Thank you, Bapt! I was thinking about changing everything non-standard > on my system one-by-one to try to find the reason, but I was still > hesitant because of the work involved. Now you saved me of trying > that. > > I would like to have both libreoffice and openoffice at the same time > and fortunately, using libexttextcat with libtextcat compatibility is > currently the only necessity... and that patch. > > Does the patch hurt those with standard libtextcat? > > If not, would you include it, although it does not fix the > clean/tinderbox case? > > Or better: Would you accept a patch for the openoffice port that > detects if libexttextcat with libtextcat compatibility is installed > instead of libtextcat, properly depend on it in that case, and include > the patch? > > I am thinking of something along this lines (untested): > > .if exists(${LOCALBASE}/include/libexttextcat/textcat.h) > .if exists(${LOCALBASE}/include/textcat.h) > LIB_DEPENDS+= exttextcat-1.0.0:${PORTSDIR}/textproc/libexttextcat > EXTRA_PATCHES+= ${FILESDIR}/extra-patch-libexttextcat-lingucomponent > .else > IGNORE= textproc/libexttextcat needs COMPAT_TEXTCAT enabled > .fi > .else > LIB_DEPENDS+= textcat.0:${PORTSDIR}/textproc/libtextcat > .fi > > Cheers, > Jan Henrik >