From owner-freebsd-ports  Sat Nov 29 07:40:04 1997
Return-Path: <owner-freebsd-ports>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id HAA05925
          for ports-outgoing; Sat, 29 Nov 1997 07:40:04 -0800 (PST)
          (envelope-from owner-freebsd-ports)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id HAA05910;
          Sat, 29 Nov 1997 07:40:02 -0800 (PST)
          (envelope-from gnats)
Resent-Date: Sat, 29 Nov 1997 07:40:02 -0800 (PST)
Resent-Message-Id: <199711291540.HAA05910@hub.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-ports
Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG,
        Yen-Shuo Su <yssu@CCCA.NCTU.edu.tw>
Received: from NetoSpace.neto.net (NetoSpace.neto.net [203.67.80.129])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id HAA05500
          for <FreeBSD-gnats-submit@freebsd.org>; Sat, 29 Nov 1997 07:33:30 -0800 (PST)
          (envelope-from shuo@NetoSpace.neto.net)
Received: (from shuo@localhost)
	by NetoSpace.neto.net (8.8.7/8.8.5) id XAA11625;
	Sat, 29 Nov 1997 23:37:31 +0800 (CST)
Message-Id: <199711291537.XAA11625@NetoSpace.neto.net>
Date: Sat, 29 Nov 1997 23:37:31 +0800 (CST)
From: Yen-Shuo Su <yssu@CCCA.NCTU.edu.tw>
Reply-To: Yen-Shuo Su <yssu@CCCA.NCTU.edu.tw>
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: ports/5177: Error in a script of ports/databases/msql
Sender: owner-freebsd-ports@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         5177
>Category:       ports
>Synopsis:       Not enought argument in script of databases/msql
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 29 07:40:01 PST 1997
>Last-Modified:
>Originator:     Yen-Shuo Su
>Organization:
Campus Computer Comminication Association, NCTU
>Release:        FreeBSD 2.2-970829-RELENG i386
>Environment:

	FreeBSD 2.2-970829-RELENG i386
	Perl version 5.004_01

>Description:

	The closedir() on line 10 in check_old_version script of
	ports/databases/msql isnt given enough argument.

>How-To-Repeat:

/usr/bin/perl -cw /usr/ports/databases/msql/scripts/check_old_version:

Not enough arguments for closedir at
/usr/ports/databases/msql/scripts/check_old_version line 10, near "closedir;"
/usr/ports/databases/msql/scripts/check_old_version had compilation errors.

>Fix:

Patch:
	
--- scripts/check_old_version.orig      Sat Nov 29 23:29:11 1997
+++ scripts/check_old_version   Sat Nov 29 23:29:23 1997
@@ -7,7 +7,7 @@
        chdir( "/var/db/pkg" );
        opendir( DIR, "." );
        @oldmsql = grep( /^msql-2.0b[1234]$/, readdir( DIR ) );
-       closedir;
+       closedir(DIR);
        if( @oldmsql ) {
                if( ! $ENV{OVERWRITE_DB} ) {
                        print <<END;
>Audit-Trail:
>Unformatted: