From owner-freebsd-bugs@FreeBSD.ORG Sun Feb 9 23:31:32 2014 Return-Path: <owner-freebsd-bugs@FreeBSD.ORG> Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 425C5391 for <freebsd-bugs@freebsd.org>; Sun, 9 Feb 2014 23:31:32 +0000 (UTC) Received: from mail-vc0-x233.google.com (mail-vc0-x233.google.com [IPv6:2607:f8b0:400c:c03::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id EA0211379 for <freebsd-bugs@freebsd.org>; Sun, 9 Feb 2014 23:31:31 +0000 (UTC) Received: by mail-vc0-f179.google.com with SMTP id lh14so4189883vcb.24 for <freebsd-bugs@freebsd.org>; Sun, 09 Feb 2014 15:31:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=wMDNPI5Ezd44+AIKEZWGr6d16r524ksjCGiAw7q8Ddo=; b=jTB6tdvO6LziUuZbmNxU8eVGq6b7oM1fvH5CFw0svX5ufK7wZw4ZbB2N1dRLIdUqy4 TZFxQJKYBrkwiYmdKayEyxCqjjEWak/7DI30FFCdbo9Q2Kp0ZT76NYvNVvrgPsDwDDw/ NFxqAmqhhqrgLBTNmQ9Hul1hWy92xYMhM4HU8rDiF5c7NjhfCv4c4YiJU0eb5F7DpFa1 icUXttW66aDcaSBM9bGOndGq/kWzIjeHstytfbzrVd/gKaeW8midAhqcQNgVM6dFk6Wm nAzH/Wvg/bYjhdo8P05VInmviYnzyprfP7Y7LI2YwJirOXuH6cbaTWCxqwfSxuJ/PLuK Hbyw== MIME-Version: 1.0 X-Received: by 10.58.204.4 with SMTP id ku4mr97151vec.34.1391988690923; Sun, 09 Feb 2014 15:31:30 -0800 (PST) Received: by 10.58.37.135 with HTTP; Sun, 9 Feb 2014 15:31:30 -0800 (PST) In-Reply-To: <CADt0fhxWeqkkjVrOG5B2gEN_3kfharkJXudEovVbj54+eBOckA@mail.gmail.com> References: <201402042000.s14K01eo021855@freefall.freebsd.org> <CA+q+TcpvW3c9c+4XJA1MLaMyi5xOSLtjqA5nkPJncGJ+JhY2KA@mail.gmail.com> <CADt0fhxWeqkkjVrOG5B2gEN_3kfharkJXudEovVbj54+eBOckA@mail.gmail.com> Date: Sun, 9 Feb 2014 18:31:30 -0500 Message-ID: <CADt0fhxP1m4GocFh=hCawjSym0Gxw2DpwSsjbqUd4H_UkqZ4JA@mail.gmail.com> Subject: Re: kern/181497: [kernel] [patch] Add ASLR feature to kernel From: Shawn Webb <lattera@gmail.com> To: =?ISO-8859-1?Q?Olivier_Cochard=2DLabb=E9?= <olivier@cochard.me> Content-Type: multipart/mixed; boundary=047d7bf15fde744b4b04f2019fcf X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: freebsd-bugs@freebsd.org X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Bug reports <freebsd-bugs.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>, <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/> List-Post: <mailto:freebsd-bugs@freebsd.org> List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>, <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sun, 09 Feb 2014 23:31:32 -0000 --047d7bf15fde744b4b04f2019fcf Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sorry for the delay. The attached patch should apply cleanly on top of the existing patch and should fix Olivier's problems. On Wed, Feb 5, 2014 at 8:54 AM, Shawn Webb <lattera@gmail.com> wrote: > Looks like that variable is missing in that struct. The exec delta > variable changes how the binary itself and the RTLD is loaded. I'll fix t= he > warnings and errors you reported today. Thanks for helping! > > > On Wed, Feb 5, 2014 at 3:56 AM, Olivier Cochard-Labb=E9 <olivier@cochard.= me>wrote: > >> On Tue, Feb 4, 2014 at 9:00 PM, Shawn Webb <lattera@gmail.com> wrote: >> >>> The following reply was made to PR kern/181497; it has been noted by >>> GNATS. >>> >>> From: Shawn Webb <lattera@gmail.com> >>> To: bug-followup@FreeBSD.org, >>> steven@roothosts.com >>> >>> Cc: >>> Subject: Re: kern/181497: [kernel] [patch] Add ASLR feature to kernel >>> Date: Tue, 4 Feb 2014 14:57:44 -0500 >>> >>> --Apple-Mail=3D_70D08D01-527F-4575-806A-36757E957E5A >>> Content-Transfer-Encoding: quoted-printable >>> Content-Type: text/plain; >>> charset=3Dus-ascii >>> >>> I'm sorry, my patch actually wasn't right. It included other fixes I >>> had =3D >>> in my branch for other features and didn't include some of the other = =3D >>> ASLR bits. Attached is the right patch. >>> >>> >> kernel compilation failed if configuration is "with PAX_ASLR options" an= d >> "without COMPAT_FREEBSD32 options": >> >> --- kern_pax.o --- >> /src/sys/kern/kern_pax.c:531:9: error: no member named >> 'vm_aslr_delta_exec' in 'struct vmspace' >> >> vm->vm_aslr_delta_exec =3D round_page(PAX_ASLR_DELTA(arc4random(), >> PAX_ASLR_DELTA_EXEC_LSB, (pr !=3D NULL) ? pr->pr_pax_aslr_exec_len : >> pax_aslr_exec_len)); >> ~~ ^ >> 1 error generated. >> >> What's is this "vm_aslr_delta_exec" ? >> > > --047d7bf15fde744b4b04f2019fcf Content-Type: text/plain; charset=US-ASCII; name="aslr-2014-02-09.patch.txt" Content-Disposition: attachment; filename="aslr-2014-02-09.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hrgy4d3m0 ZGlmZiAtLWdpdCBhL3N5cy9rZXJuL2ltZ2FjdF9lbGYuYyBiL3N5cy9rZXJuL2ltZ2FjdF9lbGYu YwppbmRleCAzZjk0ODdjLi4zYTM2ZjIwIDEwMDY0NAotLS0gYS9zeXMva2Vybi9pbWdhY3RfZWxm LmMKKysrIGIvc3lzL2tlcm4vaW1nYWN0X2VsZi5jCkBAIC02MDMsNyArNjAzLDkgQEAgX19lbGZO KGxvYWRfZmlsZSkoc3RydWN0IHByb2MgKnAsIGNvbnN0IGNoYXIgKmZpbGUsIHVfbG9uZyAqYWRk ciwKIAl1X2xvbmcgcmJhc2U7CiAJdV9sb25nIGJhc2VfYWRkciA9IDA7CiAJaW50IGVycm9yLCBp LCBudW1zZWdzOwotICAgIHN0cnVjdCBwcmlzb24gKnByOyAvKiBGb3IgQVNMUiAqLworI2lmZGVm IFBBWF9BU0xSCisgICAgc3RydWN0IHByaXNvbiAqcHI7CisjZW5kaWYKIAogI2lmZGVmIENBUEFC SUxJVFlfTU9ERQogCS8qCkBAIC02NTksMjIgKzY2MSwyMSBAQCBfX2VsZk4obG9hZF9maWxlKShz dHJ1Y3QgcHJvYyAqcCwgY29uc3QgY2hhciAqZmlsZSwgdV9sb25nICphZGRyLAogCWhkciA9IChj b25zdCBFbGZfRWhkciAqKWltZ3AtPmltYWdlX2hlYWRlcjsKIAlpZiAoKGVycm9yID0gX19lbGZO KGNoZWNrX2hlYWRlcikoaGRyKSkgIT0gMCkKIAkJZ290byBmYWlsOwotCWlmIChoZHItPmVfdHlw ZSA9PSBFVF9EWU4pCisJaWYgKGhkci0+ZV90eXBlID09IEVUX0RZTikgewogCQlyYmFzZSA9ICph ZGRyOwotCWVsc2UgaWYgKGhkci0+ZV90eXBlID09IEVUX0VYRUMpCisjaWZkZWYgUEFYX0FTTFIK KyAgICAgICAgcHIgPSBwYXhfYXNscl9nZXRfcHJpc29uKE5VTEwsIGltZ3AtPnByb2MpOworICAg ICAgICBpZiAocGF4X2FzbHJfYWN0aXZlKE5VTEwsIGltZ3AtPnByb2MpKSB7CisgICAgICAgICAg ICByYmFzZSArPSByb3VuZF9wYWdlKFBBWF9BU0xSX0RFTFRBKGFyYzRyYW5kb20oKSwgUEFYX0FT TFJfREVMVEFfRVhFQ19MU0IsIHByLT5wcl9wYXhfYXNscl9leGVjX2xlbikpOworICAgICAgICB9 CisjZW5kaWYKKyAgICB9IGVsc2UgaWYgKGhkci0+ZV90eXBlID09IEVUX0VYRUMpIHsKIAkJcmJh c2UgPSAwOwotCWVsc2UgeworICAgIH0gZWxzZSB7CiAJCWVycm9yID0gRU5PRVhFQzsKIAkJZ290 byBmYWlsOwogCX0KIAotI2lmZGVmIFBBWF9BU0xSCi0gICAgcHIgPSBwYXhfYXNscl9nZXRfcHJp c29uKE5VTEwsIGltZ3AtPnByb2MpOwotICAgIGlmIChwYXhfYXNscl9hY3RpdmUoTlVMTCwgaW1n cC0+cHJvYykpIHsKLSAgICAgICAgcmJhc2UgKz0gcm91bmRfcGFnZShQQVhfQVNMUl9ERUxUQShh cmM0cmFuZG9tKCksIFBBWF9BU0xSX0RFTFRBX0VYRUNfTFNCLCBwci0+cHJfcGF4X2FzbHJfZXhl Y19sZW4pKTsKLSAgICB9Ci0jZW5kaWYKLQogCS8qIE9ubHkgc3VwcG9ydCBoZWFkZXJzIHRoYXQg Zml0IHdpdGhpbiBmaXJzdCBwYWdlIGZvciBub3cgICAgICAqLwogCWlmICgoaGRyLT5lX3Bob2Zm ID4gUEFHRV9TSVpFKSB8fAogCSAgICAodV9pbnQpaGRyLT5lX3BoZW50c2l6ZSAqIGhkci0+ZV9w aG51bSA+IFBBR0VfU0laRSAtIGhkci0+ZV9waG9mZikgewpkaWZmIC0tZ2l0IGEvc3lzL2tlcm4v a2Vybl9wYXguYyBiL3N5cy9rZXJuL2tlcm5fcGF4LmMKaW5kZXggOTE4MjYwNi4uNzY1NGU1YiAx MDA2NDQKLS0tIGEvc3lzL2tlcm4va2Vybl9wYXguYworKysgYi9zeXMva2Vybi9rZXJuX3BheC5j CkBAIC01MjgsNyArNTI4LDYgQEAgcGF4X2FzbHJfaW5pdChzdHJ1Y3QgdGhyZWFkICp0ZCwgc3Ry dWN0IGltYWdlX3BhcmFtcyAqaW1ncCkKICAgICB2bS0+dm1fYXNscl9kZWx0YV9zdGFjayA9IFBB WF9BU0xSX0RFTFRBKGFyYzRyYW5kb20oKSwKICAgICAgICAgUEFYX0FTTFJfREVMVEFfU1RBQ0tf TFNCLCAocHIgIT0gTlVMTCkgPyBwci0+cHJfcGF4X2FzbHJfc3RhY2tfbGVuIDogcGF4X2FzbHJf c3RhY2tfbGVuKTsKICAgICB2bS0+dm1fYXNscl9kZWx0YV9zdGFjayA9IEFMSUdOKHZtLT52bV9h c2xyX2RlbHRhX3N0YWNrKTsKLSAgICB2bS0+dm1fYXNscl9kZWx0YV9leGVjID0gcm91bmRfcGFn ZShQQVhfQVNMUl9ERUxUQShhcmM0cmFuZG9tKCksIFBBWF9BU0xSX0RFTFRBX0VYRUNfTFNCLCAo cHIgIT0gTlVMTCkgPyBwci0+cHJfcGF4X2FzbHJfZXhlY19sZW4gOiBwYXhfYXNscl9leGVjX2xl bikpOwogI2Vsc2UgLyogQ09NUEFUX0ZSRUVCU0QzMiAqLwogICAgIGlmICgoc3ZfZmxhZ3MgJiBT Vl9MUDY0KSAhPSAwKSB7CiAgICAgICAgIHZtLT52bV9hc2xyX2RlbHRhX21tYXAgPSBQQVhfQVNM Ul9ERUxUQShhcmM0cmFuZG9tKCksCg== --047d7bf15fde744b4b04f2019fcf--