From owner-freebsd-java@FreeBSD.ORG  Mon Jun 11 16:18:38 2012
Return-Path: <owner-freebsd-java@FreeBSD.ORG>
Delivered-To: freebsd-java@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 19FD7106567B
	for <freebsd-java@FreeBSD.org>; Mon, 11 Jun 2012 16:18:38 +0000 (UTC)
	(envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 4EC418FC19
	for <freebsd-java@FreeBSD.org>; Mon, 11 Jun 2012 16:18:37 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA00190
	for <freebsd-java@freebsd.org>; Mon, 11 Jun 2012 19:18:29 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Message-ID: <4FD61A55.9020906@FreeBSD.org>
Date: Mon, 11 Jun 2012 19:18:29 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:13.0) Gecko/20120610 Thunderbird/13.0
MIME-Version: 1.0
To: freebsd-java@FreeBSD.org
X-Enigmail-Version: 1.4.2
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: 
Subject: openjdk6: Compiler-gcc.gmk patching vs non-base compiler
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2012 16:18:38 -0000


patch-set adds blocks of definitions for bsd case to
jdk/make/common/shared/Compiler-gcc.gmk and
corba/make/common/shared/Compiler-gcc.gmk that look like this:
+ifeq ($(PLATFORM), bsd)
+
+  # Settings specific to BSD
+  CC             = $(COMPILER_PATH)gcc
+  CPP            = $(COMPILER_PATH)gcc -E
+  CXX            = $(COMPILER_PATH)g++
...

These assignments completely override CC/CXX/etc settings provided via MAKE_ENV.
I think that they should be conditional assignments (?=).
I've already tested such a change and it worked fine for compiling the port with
gcc46.


-- 
Andriy Gapon