From owner-p4-projects@FreeBSD.ORG  Fri Jan  5 19:28:06 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B952716A4A0; Fri,  5 Jan 2007 19:28:06 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 97B9816A47C
	for <perforce@freebsd.org>; Fri,  5 Jan 2007 19:28:06 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.freebsd.org (Postfix) with ESMTP id 4221F13C468
	for <perforce@freebsd.org>; Fri,  5 Jan 2007 19:28:06 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l05JRXr8041343;
	Fri, 5 Jan 2007 14:28:03 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Paolo Pisati <piso@freebsd.org>
Date: Fri, 5 Jan 2007 14:12:34 -0500
User-Agent: KMail/1.9.1
References: <200701051901.l05J17RW001347@repoman.freebsd.org>
In-Reply-To: <200701051901.l05J17RW001347@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200701051412.35212.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Fri, 05 Jan 2007 14:28:04 -0500 (EST)
X-Virus-Scanned: ClamAV 0.88.3/2414/Thu Jan 4 20:41:51 2007 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 112554 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jan 2007 19:28:07 -0000

On Friday 05 January 2007 14:01, Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=112554
> 
> Change 112554 by piso@piso_newluxor on 2007/01/05 19:00:07
> 
> 	Enable the irq line just after the filter claimed the interrupt.

More likely is that it shouldnt' disable the IRQ line except in the 
disable_eoi_source callback.

> Affected files ...
> 
> .. //depot/projects/soc2006/intr_filter/powerpc/powerpc/intr_machdep.c#19 
edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2006/intr_filter/powerpc/powerpc/intr_machdep.c#19 
(text+ko) ====
> 
> @@ -262,6 +262,15 @@
>  	}
>  }
>  
> +static void
> +intr_eoi_src(void *arg)
> +{
> +	uintptr_t nb;
> +
> +	nb = (uintptr_t)arg;
> +	irq_enable(nb);
> +}
> +
>  void
>  intr_handle(u_int irq)
>  {
> @@ -280,13 +289,12 @@
>  	ie = i->event;
>  	KASSERT(ie != NULL, ("%s: interrupt without an event", __func__));
>  
> -	res = handle_intr(ie, NULL, intr_eoi_src_stub, 
> -	    intr_disab_eoi_src_stub, NULL);
> +	res = handle_intr(ie, NULL, intr_eoi_src, 
> +	    intr_disab_eoi_src_stub, (void *)irq);
>  	switch(res) {
>  	case 0:
> -		break;
> +		/* FALLTHROUGH */
>  	case ECHILD:
> -		irq_enable(irq);
>  		break;
>  	case EINVAL:
>  		stray_int(irq);
> 

-- 
John Baldwin