From owner-freebsd-current@FreeBSD.ORG Wed Jan 21 23:11:12 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F2FD5106574B; Wed, 21 Jan 2009 23:11:11 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id C51A68FC08; Wed, 21 Jan 2009 23:11:11 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (pool-98-109-39-197.nwrknj.fios.verizon.net [98.109.39.197]) by cyrus.watson.org (Postfix) with ESMTPSA id 4219B46B06; Wed, 21 Jan 2009 18:11:11 -0500 (EST) Received: from localhost (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id n0LNB5db037051; Wed, 21 Jan 2009 18:11:05 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Bruce M. Simpson" Date: Wed, 21 Jan 2009 15:36:08 -0500 User-Agent: KMail/1.9.7 References: <200811191503.02192.jhb@freebsd.org> <4937EC6D.7050703@FreeBSD.org> In-Reply-To: <4937EC6D.7050703@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200901211536.08297.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 21 Jan 2009 18:11:05 -0500 (EST) X-Virus-Scanned: ClamAV 0.94.2/8885/Wed Jan 21 12:48:08 2009 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: current@freebsd.org Subject: Re: [PATCH] ppbus/ppc locking X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2009 23:11:12 -0000 On Thursday 04 December 2008 9:42:53 am Bruce M. Simpson wrote: > John Baldwin wrote: > > Please test! This is the last non-MPSAFE network driver at this point. This > > patch adds locking for the ppbus(4)/ppc(4) devices and the various ppbus > > child devices (lpt, vpo, lpbb, ppi, pps). The basic model is that a single > > mutex in the ppc(4) driver protects the ppc0 hardware and is shared with the > > various child drivers. Two drivers now have detach methods that did not have > > them before (plip and ppi). I've done some simple testing on my laptop (able > > to load the drivers and do some simple things w/o panic'ing or tripping > > assertions), but I am not really able to test the peripheral drivers fully. > > > > http://www.FreeBSD.org/~jhb/patches/ppc_locking.patch > > > > > > Runway lpt Giant is an occasionally show stopping issue for me because > my printer is attached via the plt port. I may get time to look at this > later on... > > I tried applying these patches against 7-STABLE. > > ppc_cleanup.patch applied OK to 7. > > ppc_intr.patch applied OK to 7 with interrupt.h change manually merged, > and some fixups to ppc.c for earlier intr_event kpi. > > ppc_locking.patch does not apply cleanly, and it's too much for me to > deal with right now. > > I found I had to hack up an existing 7 tree in /usr/src to get things to > compile because of the wide scope of the changes (touching kern, sys > etc), I couldn't just use an svn checkout to work from. Try http://www.FreeBSD.org/~jhb/patches/ppc_mpsafe_7.patch It is a complete backport generated against a fresh stable/7 tree. It does not need the interrupt changes since my locking patches actually undo them. -- John Baldwin