From nobody Sun Feb 15 14:27:42 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fDSt93VwGz6RZSk for ; Sun, 15 Feb 2026 14:27:45 +0000 (UTC) (envelope-from ahmadkhalifa570@gmail.com) Received: from mail-yx1-xb12f.google.com (mail-yx1-xb12f.google.com [IPv6:2607:f8b0:4864:20::b12f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fDSt86hw8z3Xvw for ; Sun, 15 Feb 2026 14:27:44 +0000 (UTC) (envelope-from ahmadkhalifa570@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yx1-xb12f.google.com with SMTP id 956f58d0204a3-64aefa98fe6so2217282d50.1 for ; Sun, 15 Feb 2026 06:27:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771165663; cv=none; d=google.com; s=arc-20240605; b=Zbc6LhLJyHdKTBlzf1CHq3FJM2gJdmahGojfP+L21RHhLAlr7xt4g8gJ4YSWythYZP 4VXyPXNq0fAKBKGCaoVM/OJSQ3yTA3cebs/JW433sGGJnKnTAqmh3osWDgnZS5MWwWgd 42BbiPGTI2zJ6T7PXi2s9S6juQ/GfK0r5uEfCAiCziaYGVDlptIMvE5660tQnE2K/F7x fCG1dKjzKnFuLWfH0HPU4wHY+LPucEcyCwBHJUeqGpQDhe4tRZmxNLcTicnoMi5HovJe uifYxeY2VG+n7IDVwTIaZnOIH+0zu1zF+OOGQSixg8IXMH5Xu43CdG4jnPupIr44hisu LSog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:in-reply-to:references:from :mime-version:dkim-signature; bh=g+gPeCSRYBAzeJPeyzMHrrbnF29LoImHvjGODHflglo=; fh=Viz8CSLB6OGOKVS0XRCa3lpKZQtijOzMy1IxW3Jg234=; b=lII2Nazf/7v0+v2O4EoKRR8BeDNsOdGpmhuk7MKEVdonCjggjpl0Mnnvy5sepLoP7v JlLVHIZsT7sRqTr8W+ERyg1CdH8yDtWsZqPch1EkE4kkTndUyHXHCSDvE3N305VuyESn W63qGlKM8RJrhxQZHWq6X+rAw/w9nXiSb9Jkq4Sxkfi/KrjMe6PMwsEZu7YvQNSwUFGd LVW9eZlxs/TsYBMHU4jPG77OKR+ed+EPqS39wJYPVI9dzVl4pqBLegox5ueJGhknpfXI 7aBaYfykTughSjNmKvpvFrRVRy5I3m7r2h8x9BM5nymAv+28+R7wOi0EqCUlO7IKu6w0 AgEQ==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771165663; x=1771770463; darn=freebsd.org; h=cc:to:subject:message-id:date:in-reply-to:references:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=g+gPeCSRYBAzeJPeyzMHrrbnF29LoImHvjGODHflglo=; b=ZX1v29BHSvTUbtYJCwK9gBuBTIw12w6xSgiuz3qVtT8lpdEzvpKJnv3L5w4Aq1sqEu pQqCcMyZQMaY/vsF7zwkYZWfVvffmeovlbznSBVD9l/xofeUjg7oOZGyp8HbeJgdfIET H8Kc41FMlyY5qvLkooF3G5e1xiCBR2p1+xgTbkA9RtIHzYTRzyB4sLvT5xAZU777LVau 78F4fCFk/iMC7ElVpOklx0zNNN1Htg99HA+D40b9CZ77JrZyABew/EKSbjkRVLq+It3n pwWY19DatMTS7Ps3VJGvx60vRhfaFut3UcxGUUDFEflFjE/H7NFb0HaAvem4nOtyUupV WSUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771165663; x=1771770463; h=cc:to:subject:message-id:date:in-reply-to:references:from :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g+gPeCSRYBAzeJPeyzMHrrbnF29LoImHvjGODHflglo=; b=oSWf+klgSRMp/k7+TLnULd74PAJdYFjQl+xhSh5Qj5o6q2fKze2U8laAuVdIDMUi+w mBz1v6J82jdRCKaR9ewsKeXQr7EaHa88zXcCdMl9jBed3uznRWmRR8JEvuWpaHyLvna/ YtXNWD09eHCCBAbomTt4GicYey0rTJA/bzUj3d7HuvfR0fd7Iav9ypDwY3naK5bG0QPm XqRmtCz8lvR3AqbobonQF36XKf/atuexuWLKMENCCKCc2c9ze3TnVGWeCs04Kf5b50Go 7Vjyhb2AQ8A0AC3vtGmqRXvQzEC1nd+QYIB/GR5EOT7DFYcOWT+LGzIPJgYfDnPCzKDR u+6w== X-Forwarded-Encrypted: i=1; AJvYcCWjoNOLEmmgOjOG6PNGiCeazMeirdET3s4L/MPN52AWk6Qu2dJz1tBdsRd9VaXBseXwh/kma98vZmAH4oFIMWdkfubP@freebsd.org X-Gm-Message-State: AOJu0YzwuG5bgXBfXB/G8s69ttuCKHb2dqbj+DbbB+D3svFoQaUBF0IV SfBir6CGnuc6WgresmV4SQ/eHEFneFf8Et7ZSP8zSECKM2yzgbFuek5Ce5imm2bW/ffLnjSiGb0 3Pqo+l5pXhB41NI4Bnm2KbTHVpS9HBqM= X-Gm-Gg: AZuq6aJSAXAWusOIOgM+YbddRF4XVdj6AC05XPriXFbS7G/hJQ57J4Hd3bYozI+i1nC Xrp3BA/Q0QT9iactA/PDVHN9d5uIObsBjtpDlm6rayemcUCaV+WrxEFIWhkgaQjoB39LnL6zWW5 3gjdCkjFljSHmIXsEsdZHNcZ3FbCGvRL//Oggy99MHegIADjXmKLS1uhjMNhIM+VJHHlYvNfdBg zBuM1waDf5IIM34wVBbMEVhkvm9Vn7RSiSSI0ZE29IHU4c5Mb/jUmC7wFKyqD5ithDWE3QVHkb2 8sYIR72C X-Received: by 2002:a05:690c:9d:b0:796:4ab9:f29b with SMTP id 00721157ae682-797a0cacb4bmr129923987b3.39.1771165662816; Sun, 15 Feb 2026 06:27:42 -0800 (PST) Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sun, 15 Feb 2026 06:27:42 -0800 Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sun, 15 Feb 2026 06:27:42 -0800 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 From: Ahmad Khalifa X-Mailer: aerc 0.21.0 References: <6991d07b.43f21.696cde4f@gitrepo.freebsd.org> <0B6A645E-D9E4-4337-B280-7E3CBA1FDC1B@freebsd.org> In-Reply-To: <0B6A645E-D9E4-4337-B280-7E3CBA1FDC1B@freebsd.org> Date: Sun, 15 Feb 2026 06:27:42 -0800 X-Gm-Features: AaiRm50A6Evfo-lFB3jAxw2q0xfEaHUttqrmUp6zoCVxp-8IkPWQTRqXh6pdDAE Message-ID: Subject: Re: git: a60e7e6ff0ec - main - stand: compile ia32 EFI loader with -malign-double To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4fDSt86hw8z3Xvw X-Spamd-Bar: ---- On Sun Feb 15, 2026 at 4:02 PM +0200, Jessica Clarke wrote: > On 15 Feb 2026, at 13:56, Ahmad Khalifa wrote: >> >> The branch main has been updated by vexeduxr: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=a60e7e6ff0ec1fdd66c2568ac6c03b843dbb3c9d >> >> commit a60e7e6ff0ec1fdd66c2568ac6c03b843dbb3c9d >> Author: Ahmad Khalifa >> AuthorDate: 2026-02-15 12:23:26 +0000 >> Commit: Ahmad Khalifa >> CommitDate: 2026-02-15 13:30:06 +0000 >> >> stand: compile ia32 EFI loader with -malign-double >> >> The UEFI spec says: >>> Structures are aligned on boundaries equal to the largest internal >>> datum of the structure and internal data are implicitly padded to >>> achieve natural alignment. >> >> By default, structs containing members of type "long long" have 4 byte >> alignment on i386. This caused some EFI structures to be subtly wrong. >> >> Fix this by compiling the ia32 EFI loader with -malign-double, which >> bumps the alignment up to 8 if such members are present. > > This seems like a dangerously big hammer. Are there any types shared > with libsa or the kernel itself that would change layout? (I suppose > for the latter they already need to be aligned as the kernel is 64-bit?) For the kernel, any shared types would have already needed to be aligned, yes. I didn't consider shared types with either libsa or libefi though, I'll look into it now. Nice catch. > > Annotating just the EFI types would seem more appropriate, like how we > annotate function pointers to use the Microsoft calling convention. They're all under contrib unfortunately. Not sure if we want to introduce that big of a diff with upstream. > > Jessica