Date: Mon, 22 Jun 2009 20:20:34 +0100 From: Peter Harrison <peter.piggybox@virgin.net> To: David Naylor <naylor.b.david@gmail.com> Cc: freebsd-acpi@freebsd.org, Peter Harrison <peter.piggybox@virgin.net> Subject: Re: [PATCH] Lenovo S10(e) ACPI Message-ID: <20090622192034.GA1059@ideapad.piggybox> In-Reply-To: <200906211400.19033.naylor.b.david@gmail.com> References: <200906181407.11607.naylor.b.david@gmail.com> <200906182100.15817.naylor.b.david@gmail.com> <20090620130403.GA1051@ideapad.piggybox> <200906211400.19033.naylor.b.david@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Sunday, 21 June 2009 at 14:00:14 +0200, David Naylor said: > On Saturday 20 June 2009 15:04:03 Peter Harrison wrote: > > Thursday, 18 June 2009 at 21:00:11 +0200, David Naylor said: > > > On Thursday 18 June 2009 19:40:28 Peter Harrison wrote: > > > > Thursday, 18 June 2009 at 14:07:07 +0200, David Naylor said: > > > > > Hi, > > > > > > > > > > ((Short version: apply patch and add 'debug.acpi.ec.gpe=1' > > > > > and 'debug.acpi.ec.timeout=100' to loader.conf and EC (battery, > > > > > thermal) ?should? work)) > > > > > > > > > > P.S. If this doesn't work please include details (and dmesg output) > > > > > and I'll try to help. > > > > David, > > > > The patch applied cleanly, and I've rebuilt and installed. System seems to > > work fine and I'm getting battery time reported properly. It still won't > > poweroff on shutdown though... > > > > uname -a: > > FreeBSD ideapad.piggybox 7.2-RELEASE-p1 FreeBSD 7.2-RELEASE-p1 #0: Sat Jun > > 20 11:03:21 BST 2009 > > peter@ideapad.piggybox:/usr/obj/usr/src/sys/GENERIC i386 > > > > dmesg: > I can't see anything that shouts out as being wrong, EC attaches correctly and > no timeout errors. > > Please see attached for a new patch, it fixes a potential (but unlikely) race > condition that could freeze the EC. It also 'fixes' the timeout problem > (well, the workaround seems more stable). > > This adds another tunable/sysctl called ``debug.acpi.ec.delay''. It defaults > to 0 (no change) but when set to a value it adds a delay (in microseconds) > after each successful request. This delay (at about ~200) appears to fix the > problem. I'll still recommend having debug.acpi.ec.gpe and > debug.acpi.ec.timeout set (just in case). So you should have in loader.conf: > > debug.acpi.ec.delay="200" # (us) > debug.acpi.ec.gpe="1" # Optional but recommended > debug.acpi.ec.timeout="100" # (ms) Optional but recommended > > If you are getting some `wait timeout' messages you can try increasing > debug.acpi.ec.delay. > > I'm not sure what is stopping your computer from shutting down (have you tried > `halt -p`?). The only difference that I can spot if that I'm using -current > (with the new acpi code). The patch may work, otherwise you could > give -current a try (it is probably easy enough to backport the ACPI > import...). > > Regards, > > David Hi David, Thanks for coming back to me - I haven't had a chance to test the new patch yet, but will get on to it as soon as I can. Is just a kernel rebuild enough after patching? Last time a did kernel + world to pick up the last security advisory too and it was a bit painful (even slower than my old Celeron M based Dell laptop). I'm still reeling from a packaged based upgrade of Firefox (still took a while, even using packages). Thanks again for your help. Peter.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090622192034.GA1059>