From owner-freebsd-stable@FreeBSD.ORG  Mon Apr  2 15:03:54 2012
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7663D106564A;
	Mon,  2 Apr 2012 15:03:54 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
	[IPv6:2001:470:1f10:75::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 4C9E38FC23;
	Mon,  2 Apr 2012 15:03:54 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id AFED0B94A;
	Mon,  2 Apr 2012 11:03:53 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-stable@freebsd.org
Date: Mon, 2 Apr 2012 11:00:15 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; )
References: <201203311925.q2VJPmCB056070@ambrisko.com>
In-Reply-To: <201203311925.q2VJPmCB056070@ambrisko.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201204021100.15742.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Mon, 02 Apr 2012 11:03:53 -0400 (EDT)
Cc: 
Subject: Re: [stable-ish 9] Dell R815 ipmi(4) attach failure
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Apr 2012 15:03:54 -0000

On Saturday, March 31, 2012 3:25:48 pm Doug Ambrisko wrote:
> Sean Bruno writes:
> | Noting a failure to attach to the onboard IPMI controller with this dell
> | R815.  Not sure what to start poking at and thought I'd though this over
> | here for comment.
> | 
> | -bash-4.2$ dmesg |grep ipmi
> | ipmi0: KCS mode found at io 0xca8 on acpi
> | ipmi1: <IPMI System Interface> on isa0
> | device_attach: ipmi1 attach returned 16
> | ipmi1: <IPMI System Interface> on isa0
> | device_attach: ipmi1 attach returned 16
> | ipmi0: Timed out waiting for GET_DEVICE_ID
> 
> I've run into this recently.  A quick hack to fix it is:
> 
> Index: ipmi.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/ipmi/ipmi.c,v
> retrieving revision 1.14
> diff -u -p -r1.14 ipmi.c
> --- ipmi.c	14 Apr 2011 07:14:22 -0000	1.14
> +++ ipmi.c	31 Mar 2012 19:18:35 -0000
> @@ -695,7 +695,6 @@ ipmi_startup(void *arg)
>  	if (error == EWOULDBLOCK) {
>  		device_printf(dev, "Timed out waiting for GET_DEVICE_ID\n");
>  		ipmi_free_request(req);
> -		return;
>  	} else if (error) {
>  		device_printf(dev, "Failed GET_DEVICE_ID: %d\n", error);
>  		ipmi_free_request(req);
> 
> The issue is that the wakeup doesn't actually wake up the msleep
> in ipmi_submit_driver_request.  The error being reported is that
> the msleep timed out.  This doesn't seem to be critical problem
> since after this things seemed to work work.  I saw this on 9.X.
> Haven't seen it on 8.2.  Not sure about -current.
> 
> It doesn't happen on all machines.

Hmm, are you seeing the KCS thread manage the request but the wakeup() is 
lost?

-- 
John Baldwin