From owner-svn-src-all@FreeBSD.ORG Mon Feb 16 07:36:25 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6E6B770C; Mon, 16 Feb 2015 07:36:25 +0000 (UTC) Received: from mail-la0-f47.google.com (mail-la0-f47.google.com [209.85.215.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E4931BFD; Mon, 16 Feb 2015 07:36:24 +0000 (UTC) Received: by labpn19 with SMTP id pn19so26710119lab.4; Sun, 15 Feb 2015 23:36:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=k/Tl6EtE/6uZ5udRDbsj0FPUP7ZGpKkqvAyDc7Gtvtg=; b=ax22/xdyMwFlV5FpaR0NW5RZ7fcunUcWmowbXKi497gb355oWJNux4rBMJA/NpVbz6 tCC4jrNQbivy+vlQRPA8WUumSk5GDUEiSmtg4znkwflAp+B4U9ayFBL2tjtq/hO7NWHX l8waNuutTfJsPkZ6Q+MLCDqhYf6qybkkzIlmpVGrqDJUklNHKnAwzW5g6Ej539LYNvT6 Nsjimm+ZsjqO1RrSYeCwyGuR7Athb0oKHQD9caRJhJaF6IZu8h0T/4+NkzUNbBg6jUIN tpcEITctbtsM5odtpO2VZzxoSjR8hLxjCEcQT6beSSYgvNgmTCe2JQ3+Zh360XLjmhHP YwKQ== MIME-Version: 1.0 X-Received: by 10.112.181.165 with SMTP id dx5mr20295175lbc.89.1424072177094; Sun, 15 Feb 2015 23:36:17 -0800 (PST) Sender: crodr001@gmail.com Received: by 10.112.28.40 with HTTP; Sun, 15 Feb 2015 23:36:17 -0800 (PST) In-Reply-To: <20150216012528.GA15484@FreeBSD.org> References: <201501060903.t06934qp081875@svn.freebsd.org> <20150122012709.GM15484@FreeBSD.org> <54C16715.6060701@gmx.com> <20150122222314.GO15484@FreeBSD.org> <20150215190100.GQ15484@FreeBSD.org> <20150216012528.GA15484@FreeBSD.org> Date: Sun, 15 Feb 2015 23:36:17 -0800 X-Google-Sender-Auth: HIPwRdoWkvE-ZVqomfYY4jd9McU Message-ID: Subject: Re: svn commit: r276747 - head/sys/netpfil/pf From: Craig Rodrigues To: Gleb Smirnoff Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Nikos Vassiliadis , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 07:36:25 -0000 On Sun, Feb 15, 2015 at 5:25 PM, Gleb Smirnoff wrote: > On Sun, Feb 15, 2015 at 01:33:19PM -0800, Craig Rodrigues wrote: > C> By the way, it would be helpful if you could provide feedback in > C> Phabricator. When I created those Phabricator reviews, I added > C> you as a reviewer to all of them, so you can't say that you didn't see > C> the patches. > C> You did not provide feedback on any of them: > C> > C> https://reviews.freebsd.org/D1309 > C> https://reviews.freebsd.org/D1312 > C> https://reviews.freebsd.org/D1313 > C> https://reviews.freebsd.org/D1315 > C> > C> Please take some time to go and provide feedback in those > C> reviews, so that a better patch can be made that makes you happy. > > Did you address all problems that arised after code was committed? > > Please do, otherwise my review would require me to cut-n-paste from > my own emails. > Yes, please cut and paste from your e-mails, and put in the reviews. It's easier to follow in the individual reviews because there are different changes in each review, rather than one big revert, which is what you did. Thanks. -- Craig