From owner-p4-projects@FreeBSD.ORG Mon Jul 30 21:30:42 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 9580C16A41F; Mon, 30 Jul 2007 21:30:42 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 396D216A41B for ; Mon, 30 Jul 2007 21:30:42 +0000 (UTC) (envelope-from zec@icir.org) Received: from mail.srv.carnet.hr (unknown [IPv6:2001:b68:e160:0:211:43ff:fecd:6374]) by mx1.freebsd.org (Postfix) with ESMTP id 2D70713C458 for ; Mon, 30 Jul 2007 21:30:41 +0000 (UTC) (envelope-from zec@icir.org) Received: from vipnet236-164.mobile.carnet.hr ([193.198.164.236]:58628) by mail.srv.carnet.hr with esmtp (Exim 4.50) id 1IFcp1-0001sv-3x; Mon, 30 Jul 2007 23:30:37 +0200 From: Marko Zec To: Julian Elischer Date: Mon, 30 Jul 2007 23:30:22 +0200 User-Agent: KMail/1.9.4 References: <200707301337.l6UDbq0H044330@repoman.freebsd.org> <46AE1EB0.1020909@elischer.org> In-Reply-To: <46AE1EB0.1020909@elischer.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200707302330.23247.zec@icir.org> X-SA-Exim-Connect-IP: 193.198.164.236 X-Spam-Checker-Version: SpamAssassin 3.1.4 (2006-07-26) on nihal.carnet.hr X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=ALL_TRUSTED autolearn=ham version=3.1.4 X-SA-Exim-Version: 4.2 (built Thu, 03 Mar 2005 10:44:12 +0100) Cc: Perforce Change Reviews Subject: Re: PERFORCE change 124354 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2007 21:30:43 -0000 On Monday 30 July 2007 19:24, Julian Elischer wrote: > Marko Zec wrote: > > http://perforce.freebsd.org/chv.cgi?CH=124354 > > > > Change 124354 by zec@zec_tpx32 on 2007/07/30 13:37:17 > > > > > > > > While here, deprecate backpointers from vnet modules to > > the corresponding parent vnets, given that so far they have > > never been used. > > hmmmm > I was thinking about that.. The idea seems to make sense initially.. > I am surprised that they are not used but wonder if that means > they would never have been used? > would they not be used in the case of hierarchical schedulers? Yes we (will) need one form or another of hierarchy among vnets, but this deleted backpointer used to be something else... It was included in each per-module structure (i.e. NET, INET, INET6, IPFW etc.) and was pointing back to the corresponding vnet. It turns out that we always know in which vnet we are operating (by consulting the curvnet macro or by looking at some other appropriate struct such as socket or ifnet), hence maintaining this information in each vnet-module seems to be redundant... Marko