From owner-freebsd-current@FreeBSD.ORG Thu May 31 15:57:53 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F31941065670; Thu, 31 May 2012 15:57:53 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id C88A38FC21; Thu, 31 May 2012 15:57:53 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 280E0B995; Thu, 31 May 2012 11:57:53 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org, Matthias Apitz Date: Thu, 31 May 2012 11:34:55 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p13; KDE/4.5.5; amd64; ; ) References: <20120526142229.GA3893@tinyCurrent> In-Reply-To: <20120526142229.GA3893@tinyCurrent> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201205311134.55258.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 31 May 2012 11:57:53 -0400 (EDT) Cc: swills@freebsd.org Subject: Re: 10-CURRENT r235646 && open-vm-tools-8.6.0-425873 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 May 2012 15:57:54 -0000 On Saturday, May 26, 2012 10:22:29 am Matthias Apitz wrote: > > Hi, > > The port ports/emulators/open-vm-tools does not compile in 10-CURRENT: > > # make install clean > ... > make VM_UNAME=10.0-CURRENT MV=mv RM=rm OVT_SOURCE_DIR=/usr/ports/emulators/open-vm-tools/work/open-vm- tools-8.6.0-425873 > MODULEBUILDDIR=/usr/ports/emulators/open-vm-tools/work/open-vm- tools-8.6.0-425873/modules/freebsd -C "/usr/ports/emulators/open-vm- tools/work/open-vm-tools-8.6.0-425873/modules/freebsd/vmxnet" > @ -> /usr/src/sys > machine -> /usr/src/sys/i386/include > x86 -> /usr/src/sys/x86/include > :> opt_bdg.h > awk -f @/tools/makeobjops.awk @/kern/device_if.m -h > awk -f @/tools/makeobjops.awk @/kern/bus_if.m -h > awk -f @/tools/makeobjops.awk @/dev/pci/pci_if.m -h > cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I/u > sr/ports/emulators/open-vm-tools/work/open-vm-tools-8.6.0-425873/lib/include > -I/usr/ports/emulators/open-vm-tools/work/open-vm- tools-8.6.0-425873/modules/shared/vmxnet -I. -I@ -I@/contrib/altq -finline- limit=8000 --param > inline-unit-growth=100 --param large-function-growth=1000 -fno-common > -mno-align-long-strings -mp > referred-stack-boundary=2 -mno-mmx -mno-sse -msoft-float -ffreestanding > -fstack- > protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls > -Wnested-e > xterns -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith > -Winline -Wcast > -qual -Wundef -Wno-pointer-sign -fformat-extensions > -Wmissing-include-dirs -fd > iagnostics-show-option -c if_vxn.c > cc1: warnings being treated as errors > if_vxn.c: In function 'vxn_load_multicast': > if_vxn.c:719: warning: implicit declaration of function 'IF_ADDR_LOCK' > if_vxn.c:719: warning: nested extern declaration of 'IF_ADDR_LOCK' > [-Wnested-ext erns] > if_vxn.c:746: warning: implicit declaration of function 'IF_ADDR_UNLOCK' > if_vxn.c:746: warning: nested extern declaration of 'IF_ADDR_UNLOCK' > [-Wnested-e xterns] > *** [if_vxn.o] Error code 1 > > Let me know if you need more information. > Thanks It should be using if_mcast_rlock() and if_mcast_runlock() instead of using those macros directly. This works all the way back to 8.0. -- John Baldwin