From owner-svn-src-head@freebsd.org Mon Apr 9 14:08:01 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA587F83292; Mon, 9 Apr 2018 14:08:00 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-lf0-f42.google.com (mail-lf0-f42.google.com [209.85.215.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5583571063; Mon, 9 Apr 2018 14:08:00 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-lf0-f42.google.com with SMTP id u3-v6so6767181lff.5; Mon, 09 Apr 2018 07:08:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=oCGYrwQHHJ0IFmJbbht60KlBdEywmFujRzQDamoDZkc=; b=jU1bjweif2Kd3yllgiPT4+B74VbHWU/mPaR3/MLkPKyrEEErDdrYi0afhYHLrOqTjX +Y8X9sXP6+vqW75O6LfXTVne1jJADEwfXR9xg5auFd3visID+yb2Wr4x9mWI/1gCOudR eolnZGoZ3QRR4/H8amD8eJM2QINARGMpjJIJHN+4lCBdkBgbeD0jgX6IXluYPNoku+MQ b4Xi93ODDZH+2wsb2NDvYPgmBQZvN9HPuuTeMWxR0+pSsRCAtXI8dJ5YgXJmNBo9LmSo 8OxIu033ZajVjnIdg8cv1IZbLuXnfkFzlXD//ecACzZ8LQJiFnZMTtn8ZdoiEsIEPuW/ 3Sww== X-Gm-Message-State: ALQs6tBFU2QbMEA4UEdLIW87QbmdNLxXmxIcFLAoK0sMNnyR4DLV8G2J hCT3T5YHV4NcPpWpCGEr6b8SsFxC X-Google-Smtp-Source: AIpwx48rlwWtzsoXAH4GZtDCi9BSpazvmGajPyl5fLNXYA4uUENDesTM80RxRP+ap6FpT3MCdMDTRw== X-Received: by 10.46.77.80 with SMTP id a77mr22499836ljb.91.1523282872576; Mon, 09 Apr 2018 07:07:52 -0700 (PDT) Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com. [209.85.215.43]) by smtp.gmail.com with ESMTPSA id y22sm81223ljy.70.2018.04.09.07.07.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Apr 2018 07:07:52 -0700 (PDT) Received: by mail-lf0-f43.google.com with SMTP id d20-v6so911233lfe.3; Mon, 09 Apr 2018 07:07:52 -0700 (PDT) X-Received: by 10.46.155.204 with SMTP id w12mr20724015ljj.76.1523282872326; Mon, 09 Apr 2018 07:07:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.129.90 with HTTP; Mon, 9 Apr 2018 07:07:31 -0700 (PDT) In-Reply-To: <201804091405.w39E5in8049357@repo.freebsd.org> References: <201804091405.w39E5in8049357@repo.freebsd.org> From: Kyle Evans Date: Mon, 9 Apr 2018 09:07:31 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r332327 - head/sys/arm/allwinner To: Kyle Evans Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 14:08:01 -0000 On Mon, Apr 9, 2018 at 9:05 AM, Kyle Evans wrote: > Author: kevans > Date: Mon Apr 9 14:05:43 2018 > New Revision: 332327 > URL: https://svnweb.freebsd.org/changeset/base/332327 > > Log: > if_awg: Add support for allwinner,{tx,rx}-delay-ps bindings > > Split out delay parsing into a separate function; we'll support both > {tx,rx}-delay as well as the new versions. > > While here, validate that they're within the expected range and fail to > attach if they are not. Assuming that we can clamp the delay is a bad idea > that might result in a non-working awg anyways, so we'll fail early to make > it easier to catch. > > This version also unsets the tx and rx delay registers unconditionally and > then sets them if we read a non-zero delay. These delay properties should > default to 0 if not specified, as declared in the binding documentation. > Presumably the delays will be set via hardware configuration if they're not > explicitly set in FDT. > Ugh, I dropped these: Reviewed by: manu Differential Revision: https://reviews.freebsd.org/D15008