From owner-freebsd-java@freebsd.org Sun Dec 3 19:32:54 2017 Return-Path: Delivered-To: freebsd-java@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AFDCEE65125 for ; Sun, 3 Dec 2017 19:32:54 +0000 (UTC) (envelope-from r.c.ladan@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 8624E63B51 for ; Sun, 3 Dec 2017 19:32:54 +0000 (UTC) (envelope-from r.c.ladan@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 856D9E65124; Sun, 3 Dec 2017 19:32:54 +0000 (UTC) Delivered-To: java@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 85143E65123 for ; Sun, 3 Dec 2017 19:32:54 +0000 (UTC) (envelope-from r.c.ladan@gmail.com) Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0E65563B50 for ; Sun, 3 Dec 2017 19:32:54 +0000 (UTC) (envelope-from r.c.ladan@gmail.com) Received: by mail-wm0-x234.google.com with SMTP id y82so11961025wmg.1 for ; Sun, 03 Dec 2017 11:32:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=QlmItn1ewq1zAYi+Kk350+wCeLnOfJZlnM3ERn2sXBE=; b=Tke3pcw3ytyN/JwuUQYcaE2vOhFT8LA8dGdebIjDx/zR5EhtjbbBBElIOF7EQ20wSu psgY7kpu2QJ4vO6JHn56fI6CHZpG5/+pXiCqd2VaQ7mNhHQRNMh8owU3Oan0DbcT+Gsl z56HgyF2jJrayiBAAkZNOFfOGcwiE1g/BrAVyON6X7wKTN/J3DfwUD1GA2It90Jlybpm 9SmlV9U6g6LrJBJKxpQNeZudSPsj43QnoSe8umq/uWkjB6DSU9NqWkhpKayqkeTdeMB4 vUNNMzbTO5h6iIMrEbqUag4vTo4aG3Uf2T/++QYVH8K+JLwSaVwK07Px6rIy2NP/gCZq b0qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=QlmItn1ewq1zAYi+Kk350+wCeLnOfJZlnM3ERn2sXBE=; b=n82yzcBWWX6MccTS7V9XNs4JW9bbCvqt3clLYx6jLJeaNboCB9qmcSxOpfAs20XSko KWM97kHPq0//2ZPidMDJl1AStv+8Ff8jXqZy0pd/+2fPMKBD0V2miltLAQpVB+kZx6Qn cTWnpjFjRObIAxqDc2p6imFjICMEm++/vqnMTQdhOVappW9oRjGxgA7F3JqmmAfLd84N g/z/Vl7VjBt98dyihs7WsEb0wIadqcJT52UcwADOEdk6M7agdbG/Hawkw2ZAUUuQSt38 ysEpTGwq9jtQi970lKggZB/QCQFjbiTZcEpVRwl8EC33o88BTkz/O/5vE/0DJdhZFbK5 j3pw== X-Gm-Message-State: AJaThX63ok//Lwvor7B/xSOgVdAjFxWVcN4NsYGbIUbVvb34cdrCny7s Op4ZxErX4N/GjMxLZhfIi5U= X-Google-Smtp-Source: AGs4zMZu8mMS2HxRP+Na7zx7zPuwLO+Im1smgCoYIHhcqzwUY7mC9SDvl/uXXr2BW6vYeGbJ2yh3pA== X-Received: by 10.80.154.67 with SMTP id o61mr12027505edb.291.1512329571831; Sun, 03 Dec 2017 11:32:51 -0800 (PST) Received: from ?IPv6:2001:980:d7ed:1:3265:ecff:fe8f:d3ec? ([2001:980:d7ed:1:3265:ecff:fe8f:d3ec]) by smtp.gmail.com with ESMTPSA id y1sm6907391edl.39.2017.12.03.11.32.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Dec 2017 11:32:51 -0800 (PST) Sender: =?UTF-8?Q?Ren=C3=A9_Ladan?= Subject: Re: Remove dead code from java/cacao/Makefile To: Gerald Pfeifer , java@FreeBSD.org, Joe Nosay References: From: =?UTF-8?Q?Ren=c3=a9_Ladan?= Message-ID: <09dc739b-fef9-ca35-f930-0e9ca9720b23@freebsd.org> Date: Sun, 3 Dec 2017 20:32:49 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Dec 2017 19:32:54 -0000 On 03-12-2017 18:04, Gerald Pfeifer wrote: > On Sun, 28 May 2017, Gerald Pfeifer wrote: >> I did not propose to remove that option, I merely wanted to relay >> that (a) currently this alternative codepath is simply broken and >> (b) remove three lines of dead code at least. > Let me follow-up on this again. > > Rene, I saw that you recently updated java/cacao. Can you approve? You would have to ask java@, I just updated the port to use a supported version of bootstrap-openjdk and then fixed my previous commit. > I verified that WITH_GCC has exactly two occurrences in the _entire_ > Ports tree, and that is this dead code in java/cacao/Makefile. > > Any real objections towards removing this _dead_ code? So WITH_GCC is not defined anywhere in usr/ports/Mk/ nor in lang/gcc*, which would indeed render the if statement useless. So yes, the change should be fine. You could also remove the GCC_SUFX?=46 line? > Gerald > > PS: There is more, but let's focus on this most straightforward one > for now where I'm surprised (a) nobody else cared and (b) even this > was hard to get in. > > Index: java/cacao/Makefile > =================================================================== > --- java/cacao/Makefile (revision 455410) > +++ java/cacao/Makefile (working copy) > @@ -37,9 +37,6 @@ > JAR= ${LOCALBASE}/bootstrap-openjdk6/bin/jar > JAVAC= ${LOCALBASE}/bootstrap-openjdk6/bin/javac > .else > -.if defined(WITH_GCC) > -GCC_SUFX= ${WITH_GCC:S/.//} > -.endif > GCC_SUFX?= 46 > BUILD_DEPENDS+= gcj${GCC_SUFX}:lang/gcc${GCC_SUFX} > EXTRA_PATCHES= ${FILESDIR}/gcj.patch > René