From nobody Sun Apr 9 23:47:28 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pvph81KgGz44Rvs for ; Sun, 9 Apr 2023 23:48:08 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pvph72z34z3vP6 for ; Sun, 9 Apr 2023 23:48:07 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=sunpoet.net header.s=google header.b=AM8ebBRX; spf=pass (mx1.freebsd.org: domain of sunpoet@sunpoet.net designates 2a00:1450:4864:20::636 as permitted sender) smtp.mailfrom=sunpoet@sunpoet.net; dmarc=none Received: by mail-ej1-x636.google.com with SMTP id gb34so9231347ejc.12 for ; Sun, 09 Apr 2023 16:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sunpoet.net; s=google; t=1681084085; x=1683676085; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jkkB0AMnvKPIUvo46RKBVp4kIcpl3GilFg2Hy0Zy67Y=; b=AM8ebBRXBPTzt2u2RRPX8Zw8B8HMZgJdQPElXLfoWeXiWAJ4DQc5damtiAlxocvOe6 fWNNwEzIcblrJtQet9RNzZIe+ubrmuDjkoVYvfTtivo82yBDb0X81HYl6K9GgpMaBwiv jxFR9nsLkwOpb1cu8YTCEB3NIlNWtz+EZmZjeoV/7BBLRlzqxr6Fe4BArxVpgstS7tBB NLI6kSnvhZuCpg7MQ6s/Y7VoaKzPydfqkluigEGAGS5XH9QSHDbpnbdQsjDBI2HOy4W/ ky3/b8JR029KNC4anZepfnPqwf63iKKsb2kdG8xAh6sENgE0MqAF1a4iMfapaqJiFgYp 7zEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681084085; x=1683676085; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jkkB0AMnvKPIUvo46RKBVp4kIcpl3GilFg2Hy0Zy67Y=; b=Z803yuL4Mto2jeCxMM7ytB70fNP6BBXfUirxDS1qItCycf2XivbCJ6fgabOV63V5k5 f4ogsIX0E51auazCCOidp/FptiFe5ob1fRN0rk4vxyw82TeYZXRjOlX/P/zbE/8mo+Id d+M4cUWfNU165l4IT250fH/L8x5ibkP8CBusC52nIUDvkglj7DH/K8X504JnaHBSgFou KMzkQ0V6nhRfbYDMyMSD97Wg86t5BIYIFh0nvVgZNUClHFXVzL5uZFvB0IlJiumjNR8A Ai+ADF8WSg71FzmaDSL1Y97oPd7LQt+ZSwlj/MjvcocOMpGOCOS7PiB9FB0EHoHNtqCe KtYA== X-Gm-Message-State: AAQBX9fL0I/X7+yExPOLVj6cHcjGVUCVen4FVs+njJ3pXYgfSJFSfPrS iZUHVg4kBkvd+m+bL1l8ejqUAlWNwSg18HFf/M9R7A== X-Google-Smtp-Source: AKy350Zp0Fn4IOJVQG0gkjd+FpQiKLBsmHQMQF5WWhqgM4mo6mnrnyBLY4KiUU9pGgWd5qK8kiUQQknoIRvr4bLvDOQ= X-Received: by 2002:a17:906:6a0b:b0:948:b300:7033 with SMTP id qw11-20020a1709066a0b00b00948b3007033mr2873837ejc.1.1681084085639; Sun, 09 Apr 2023 16:48:05 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202304050615.3356FKNq062154@gitrepo.freebsd.org> <7accd096-7871-29ad-0824-c035504d01b0@FreeBSD.org> In-Reply-To: From: Po-Chuan Hsieh Date: Mon, 10 Apr 2023 07:47:28 +0800 Message-ID: Subject: Re: git: 72ad532057c9 - main - archivers/zstd: Add CMake config files and adjust Makefile To: Dima Panov Cc: Alexey Dokuchaev , Guido Falsi , Daniel Engberg , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000c32ac905f8efe3fd" X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; R_DKIM_ALLOW(-0.20)[sunpoet.net:s=google]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::636:from]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; ARC_NA(0.00)[]; DMARC_NA(0.00)[sunpoet.net]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[sunpoet]; DKIM_TRACE(0.00)[sunpoet.net:+]; TO_DN_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-ports-all@freebsd.org]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4Pvph72z34z3vP6 X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N --000000000000c32ac905f8efe3fd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Fri, Apr 7, 2023 at 5:36=E2=80=AFAM Dima Panov wrot= e: > Moin-moin! > > On 06.04.2023 16:32, Alexey Dokuchaev wrote: > > On Thu, Apr 06, 2023 at 03:19:55PM +0200, Guido Falsi wrote: > >> On 06/04/23 15:17, Alexey Dokuchaev wrote: > >>> On Wed, Apr 05, 2023 at 02:20:21PM +0200, Guido Falsi wrote: > >>>> On 05/04/23 08:15, Daniel Engberg wrote: > >>>>> commit 72ad532057c9f9fb6fa370c80f663c005e9dd021 > >>>>> > >>>>> archivers/zstd: Add CMake config files and adjust Makefile > >>>>> > >>>>> - Use upstream's short test for "make test" > >>>>> - Use verbose output by default during build > >>>>> * Tweak Makefile to follow Porters Handbook more closely > >>>>> * Install CMake files (taken from CMake build framework) > >>>>> > >>>>> PR: 267652 > >>>>> Reported by: fluffy > >>>>> Approved by: portmgr (maintainer timeout, 1+ month) > >>>> > >>>> Looks like this, un[luckily], causes a failure with devel/qt6-base > >>>> (abridged error, full log if needed): > >>>> > >>>> ld: error: relocation R_X86_64_32 cannot be used against local symbo= l; > >>>> recompile with -fPIC > >>>> >>> defined in /usr/local/lib/libzstd.a(zstd_common.o) > >>>> >>> referenced by zstd_common.c > >>>> >>> zstd_common.o:(ZSTD_versionString) in archive > >>> > >>> Yeah, I'm seeing this as well. Admittedly, the whole commit looks > >>> dubious to me, with all these out-of-blue new files and gratuitous > >>> changes. I guess sunpoet@ should revert it and merge only needed > >>> parts thereof properly. > > Nope. > This commit unmasked the real problem of using autocrap tools to build > zstd -- a broken static library. > Issue was not raised before 'cause cmake configs was absent and qt6 > (and may be other consumers) hooks up only shared lib. > It should be fixed in ports 454e3c91ae9105a9af1939c9632424083ed3bbdb. I've tested unmodified devel/qt6-base and it builds fine. > Just to be clear -- I have a version of port converted to pure cmake buil= d > and > it produce a valid static library which correctly liked by any consumer. > > Anyway, number of consumers which require cmake'd zstd will grow in near > future. > openimageio/opencolorio/opnehadinglanguage are already require it to push > new versions to the ports tree. > Please let me know if more ports are broken. > > >> > >> I have only reported the issue as an early warning, as I said. > >> > >> Regarding qt6-base a fix has already been proposed here by diizzy: > >> > >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270664 > > > > Ah, good to know it's being taken care of, thanks for sharing! > > Nope. This patch not fixes anything but masking the real issue with broke= n > libzstd.a by prefer dynamic library over static to link. > > > > -- > Sincerely, > Dima (fluffy@FreeBSD.org, https://t.me/FluffyBSD) > (desktop, kde, x11, office, ports-secteam)@FreeBSD team > --000000000000c32ac905f8efe3fd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

On Fri, Apr 7, 2023 at 5:36=E2=80=AFAM Dima Panov = <fluffy@freebsd.org> wrote:=
Moin-moin!

On 06.04.2023 16:32, Alexey Dokuchaev wrote:
> On Thu, Apr 06, 2023 at 03:19:55PM +0200, Guido Falsi wrote:
>> On 06/04/23 15:17, Alexey Dokuchaev wrote:
>>> On Wed, Apr 05, 2023 at 02:20:21PM +0200, Guido Falsi wrote: >>>> On 05/04/23 08:15, Daniel Engberg wrote:
>>>>> commit 72ad532057c9f9fb6fa370c80f663c005e9dd021
>>>>>
>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 archivers/zstd: Add CMake c= onfig files and adjust Makefile
>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0
>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 - Use upstream's short = test for "make test"
>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 - Use verbose output by def= ault during build
>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 * Tweak Makefile to follow = Porters Handbook more closely
>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 * Install CMake files (take= n from CMake build framework)
>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0
>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0267652
>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 f= luffy
>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 p= ortmgr (maintainer timeout, 1+ month)
>>>>
>>>> Looks like this, un[luckily], causes a failure with devel/= qt6-base
>>>> (abridged error, full log if needed):
>>>>
>>>> ld: error: relocation R_X86_64_32 cannot be used against l= ocal symbol;
>>>> recompile with -fPIC
>>>>=C2=A0 =C2=A0 >>> defined in /usr/local/lib/libzst= d.a(zstd_common.o)
>>>>=C2=A0 =C2=A0 >>> referenced by zstd_common.c
>>>>=C2=A0 =C2=A0 >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0zstd_common.o:(ZSTD_versionString) in archive
>>>
>>> Yeah, I'm seeing this as well.=C2=A0 Admittedly, the whole= commit looks
>>> dubious to me, with all these out-of-blue new files and gratui= tous
>>> changes.=C2=A0 I guess sunpoet@ should revert it and merge onl= y needed
>>> parts thereof properly.

Nope.
This commit unmasked the real problem of using autocrap tools to build
zstd -- a broken static library.
Issue was not raised before 'cause cmake configs was absent and qt6
(and may be other consumers) hooks up only shared lib.

It should be fixed in ports 454e3c91ae9105a9af1939c96324240= 83ed3bbdb.
I've tested unmodified devel/qt6-base and it build= s fine.


Just to be clear -- I have a version of port converted to pure cmake build = and
it produce a valid static library which correctly liked by any consumer.
Anyway, number of consumers which require cmake'd zstd will grow in nea= r future.
openimageio/opencolorio/opnehadinglanguage are already require it to push new versions to the ports tree.

Please = let me know if more ports are broken.
=C2=A0

>>
>> I have only reported the issue as an early warning, as I said.
>>
>> Regarding qt6-base a fix has already been proposed here by diizzy:=
>>
>> https://bugs.freebsd.org/bugzilla= /show_bug.cgi?id=3D270664
>
> Ah, good to know it's being taken care of, thanks for sharing!

Nope. This patch not fixes anything but masking the real issue with broken<= br> libzstd.a by prefer dynamic library over static to link.



--
Sincerely,
Dima (fluffy@FreeBSD.org, https://t.me/FluffyBSD)
(desktop, kde, x11, office, ports-secteam)@FreeBSD team
--000000000000c32ac905f8efe3fd--