From nobody Mon May 22 23:58:47 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QQDtz4GpMz4CcbL for ; Mon, 22 May 2023 23:59:07 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic307-8.consmr.mail.gq1.yahoo.com (sonic307-8.consmr.mail.gq1.yahoo.com [98.137.64.32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4QQDtx72z6z3DMV for ; Mon, 22 May 2023 23:59:05 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b="f+poqOj/"; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.64.32 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1684799944; bh=XAonoGbJ1Pz+R+3mQ0NBGuDM+Yr6/QvUcK14J6SR62w=; h=From:Subject:Date:Cc:To:References:From:Subject:Reply-To; b=f+poqOj/Fkv2KG36+RKh8dX+LIhlVbF50Vg83BU+sn/iBKxSRZ6VbJvc/17DUqVfCJGBS1JGzDZOx/H5k5cTsESjhAps6uYLH9TQ40fSYCf/qW5tO+KqeNhaXm8/fbI4r/rlZpZ9XwDnx6XTuDcAA5v2RbFJnZb0drTAmBy2R6i+Rxwz0nb0WTT9wCerY268640mlio2xz1tmhT4e2+mc5oGxGXABPlO6TrlNdvmQpfpCGeOwTW+6UCI03Z6TAPKGrVjDFpqdm7011NEfXbuhfRu15y4Hd5DkAebo/Z3HPOeGvcN+5wmv1XLV2n4KQAqLvUPLOmfPcIc4QVbbiyNXQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1684799944; bh=/GGTgy/0lL5Km8JD0W2UsT9bceJL2S8NP6fz+xODF7b=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=kpW3zE4fxw9ZYr+hb5eLH2cD+8S2oV3iw9yIdQ14wy5PIjEP5I5INT40C26/Q3mX6FfNVyuJldhlGJIS1rcAAAhdONes3CKMfmMDFmC3IRaLdoJG8WkelvWb+zpwSxpavbA8QxRBx23ZXQ8VyRxp+2NvrvGjsR745MaUGWPqLNmxQabWkRxve36mfz2tlHKiIrvZBv0QldCYSaq+X9lryiZJ5FaJFgEy70jvbxWTXqr9br536R5XPNhxnsKJjQd1M8tFxPEY7SD3+iUtk3yqsrnBq3vL/TkDciEZfTJb5RaNrXROt+d2E1bR77mkaDwWuKEW6SzgedAhGFsaBnp8AQ== X-YMail-OSG: yqT9tYYVM1kX1PX5yoe0D3gmPO33G2tb6IIkIJkLD1pQw1F4b_M7FO0R4qMoRvi zumbS33LzxPd4TxvqqCtTQlhvRC15K3vOeEz2MEqfDtRdnjrde_zXg0Pxt6Hg6lL9sVYZBvjPO0S pJnajlxyT90oUNCnFT_p.XqL5k8UifcpaEkppXYkBtIounQ7MZx1MkrU526vFgxfFbHeOPF5Od59 ZWafW7zIPU.VQJDeobkBcxIt9ayxlOYVZ2Hz8LrPE0cyp_Kr26NDnwhVrediuXD_mne89EAAfqvy WWnLS6HsmNQZasLl2NWbe9eQ2aJa44sN7Ba9IFi2Wfn8NYN6bsbcI3SmlvIEccPoRLGEELlvVZOF bWRZuOSrp15tWHSsQrnpbRsD1BtOhESh5HeVuhVkHqioubSFIa_VMrkr1pQH5As1yCwdRGPhM9jP t0v9kyDCcexxRoyqzZLBGLFuYuFBfBKe.x4hLQ8bWmpr7y.Q3.1AWHwhovNiYvG9qvRZwT5FcIOG WyLpzMKVawo7MqznLNA4cyWDTAjTdmuAHTTcAhOUnHMCgq1E40SF5jyrsXGnqOT89U2zAg1JC91l Yq47l9QJqCoqe.d9xSioja3_jIpkvT0TEhvN8zSqXUN_ve_.M.KQqpkhdiTx0yS.4lVGZWtGUqs9 73rvbu4cAN2NfXWzZfR25N1H2u83VC8Cp9e3jZlay1ZF1Dtlrai53cOhvD1XmMCrOFyGb4ciyGRx S0tHKu83NTYn68hN_ojmhwZ6X7wm_DTmeeAS7NZPV4eYlSaG2z_MBjBZouYSi7WH4OEQxFirC4EE dGekT7oG76A4dXxF4pjuMBKeA6VhTyxgvin8qevIMaIv_cyxgV3x6Qt8._JUUGGAbhZeCwuc5nNt dlwFCp6x3z20JOlTUgd.qahJQZX2.hVzLju6zf7eGKjp98DbhsdroHRLTLd3JcZmpYz5HZ5GvSV5 tOshxw9jDgkvNZkws8yjASNujuqfwh32ls4ti9oIPzMb64N5LO0bP7Oxuitib9UCssTkXCDYOEMu 6U2vPnS22gZKZUOGWtFx4WG9JqUEGfhht9zVR.Fp.qDaJrCJvkOzlZl5kuHWBS446mWFzd8qqWub Z1lovCdm2SP3jJtyQjDhKMeEvP49pX6asWaSrUGYLzqpfRmAPH6nKP9_8Mr8K9WoIBsErC8j_5xf vJWyJKePtL4oUSc1ZJUx80vQVGvfIlsQ58ZyCvjsa.txQv0_qEjGS8Fdhq1sLR7oypHNajdB7ex2 ZDDX_0EAKuhYfzPQS9PeZEMQdbPK8.xVEEX6YvB3.TKV4t45Kkumn4Js_Epd08Xy1sRHMdOC06f5 CWj7FoAokvfL8n5XjX9tx_dgxXbloC5nlb0K7Wh8ZyVtCM6TJGlDpSFRnT2ArHoIIkcJmtcnxyVp GFauB9mdfZKsoLgO5_Wfj.r4RmJjWYEuF5HVDPLVLGqCu51sQlauFypzPTwO_baUB6a9McuYvUgi gFisrkptx7tb4n4737MWxQpS3YIU5jJmEgouy1FCKcdHO90jqRSfMPqIM15r.07q1cXfVdpqYeIW VllT.SAuFeVtJXiMAgfOEQg8tW6d4a3pKGXlLNuExTY869aMr0UOQoyLcQIwhf_kvPSOtBK_T50F df_DQAj.WIz.tlCW0y5drC9S.rbFt_RL9dttqrVu0Td3yRXZro6isVqVZsrQoYsJmEoJXygRZFvH E.dsCOBN8tk.7d9.5l3BSITXuCINSvAu.KAYzIipIvJn.x7G8eWmGag8hMecNMu23cYVJ1WmXWEz MWOBkvK5CUPLYo5v56UG5H5lcJVh1h8Pn4WZ.ll7nN62vVR.NUw7Qg9Qm615B36MxoART0zOmSPG weN3_WkhYRvIMTMNambTYRr7.WJidHcM1bfCoISYHKV1bMR6o3g1Hm39SLrNpLvHATSkjFZI2jBj dXtXcyVZ29QUkWnvBnotevx7DcGtXGZZQcwt.Ed3TPsHckoAPEU_SAlZhRI8yZ7Qu6uckIrwpVPI CCjAjHptgX65ONHcWcH.rDpSSzK_wkurVW7nV2K8CFSgApNTmLrKuub2VARXISuJJIGkVdawM.rF FRTx5.pjS9eobCltlSRn7NU0gaaxXjegNU4pzn13k3dtglp6p0u8fTlg1YkDd2eSOd6M3fGM8hKu ygGXV5GF7jMSs4vVBstpS6lrX3Gm_MANB68Dw.kpVltKAuUormRCA0YRB5Nin25goWQBIUtDmOhO 2aYymwsMrdB2.BYHy4yWKxyH6kZ9KA_n4l2MAf.7OPjJC1TXC73Hbstxr7XJJ7xiZP0T_7d58F5M fRT_vIhgJ6eI- X-Sonic-MF: X-Sonic-ID: 5d72243d-5ff7-4f51-b664-ac9f31e3740b Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Mon, 22 May 2023 23:59:04 +0000 Received: by hermes--production-bf1-54475bbfff-gh86g (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f3aee8b5983aba47285d02b0946d711f; Mon, 22 May 2023 23:58:59 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: Re: git: ccb59683b983 - main - arm64: add tests for swp/swpb emulation Message-Id: <894110D7-EFB1-4F76-ABD5-CD13DBAC4119@yahoo.com> Date: Mon, 22 May 2023 16:58:47 -0700 Cc: "kevans@freebsd.org" To: John Baldwin , dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3731.400.51.1.1) References: <894110D7-EFB1-4F76-ABD5-CD13DBAC4119.ref@yahoo.com> X-Spamd-Result: default: False [-2.97 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.97)[-0.969]; MV_CASE(0.50)[]; SUBJECT_ENDS_SPACES(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; MIME_GOOD(-0.10)[text/plain]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.64.32:from]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; RCVD_TLS_LAST(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; FREEMAIL_FROM(0.00)[yahoo.com]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.64.32:from] X-Rspamd-Queue-Id: 4QQDtx72z6z3DMV X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N John Baldwin wrote on Date: Mon, 22 May 2023 23:18:34 UTC : > On 5/15/23 2:59 PM, Jessica Clarke wrote: > > On 15 May 2023, at 16:42, Kyle Evans wrote: > >> > >> The branch main has been updated by kevans: > >> > >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dccb59683b98360afaf5b5bb641a68fea= 22c68d0b > >> > >> commit ccb59683b98360afaf5b5bb641a68fea22c68d0b > >> Author: Kyle Evans > >> AuthorDate: 2023-05-15 15:42:16 +0000 > >> Commit: Kyle Evans > >> CommitDate: 2023-05-15 15:42:16 +0000 > >> > >> arm64: add tests for swp/swpb emulation > >> > >> One test is suitable to be hooked up to the build, so I've done = this > >> here. The other test lives in tools/regression because failure is a > >> bit more subjective -- generally, one runs it for some unbounded = amount > >> of time and observe if it eventually exits because two threads = acquired > >> the same mutex. > >> > >> Reviewed by: imp, mmel > >> Sponsored by: Stormshield > >> Sponsored by: Klara, Inc. > >> Differential Revision: https://reviews.freebsd.org/D39668 > >> --- > >> etc/mtree/BSD.tests.dist | 2 + > >> tests/sys/Makefile | 1 + > >> tests/sys/compat32/Makefile | 6 + > >> tests/sys/compat32/Makefile.inc | 4 + > >> tests/sys/compat32/aarch64/Makefile | 24 ++ > >> tests/sys/compat32/aarch64/common.sh | 9 + > >> tests/sys/compat32/aarch64/swp_cond_test.sh | 14 + > >> tests/sys/compat32/aarch64/swp_cond_test_impl.S | 413 = ++++++++++++++++++++++ > >> tests/sys/compat32/aarch64/swp_test.sh | 14 + > >> tests/sys/compat32/aarch64/swp_test_impl.S | 216 +++++++++++ > >> tools/regression/compat32/aarch64/Makefile | 4 + > >> tools/regression/compat32/aarch64/swp_test_impl.S | 410 = +++++++++++++++++++++ > >> 12 files changed, 1117 insertions(+) > >> > >> ... > >> diff --git a/tests/sys/compat32/aarch64/Makefile = b/tests/sys/compat32/aarch64/Makefile > >> new file mode 100644 > >> index 000000000000..716182b15d9c > >> --- /dev/null > >> +++ b/tests/sys/compat32/aarch64/Makefile > >> @@ -0,0 +1,24 @@ > >> +PACKAGE=3D tests > >> +FILESGROUPS+=3D asmprogs > >> + > >> +ACFLAGS=3D -target armv7-unknown-freebsd${OS_REVISION} -nostdlib = -Wl,-e -Wl,main -static > >=20 > > This won=E2=80=99t work with GCC, nor will it work with an LLVM = built with only > > AArch64 enabled as a target (e.g. -DWITHOUT_LLVM_TARGET_ALL > > -DWITHOUT_LLVM_TARGET_ARM; latter is needed since we do default to > > enabling ARM if AArch64 is even for a cut-down toolchain so that = -m32 > > works). This is why the freebsd32 sigcode in arm64 kernels is = written > > as hex (with disassembly comments) rather than assembled from proper > > source. >=20 > I haven't managed to get either 32-bit or 64-bit arm fully building = with > GCC FWIW. I think it can be fine to require that a system compiler for > arm64 support -m32. We de-facto require such for amd64 already. There is a possible implication for the build environment compared to what it is now . . . For: WITHOUT_LLVM_TARGET_AARCH64 Do not build LLVM target support for AArch64. The LLVM_TARGET_ALL option should be used rather than this in = most cases. and: WITHOUT_LLVM_TARGET_ARM Do not build LLVM target support for ARM. The = LLVM_TARGET_ALL option should be used rather than this in most cases. and the ARM part of: WITHOUT_LLVM_TARGET_ALL Only build the required LLVM target support. This option = is preferred to specific target support options. When set, = these options are also in effect: WITHOUT_LLVM_TARGET_AARCH64 (unless = WITH_LLVM_TARGET_AARCH64 is set explicitly) WITHOUT_LLVM_TARGET_ARM (unless WITH_LLVM_TARGET_ARM is set explicitly) WITHOUT_LLVM_TARGET_POWERPC (unless = WITH_LLVM_TARGET_POWERPC is set explicitly) WITHOUT_LLVM_TARGET_RISCV (unless WITH_LLVM_TARGET_RISCV is = set explicitly) These might need some bundling such that AARCH64 being enabled (no WITHOUT) ends up forcing ARM to also be enabled (even if there is a WITHOUT). Or may be just report an incoherent combination and stop. =3D=3D=3D Mark Millard marklmi at yahoo.com