From owner-svn-src-head@freebsd.org Sun Dec 24 17:34:12 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67632E9FEC8; Sun, 24 Dec 2017 17:34:12 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 18A3E339A; Sun, 24 Dec 2017 17:34:11 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with ESMTPA id TA9yeCztNS7BpTA9ze0oWx; Sun, 24 Dec 2017 10:34:04 -0700 X-Authority-Analysis: v=2.2 cv=NKylwwyg c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=ocR9PWop10UA:10 a=vaJtXVxTAAAA:8 a=6I5d2MoRAAAA:8 a=iKhvJSA4AAAA:8 a=YxBL1-UpAAAA:8 a=dQsZOMc29GdFCuA00QQA:9 a=CjuIK1q_8ugA:10 a=T48UvIGfvqsA:10 a=IjZwj45LgO3ly-622nXo:22 a=odh9cflL3HIXMm4fY7Wr:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 95FF89D; Sun, 24 Dec 2017 09:34:01 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id vBOHY1qO099086; Sun, 24 Dec 2017 09:34:01 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id vBOHY0bh099042; Sun, 24 Dec 2017 09:34:01 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201712241734.vBOHY0bh099042@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "Andrey V. Elsukov" cc: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327140 - head/sbin/ipfw In-Reply-To: Message from "Andrey V. Elsukov" of "Sun, 24 Dec 2017 10:46:14 +0300." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 24 Dec 2017 09:34:00 -0800 X-CMAE-Envelope: MS4wfLHCBXuspwIont+HGB+1aXtNnmB0o7XE7JcaUm+Mw7Hy6nV5cD8gVOt2IG//O0LjHiR+4Vh+hKEkixaEI6/BQzoOzxksuyv31HcNCruAkJufaNKuz9Bk y7DYrYPY8J1in1udgPjx6s28ui1aU8cBXM7YZxhI+uOA24nv7rbbkOQkRtRk+wUrUld/KPVxFG2Pki1468j3lYJAzkwk00RfW7rOPv5fHwoUryZcXpV59wC8 8e3vRnRjwoUp86mhFiXB35ZwGG4tpFqjOXX7uZLbB44E2Bk7YIQSYuGa9gKxRfFm X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Dec 2017 17:34:12 -0000 In message , "Andrey V. Elsukov " writes: > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > --hploe8mi8b5CeIbHnELgS0brwST9uiIfp > Content-Type: multipart/mixed; boundary="Ua6VdxS4jpKDm90X0cEvNMeMts7m7TLRO"; > protected-headers="v1" > From: "Andrey V. Elsukov" > To: rgrimes@freebsd.org > Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, > svn-src-head@freebsd.org > Message-ID: > Subject: Re: svn commit: r327140 - head/sbin/ipfw > References: <201712240711.vBO7BNRG045404@pdx.rh.CN85.dnsmgr.net> > In-Reply-To: <201712240711.vBO7BNRG045404@pdx.rh.CN85.dnsmgr.net> > > --Ua6VdxS4jpKDm90X0cEvNMeMts7m7TLRO > Content-Type: text/plain; charset=utf-8 > Content-Language: en-US > Content-Transfer-Encoding: quoted-printable > > On 24.12.2017 10:11, Rodney W. Grimes wrote: > >> - uint32_t masks[2]; > >> - int i; > >> - uint8_t cmd, rulenum; > >> ipfw_range_tlv rt; > >> char *msg; > >> size_t size; > >> + uint32_t masks[2]; > >> + int i; > >=20 > > Why do these 2 lines show up as null changes in the diff???? > > I can not see any change, not even white space. > > They are sorted by size according to style(9). When I was still a grasshopper my sensei taught me not to batch commits. Looking back, this was wise advice as it is easier for those reading the logs to follow each intended change. The two commits should have been: 1) fix rule number truncation... and 2) sort size according to style(9). -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.