From owner-freebsd-current@FreeBSD.ORG Mon Mar 21 06:05:31 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D811E106566B for ; Mon, 21 Mar 2011 06:05:31 +0000 (UTC) (envelope-from demelier.david@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 668818FC12 for ; Mon, 21 Mar 2011 06:05:30 +0000 (UTC) Received: by fxm11 with SMTP id 11so6125471fxm.13 for ; Sun, 20 Mar 2011 23:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=K0WNs7zQ7/eR3FGbUSEFMRFtTrVT7tt6w05yeg0Qh1g=; b=Ix/JFH+zJpCPu8zXaRWdoDx8gE2GXSBiA7ymXeDjPs61WIOdDNkD2NUAa1ioTBVUdO NfzGHI+eOR39TWXqA8shlXrviX6WSbIrZ+Q7t6OHQvJkyxTO7mLsB3ZtDv13v/M+S7R3 jhdl8LMg7oqO1dQ0gST8eTJBYbVFl/VMaxP9w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=EPjd95JQZEQF/G84wIjQ0euvw6bz5E7xQ88bIdEeG0IdJv+Hr3c8yt0UZJBPSTsYfc Lk95eHNXXAzyJ1oeUBTUja8iO35VesIZQvWJZZIAPzw+n1PKCwL6IpuRlK5cyt7IdNUu rD0WY1KOt/gfYN0fDlDj0JqdYSEsNn6VVX7NM= Received: by 10.223.91.69 with SMTP id l5mr4445408fam.32.1300687530321; Sun, 20 Mar 2011 23:05:30 -0700 (PDT) Received: from Melon.malikania.fr (65.21.102-84.rev.gaoland.net [84.102.21.65]) by mx.google.com with ESMTPS id o12sm2109404fav.6.2011.03.20.23.05.28 (version=SSLv3 cipher=OTHER); Sun, 20 Mar 2011 23:05:28 -0700 (PDT) Message-ID: <4D86EA62.9060506@gmail.com> Date: Mon, 21 Mar 2011 07:04:18 +0100 From: David Demelier User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.15) Gecko/20110306 Thunderbird/3.1.9 MIME-Version: 1.0 To: Alexander Leidinger References: <4D85AE1B.7010407@gmail.com> <20110320173157.00002024@unknown> In-Reply-To: <20110320173157.00002024@unknown> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org Subject: Re: WITHOUT_JAIL and make delete-old{,-libs} X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2011 06:05:32 -0000 On 20/03/2011 17:31, Alexander Leidinger wrote: > On Sun, 20 Mar 2011 08:34:51 +0100 David Demelier > wrote: > >> Hello, >> >> I was surprised to see there is no ${MK_JAIL} conditional to remove >> old files on 8.2-RELEASE so I started to write it without watching if >> -CURRENT already make it in >> /usr/src/tools/build/mk/OptionalObsoleteFiles.inc. >> >> .if ${MK_JAIL} == no >> OLD_FILES+=usr/sbin/jail >> OLD_FILES+=usr/sbin/jexec >> OLD_FILES+=usr/sbin/jls >> OLD_FILES+=usr/share/man/man8/jail.8.gz >> OLD_FILES+=usr/share/man/man8/jexec.8.gz >> OLD_FILES+=usr/share/man/man8/jls.8.gz >> .endif >> >> I personnaly added more files : >> >> OLD_LIBS+=lib/libjail.so.1 >> OLD_LIBS+=usr/lib/libjail.a >> OLD_LIBS+=usr/lib/libjail_p.a >> OLD_FILES+=usr/lib/libjail.so >> OLD_FILES+=etc/rc.d/jail > > So if you do an installworld, do those files you added show up again or > not? If they show up, they are wrong to be added there. Delete old is > supposed to delete stuff which does not get installed during an > installworld but was installed in some older version of FreeBSD. From > my reading of the Makefile in src/lib/ (on -current) it looks like at > least the libjail is installed regardless of the knob. I do not know if > this is a bug or by design, this would have to be discussed on the > mailinglist which is about FreeBSD jails. > > If those files are not installed during an installworld, it's obviously > a bug which needs to be fixed (and I would have misunderstood the > Makefile). > >> (/usr/lib/libjail.so is a symbolic link) >> >> I think they should be removed too, thus can you merge it to -STABLE >> if it's not already done? (sorry I'm not used to the cvs web >> interface and I don't have -STABLE right now) >> >> Cheers, >> > No I understood why, that's because a lot of userland programs that can handle jails processes are linked to the libjail such as top, ifconfig, ... Cheers, -- David Demelier