From owner-cvs-all@FreeBSD.ORG Mon Apr 28 13:49:28 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E7D1B37B405 for ; Mon, 28 Apr 2003 13:49:28 -0700 (PDT) Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6015B43FA3 for ; Mon, 28 Apr 2003 13:49:27 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 6855 invoked from network); 28 Apr 2003 20:49:33 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 28 Apr 2003 20:49:33 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h3SKnKOv016004; Mon, 28 Apr 2003 16:49:21 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <3EAD744C.981EB57B@imimic.com> Date: Mon, 28 Apr 2003 16:49:25 -0400 (EDT) From: John Baldwin To: "Alan L. Cox" cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/osf1 osf1_signal.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Apr 2003 20:49:29 -0000 On 28-Apr-2003 Alan L. Cox wrote: > John Baldwin wrote: >> >> On 26-Apr-2003 Alan L. Cox wrote: >> > John Baldwin wrote: >> >> >> >> jhb 2003/04/25 12:52:30 PDT >> >> >> >> FreeBSD src repository >> >> >> >> Modified files: >> >> sys/alpha/osf1 osf1_signal.c >> >> Log: >> >> Lock Giant around calls to useracc() in osf1_sigreturn() so that the >> >> function is MP safe. >> >> >> >> Revision Changes Path >> >> 1.31 +5 -1 src/sys/alpha/osf1/osf1_signal.c >> > >> > The calls to useracc() should simply be eliminated because they are >> > redundant. See, for example, any of the implementations of sigreturn in >> > alpha/alpha/machdep.c. >> >> I don't mind if they are removed. :) >> > > Is that a subtle suggestion for me to do it? :-) Heh, if you want. At the moment I'm working on pushing Giant down (or eradicating it) from syscalls centered around process things such as signalling, etc. I figured the useracc() checks could be axed but chose to play it safe. I'd rather have someone more knowledgeable in the VM area axe them. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/