From owner-freebsd-ports@FreeBSD.ORG Sun Apr 8 16:43:54 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A472A106564A for ; Sun, 8 Apr 2012 16:43:54 +0000 (UTC) (envelope-from scheidell@FreeBSD.org) Received: from mx2.secnap.com.ionspam.net (mx2.secnap.com.ionspam.net [216.134.223.54]) by mx1.freebsd.org (Postfix) with ESMTP id 6DDFB8FC0C for ; Sun, 8 Apr 2012 16:43:54 +0000 (UTC) Received: from mx2.secnap.com.ionspam.net (unknown [10.71.0.54]) by mx2.secnap.com.ionspam.net (Postfix) with ESMTP id 41D58D23C04 for ; Sun, 8 Apr 2012 12:43:48 -0400 (EDT) X-Virus-Scanned: SpammerTrap(r) VPS-1500 2.18 at mx2.secnap.com.ionspam.net Received: from USBCTDC001.secnap.com (unknown [10.70.1.1]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx2.secnap.com.ionspam.net (Postfix) with ESMTPS id 3DBB2D23C03 for ; Sun, 8 Apr 2012 12:43:47 -0400 (EDT) Message-ID: <4F81C045.3030301@FreeBSD.org> Date: Sun, 8 Apr 2012 12:43:49 -0400 From: Michael Scheidell Organization: SECNAP Network Security Corp User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.7; en-US; rv:1.9.2.20) Gecko/20110804 Thunderbird/3.1.12 MIME-Version: 1.0 To: References: <4F732C89.3040804@FreeBSD.org> <4F733432.4020902@FreeBSD.org> <63ca1b333a310ecc2b1d1f0e1e1542a1.squirrel@mail.experts-exchange.com> <4F7338C3.8020003@p6m7g8.com> <4F733C3A.7020004@missouri.edu> <4F734524.2000400@p6m7g8.com> <4F735340.1020103@FreeBSD.org> <4F7379FD.9040802@p6m7g8.com> <20120329200243.GA76833@server.vk2pj.dyndns.org> <20120330131625.GA30070@atarininja.org> <4F75F3ED.9000508@p6m7g8.com> <4F75FA31.2030806@p6m7g8.com> <4F760FB3.6020708@FreeBSD.org> <4F761921.7030505@p6m7g8.com> <4F7DFAC9.1080806@FreeBSD.org> In-Reply-To: <4F7DFAC9.1080806@FreeBSD.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: FAQ on PORTREVISION bump? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Apr 2012 16:43:54 -0000 On 4/5/12 4:04 PM, Michael Scheidell wrote: > > On 3/30/12 4:35 PM, Philip M. Gollucci wrote: >> o When pkg-plist changes (except for fixing >>> .ifdef/NOPORT(DOCS|EXAMPLES)) >> #1 covers this, this is the OPTIONS case (default vs not) >> > perfect example, real world. > > And, in exactly this situation, I have submitted several pr's without > portrevision bumps, and they have all been committed like that. no > portrevision bump. > (did I mention I didn't commit them? other, more senior members of > the port team, who were the maintainers did?) > > Also, there is this one: waiting for maintainer timeout, > > on pointyhat, package won't change, since pointyhat does not define NOPORT(DOCS|EXAMPLES), so, package does not change. So, for all conditions: ie: we do/don't want pointyhat to rebuild pkg... this would be a noop. if we do/don't think the OP would want to rebuild pkg.. if they don't assign NOPORT*, then its a noop. (and if they are concerned, can rm the files.) and, no, pav is wrong ;-) you don't want to have your port do a rm -rf /usr/local/share. At least two ports that I know of put critical files in there, and, if you do that, the portupgrade/portmaster/make delinstall will squeal to the next system OP that there is something bad wrong, because pkg-plist is wrong, and it can't delete files, can't em dirs, and did not delete the package. anyone important want to commit this pr? http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165820 -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell