Date: Wed, 31 May 2023 19:42:05 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Dimitry Andric <dim@FreeBSD.org> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: "make hierarchy" from main tree breaks c++ headers on older branches with unclear errors if "make install world" is interrupted Message-ID: <3F4CBAD1-3C59-4A76-BDB2-F53A345BBB1A@gmail.com> In-Reply-To: <8CD00413-E6B3-4DBA-8A71-CAFA647DF2FF@FreeBSD.org> References: <E94D1471-8CDC-4AC3-A46B-C22922864637@gmail.com> <0DA92266-62F8-439E-9C56-44106A6B0073@FreeBSD.org> <FDF6450A-7BE8-432D-822B-46B1BC475BB2@gmail.com> <8CD00413-E6B3-4DBA-8A71-CAFA647DF2FF@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_C1F58AB8-E213-4CBF-B735-F42D49AE8532 Content-Type: multipart/alternative; boundary="Apple-Mail=_5EC10A4A-3679-4F15-847E-EC6F9FE88D22" --Apple-Mail=_5EC10A4A-3679-4F15-847E-EC6F9FE88D22 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 31, 2023, at 2:06 AM, Dimitry Andric <dim@FreeBSD.org> wrote: >=20 > On 31 May 2023, at 01:07, Enji Cooper <yaneurabeya@gmail.com = <mailto:yaneurabeya@gmail.com>> wrote: =E2=80=A6 >> That=E2=80=99s a fair point, however, given that this follows the = standard installation workflow=E2=80=A6 >> 1. etcupdate pre-run. >> 2. install kernel >> 3. reboot >> 4. make installworld >> 5. etcupdate post-run >> =E2=80=A6 this could surprise end-users. In particular, the C++ = compiler will be broken between step 1 and step 4. >=20 > How so? The deletion of the old __string file is done as part of = installworld, i.e. in step 4, not in any of the earlier steps. The only = case where you can have problems is when you start installworld, let it = run until it has completed its distrib-cleanup target, and then = interrupt it before it can install the new headers. No wait =E2=80=94 you=E2=80=99re right. The directories aren=E2=80= =99t created until =E2=80=9Cmake installworld=E2=80=9D is run so this is = a short-lived issue =E2=80=94 it impacts folks who run =E2=80=9Cmake = hierarchy=E2=80=9D out of band, but we=E2=80=99re an extreme exception, = not the norm. Thanks for helping me figure this out :). Cheers, -Enji --Apple-Mail=_5EC10A4A-3679-4F15-847E-EC6F9FE88D22 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br = class=3D""><div><blockquote type=3D"cite" class=3D""><div class=3D"">On = May 31, 2023, at 2:06 AM, Dimitry Andric <<a = href=3D"mailto:dim@FreeBSD.org" class=3D"">dim@FreeBSD.org</a>> = wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><meta = charset=3D"UTF-8" class=3D""><div class=3D"content-isolator__container" = style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: = 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none;">On 31 May 2023, = at 01:07, Enji Cooper <<a href=3D"mailto:yaneurabeya@gmail.com" = class=3D"">yaneurabeya@gmail.com</a>> = wrote:</div></div></blockquote><div><br class=3D""></div>=E2=80=A6</div><d= iv><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D""><div class=3D"content-isolator__container" = style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: = 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none;"><blockquote = type=3D"cite" class=3D"">That=E2=80=99s a fair point, however, given = that this follows the standard installation workflow=E2=80=A6<br = class=3D"">1. etcupdate pre-run.<br class=3D"">2. install kernel<br = class=3D"">3. reboot<br class=3D"">4. make installworld<br class=3D"">5. = etcupdate post-run<br class=3D"">=E2=80=A6 this could surprise = end-users. In particular, the C++ compiler will be broken between step 1 = and step 4.<br class=3D""></blockquote><br class=3D"">How so? The = deletion of the old __string file is done as part of installworld, i.e. = in step 4, not in any of the earlier steps. The only case where you can = have problems is when you start installworld, let it run until it has = completed its distrib-cleanup target, and then interrupt it before it = can install the new headers.<br = class=3D""></div></div></blockquote></div><br class=3D""><div = class=3D""><span class=3D"Apple-tab-span" style=3D"white-space:pre"> = </span>No wait =E2=80=94 you=E2=80=99re right. The directories aren=E2=80=99= t created until =E2=80=9Cmake installworld=E2=80=9D is run so this is a = short-lived issue =E2=80=94 it impacts folks who run =E2=80=9Cmake = hierarchy=E2=80=9D out of band, but we=E2=80=99re an extreme exception, = not the norm.</div><div class=3D""><span class=3D"Apple-tab-span" = style=3D"white-space:pre"> </span>Thanks for helping me figure this = out :).</div><div class=3D"">Cheers,</div><div = class=3D"">-Enji</div></body></html>= --Apple-Mail=_5EC10A4A-3679-4F15-847E-EC6F9FE88D22-- --Apple-Mail=_C1F58AB8-E213-4CBF-B735-F42D49AE8532 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEtvtxN6kOllEF3nmX5JFNMZeDGN4FAmR4BX0ACgkQ5JFNMZeD GN4ENxAAjoHcPrqjKSYTFyUGop3TlYwz/zBnn9F605oi332oVEptSaf0VJmvMyrY iDWw90oCt3NmeTJrdEYqO2+A4DVGf2X6pPHN/5ZLykxEW422tSaJPwtxJRYBqS+s nhV0PbtzVjbgs/H9lZL9ueGPEWQvq0C9QDcozrGJB5hppI6F83F3aE5BUF+ninX0 wpXnVs6xSh07AVQWQHON0k0FKfl6o07fJtSD8B2yhc7QSN15V37dKWVqOor+3BLB aGuk0tjxunLH94GG7Oc6yd0820MRO8rmxX/AQXnNRSC1qtlBaLA7+alO57KA3JlO Yi7sMWSh3JlojQdiKx1ebXlQagU4HzlkfLsoGfuk4leao16KHlX/DeDYM/fHq3vB cn7VHMSgzIvAVYR41+0GbvHc8k8BB1ElvWFPjBmLCsn8U5F3d2fymoQu7HqTAKSH hCQXBvA1fx1SxX4OO3Qb3zf5qjUvAMQVsfy3RytBoC/S7qu6BRWnSODu0a7xmbCf Ael04VrEOnfScy066VRXPzqB9lq/65ycbQRycuB+Sudnc+PlPvm+jg6/E5/HD0/2 I7Y/o+M3GFPM54An5zzR54Q0JlRGGDvSK+hKLqZE5pjx5EmVH8PPzxWe06EQbLEY 8rnO/6IDykzFSdjkSB8VUHm1qUQuaHyGn6zeFM+ny2OWGqsPN5c= =EOCb -----END PGP SIGNATURE----- --Apple-Mail=_C1F58AB8-E213-4CBF-B735-F42D49AE8532--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3F4CBAD1-3C59-4A76-BDB2-F53A345BBB1A>