From owner-svn-src-all@FreeBSD.ORG Tue Sep 10 06:41:57 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 2A381EC0; Tue, 10 Sep 2013 06:41:57 +0000 (UTC) (envelope-from jmg@h2.funkthat.com) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DB3CB2E51; Tue, 10 Sep 2013 06:41:56 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id r8A6foDt053621 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 9 Sep 2013 23:41:50 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id r8A6fnvR053620; Mon, 9 Sep 2013 23:41:49 -0700 (PDT) (envelope-from jmg) Date: Mon, 9 Sep 2013 23:41:49 -0700 From: John-Mark Gurney To: "David O'Brien" Subject: Re: svn commit: r255187 - in head/sys: conf crypto/aesni modules/aesni Message-ID: <20130910064149.GS68682@funkthat.com> References: <201309031831.r83IVNkh026523@svn.freebsd.org> <20130910060132.GA61541@dragon.NUXI.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130910060132.GA61541@dragon.NUXI.org> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Mon, 09 Sep 2013 23:41:50 -0700 (PDT) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, re@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Sep 2013 06:41:57 -0000 David O'Brien wrote this message on Mon, Sep 09, 2013 at 23:01 -0700: > On Tue, Sep 03, 2013 at 06:31:23PM +0000, John-Mark Gurney wrote: > > Log: > > Use the fact that the AES-NI instructions can be pipelined to improve > > performance... Use SSE2 instructions for calculating the XTS tweek > > factor... Let the compiler do more work and handle register allocation > > by using intrinsics, now only the key schedule is in assembly... > > Hi John-Mark, > Unfortunately this does not work with /usr/bin/gcc (which I still use as > /usr/bin/cc on this old IBM T60 laptop due to clang's enormous pestimation > on 'make world' and build times. > > Please fix this ASAP or back it out out of 10-CURRENT as it does not work > with /usr/bin/gcc: > > 1. /usr/bin/gcc cannot handle the "-maes" option. > I committed r255440 to address this. Please back that out until you have an understand of what the real problem is... I'm sad that the commit was approved w/o bothering to attempt to figure out the problem... > 2. /usr/src/sys/modules/aesni/../../crypto/aesni/aesencdec.h:30:23: error: wmmintrin.h: No such file or directory > and then a cascade of errors follow. Sounds like you don't have the latest in-tree gcc... I've been compiling the AES module w/ the in tree gcc for a while.. This is w/ the changes in r255185... > For now, I've sent a patch to re@ for approval to remove the 'aesni' > module from the build if not using clang. But the LINT build is > still broken with /usr/bin/gcc. I'll strongly object to this change... > > Replace .byte hard coded instructions w/ the proper instructions now > > that both clang and gcc support them... > > Is this out-of-tree latest GCC that supports this? Nope, in-tree... Sounds like you haven't installed the latest version of gcc in tree... It could be a problem with a bad interaction w/ delete-old as glebius added the wmmintrin.h header to the delete-old target in r255354... I'll take a closer look at this in the morning, but next time please attempt to contact the author before taking such actions... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."