From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Sep 5 19:00:05 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6DC7A1065673 for ; Mon, 5 Sep 2011 19:00:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 21D978FC15 for ; Mon, 5 Sep 2011 19:00:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p85J05Oj004124 for ; Mon, 5 Sep 2011 19:00:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p85J04UF004123; Mon, 5 Sep 2011 19:00:04 GMT (envelope-from gnats) Resent-Date: Mon, 5 Sep 2011 19:00:04 GMT Resent-Message-Id: <201109051900.p85J04UF004123@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Marcin Wisnicki Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B1851065670 for ; Mon, 5 Sep 2011 18:56:26 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 3A7C38FC13 for ; Mon, 5 Sep 2011 18:56:26 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p85IuPO0098066 for ; Mon, 5 Sep 2011 18:56:25 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p85IuPox098065; Mon, 5 Sep 2011 18:56:25 GMT (envelope-from nobody) Message-Id: <201109051856.p85IuPox098065@red.freebsd.org> Date: Mon, 5 Sep 2011 18:56:25 GMT From: Marcin Wisnicki To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/160490: [PATCH] x11-toolkits/gtk20: drag and drop broken in vnc server X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Sep 2011 19:00:05 -0000 >Number: 160490 >Category: ports >Synopsis: [PATCH] x11-toolkits/gtk20: drag and drop broken in vnc server >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Sep 05 19:00:04 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Marcin Wisnicki >Release: 8.2-STABLE >Organization: >Environment: >Description: https://bugzilla.gnome.org/show_bug.cgi?id=620240 Unfortunately GNOME developers don't care about gtk2. >How-To-Repeat: As root: 1. pkg_add -r gnome2 vnc As user in X: 2. Xvnc :12 -SecurityTypes None & 3. vncviewer :12 & 4. export DISPLAY=:12 5. # start gnome or something (eg. nautilus) and try drag and drop >Fix: Patch attached with submission follows: Commit 0efb24f589a74c4a4e78a1803d6e7205be9c1984 to gtk2 breaks drag and drop on VNC servers by ignoring X SHAPE extension specification for the benefit of two broken apps. Rationale: https://bugzilla.gnome.org/show_bug.cgi?id=620240#c11 --- gdk/x11/gdkwindow-x11.c.orig 2011-02-19 15:31:37.000000000 +0100 +++ gdk/x11/gdkwindow-x11.c 2011-09-05 19:21:10.000000000 +0200 @@ -4663,7 +4663,10 @@ window, shape_type, &rn, &ord); - if (xrl == NULL || rn == 0) + if (xrl == NULL) + return NULL; /* XShape not supported */ + + if (rn == 0) return gdk_region_new (); /* Empty */ if (ord != YXBanded) >Release-Note: >Audit-Trail: >Unformatted: