From owner-freebsd-ports@FreeBSD.ORG Tue Feb 24 07:59:09 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B12E16A4CE for ; Tue, 24 Feb 2004 07:59:09 -0800 (PST) Received: from postman.arcor.de (newsread1.arcor-online.net [151.189.0.146]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A46A43D3F for ; Tue, 24 Feb 2004 07:59:08 -0800 (PST) (envelope-from eikemeier@fillmore-labs.com) Received: from fillmore.dyndns.org (port-212-202-51-138.reverse.qsc.de [212.202.51.138]) (authenticated bits=0)i1OFx0tw018653 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Tue, 24 Feb 2004 16:59:01 +0100 (MET) Received: from [172.16.0.2] (helo=fillmore-labs.com) by fillmore.dyndns.org with esmtp (Exim 4.30; FreeBSD) id 1AvexW-0004Sy-Nn; Tue, 24 Feb 2004 16:58:58 +0100 Message-ID: <403B74B3.7060403@fillmore-labs.com> Date: Tue, 24 Feb 2004 16:58:43 +0100 From: Oliver Eikemeier Organization: Fillmore Labs GmbH - http://www.fillmore-labs.com/ MIME-Version: 1.0 To: Will Andrews References: <403B2336.1030607@fillmore-labs.com> <20040224153053.GR7466@sirius.firepipe.net> In-Reply-To: <20040224153053.GR7466@sirius.firepipe.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit User-Agent: KMail/1.5.9 cc: ports@FreeBSD.org cc: Mark Linimon Subject: Re: how to determine whether a port is a slave port? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2004 15:59:09 -0000 Will Andrews wrote: > On Tue, Feb 24, 2004 at 11:11:02AM +0100, Oliver Eikemeier wrote: > >>Since FreshPorts is having problems with that too, I suggest that >>a port is a slave port if and only if MASTERDIR is set, and to let >>us fix the other ports. That would make it easier for portlint too. > > All ports have MASTERDIR set in bsd.port.mk by default. > > Perhaps you mean: It's a slave when ${MASTERDIR} != ${.CURDIR}. Basically. I meant if and only if the *port* sets MASTERDIR, which makes statements like MASTERDIR= ${.CURDIR} a bug, since it would be a slave of itself. Generally I like to see that ports either not set MASTERDIR (besides the default in bsd.port.pre.mk) and end with .include or they set MASTERDIR (in their Makefile) and end with .include "${MASTERDIR}/Makefile" nothing else. I know the difference is subtle, but that would make it far easier for automated tools, I could even use grep to find all master/slave ports, without doing a make -VMASTERDIR. Regards Oliver