From owner-svn-src-stable-10@freebsd.org Thu Jun 22 10:28:29 2017 Return-Path: Delivered-To: svn-src-stable-10@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE580D88E6F; Thu, 22 Jun 2017 10:28:29 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 934ED7622D; Thu, 22 Jun 2017 10:28:29 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (d-24-245-127-120.cpe.metrocast.net [24.245.127.120]) by mail.baldwin.cx (Postfix) with ESMTPSA id E202C10AF01; Thu, 22 Jun 2017 06:28:27 -0400 (EDT) Subject: Re: svn commit: r320222 - in stable/10: etc etc/cron.d etc/mtree etc/newsyslog.conf.d etc/pam.d etc/syslog.d tools/build/mk usr.sbin/cron/cron usr.sbin/cron/lib usr.sbin/syslogd To: "Ngie Cooper (yaneurabeya)" References: <201706220708.v5M78IYv080609@repo.freebsd.org> <223428BC-9035-4435-B8EB-9A72EDCDD225@gmail.com> Cc: Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org From: John Baldwin Message-ID: Date: Thu, 22 Jun 2017 06:28:26 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <223428BC-9035-4435-B8EB-9A72EDCDD225@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Thu, 22 Jun 2017 06:28:28 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2017 10:28:29 -0000 On 6/22/17 4:02 AM, Ngie Cooper (yaneurabeya) wrote: > >> On Jun 22, 2017, at 00:35, John Baldwin wrote: > > … > >> Please revert the breakout of the existing config files. I think that splitting >> up the conf files is too disruptive of a change (POLA) for stable branches. > > Done in r320229 and r320230. I haven't checked if this was merged to 11, but if so, I think they should also stay a single conf file in 11 for the same reason. >> This was agreed to by other folks in the followup thread to the commits in >> head that you continue to ignore. > > >> In head please either fully split up the files or revert to a single file >> (another part of that thread you continue to ignore). > > My eyes glazed over trying to read through all of the posts. I seem to have missed the point where a proposed change was made to split up the config files further. Could this please be summarized again? I think that having the files partially split up is the worst of both worlds as folks writing config management rules, etc. have to use different approaches depending on the rule. I think that is a headache and would rather have the config either be all in a single file, or all be split up into conf.d/ so that it is consistent. I also think that when splitting up a conf file we should do it all at once so that there is only one painful /etc merge instead of several of them. -- John Baldwin