From owner-freebsd-pkg@freebsd.org Wed Oct 14 18:55:50 2020 Return-Path: Delivered-To: freebsd-pkg@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 414C5440725 for ; Wed, 14 Oct 2020 18:55:50 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4CBM7V0C89z4LwH for ; Wed, 14 Oct 2020 18:55:50 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 0495544058D; Wed, 14 Oct 2020 18:55:50 +0000 (UTC) Delivered-To: pkg@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 033E744058C for ; Wed, 14 Oct 2020 18:55:50 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CBM7T2y4pz4M1l for ; Wed, 14 Oct 2020 18:55:49 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-io1-xd44.google.com with SMTP id r4so375205ioh.0 for ; Wed, 14 Oct 2020 11:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=u5uxm6rYkWQ4O1V4Nl0a9TAlXBElMo+DwfHP2VciwS4=; b=ijtqf1jBDQNVAE3bx0DqdnhquWvnbS42xNIoGL/56krYb9RACERqzUVj/beKKVYHFf i9SquutdjWymO+Iwe1aezlGCwZBfweN/k1RB3AHQp43IOxeBxuzqU6JoAReUrdKXV0aK e4BldH9stCsFgxuSGi2wZw2n0rV919WfZ8W0R/ddKM82823fcL7rpDKLsBUXu5pfyo14 JLbTpqHofXgufuqWRX5p52sbJvidPSoQcA+zHGLLfzCUU1GPR2AQCl2B31WKiqBBXmp+ 2jY38RJeUsWYTIHEBgZEdQEU4yRjzpRHeUil/K9TJXoiiLg/l6vL0/X3829cjCxWHhBs PexA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=u5uxm6rYkWQ4O1V4Nl0a9TAlXBElMo+DwfHP2VciwS4=; b=LVFYdne9rhS0irpzc6k8UDKPlWwynivTqj6UG+sMEKbHVzlXsPU9cqaJgD1rqZp+n6 5uqXt11mmgBp+Pgq5f3qML6TLQTBsEqkMB7bz6QRLSupDOCl8mtGVCz4aiNoWVAtVt6G S3oOEsef5ji/uHSvm2qktt5xTCwgThqwEZUwoBWWLVdwflwnVx7lWDA8f9jR0Sf9OJk/ HPozjhqksbl1EVWvxgJ1aY+Ek0VfMCezkM8S4nvO9IAlJrdUpwnLEwUdglmty+PNmoJn HZLuIfs4uZuqK5o7hmdaDXqW7et4rnEzE3GxgTFy83EOODZcaNY5bB1Ebob+EBIHIr+D v3XQ== X-Gm-Message-State: AOAM533L2Z6X/BmD2w3sODOq36Cl9MV6JV5dj2ZoaLrlaT1wyAY+f0Pa RQAnEtNZtgTNIYOB/3dAsU1i9g== X-Google-Smtp-Source: ABdhPJxfvHjof8n2pJ29r0/YzB03gCWVU6TCsGDyMyB6X+aTdrFwRoyGUlqsBg5nTheRxgfrDV89jQ== X-Received: by 2002:a02:ccac:: with SMTP id t12mr721078jap.109.1602701748512; Wed, 14 Oct 2020 11:55:48 -0700 (PDT) Received: from mutt-hbsd (pool-100-16-222-53.bltmmd.fios.verizon.net. [100.16.222.53]) by smtp.gmail.com with ESMTPSA id g8sm340299ioh.54.2020.10.14.11.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 11:55:47 -0700 (PDT) Date: Wed, 14 Oct 2020 14:55:47 -0400 From: Shawn Webb To: Baptiste Daroussin Cc: pkg@freebsd.org, HardenedBSD Developers Subject: Re: Filesystem extended attributes support Message-ID: References: <20200704141345.xwdf2ckxak2hfpkh@mutt-hbsd> <20200704201100.lkcde42gtlgspwpr@ivaldir.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="fpy4agvtcbifkabf" Content-Disposition: inline In-Reply-To: <20200704201100.lkcde42gtlgspwpr@ivaldir.net> X-Rspamd-Queue-Id: 4CBM7T2y4pz4M1l X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=ijtqf1jB; dmarc=none; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::d44 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org X-Spamd-Result: default: False [-1.72 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; NEURAL_HAM_MEDIUM(-0.99)[-0.989]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; NEURAL_HAM_LONG(-1.01)[-1.007]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[pkg@freebsd.org]; DMARC_NA(0.00)[hardenedbsd.org]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; CTYPE_MIXED_BOGUS(1.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::d44:from]; NEURAL_HAM_SHORT(-0.23)[-0.229]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[pkg]; RECEIVED_SPAMHAUS_PBL(0.00)[100.16.222.53:received] X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-pkg@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Binary package management and package tools discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2020 18:55:50 -0000 --fpy4agvtcbifkabf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jul 4, 2020 at 8:11 PM Baptiste Daroussin wrote: > On Sat, Jul 04, 2020 at 10:13:45AM -0400, Shawn Webb wrote: > > Hey FreeBSD pkg(8) developers, > > > > Attached is a patch that implements filesystem extended attributes > > support. Only the system namespace is supported. In case the patch > > gets scrubbed from this email, I've posted it here: > > https://gist.github.com/d0b4653bc5942dbcdcd1db877d37c2dc > > > > Anyone who wants to write unit tests is welcomed to do so. > > > > This patch to pkg does depend on a separate patch to libarchive: > > https://github.com/libarchive/libarchive/pull/1409 > > > > HardenedBSD has a separate patch to tmpfs that enables incredibly > > basic extended attribute support. The tmpfs patch is only needed for > > those who use tmpfs with poudriere. > > > > And finally, another patch to the jails subsystem that allows a > > privileged user within a jail to set system namespace filesystem > > extended attributes (disabled by default) is needed for poudriere > > users. > > > > The patch to tmpfs and jails is not included here as they are > > tangential. > > Thank you for the patch at quick glance it looks fine to me. I would have > obviously to wait for libarchive to merge the patch first to be able to > test it > and do a proper review at the time. > > Don't hesitate to ping me again if you see no progress with libarchive has > merged the said patch. > > I would have to rework it a bit probably: > - Add a configure detection of the fact libarchive does or not have the > necessary support > - Add regression tests to ensure I don't break this in the future. > - Maybe add an option to enable/disable it via pkg.conf (not sure yet about > that ;)) Following up: libarchive merged in the patch. https://github.com/libarchive/libarchive/pull/1409 Thanks, Shawn Webb Cofounder / Security Engineer HardenedBSD GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --fpy4agvtcbifkabf Content-Disposition: inline MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" --fpy4agvtcbifkabf--